automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Min Hu (Connor)" <humin29@huawei.com>
Subject: [dpdk-test-report] |WARNING| pw102736 [PATCH 1/3] app/testpmd: fix port status of active slave device
Date: Mon, 25 Oct 2021 08:41:37 +0200 (CEST)	[thread overview]
Message-ID: <20211025064137.A2958121E44@dpdk.org> (raw)
In-Reply-To: <20211025063922.34066-2-humin29@huawei.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/102736

_coding style issues_


WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#39: 
Subject: [dpdk-dev] [PATCH 1/3] app/testpmd: fix port status of active slave

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#57: 
Stopping a bond device also stops all active slaves under the bond device.

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#59: 
slaves from RTE_PORT_STARTED to RTE_PORT_STOPPED.

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#104: FILE: app/test-pmd/testpmd.c:2994:
+change_bonding_active_slave_port_status(portid_t bond_pid)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#106: FILE: app/test-pmd/testpmd.c:2996:
+	portid_t slave_pids[RTE_MAX_ETHPORTS];

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#108: FILE: app/test-pmd/testpmd.c:2998:
+	int num_active_slaves;

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#109: FILE: app/test-pmd/testpmd.c:2999:
+	portid_t slave_pid;

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#112: FILE: app/test-pmd/testpmd.c:3002:
+	num_active_slaves = rte_eth_bond_active_slaves_get(bond_pid, slave_pids,

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#112: FILE: app/test-pmd/testpmd.c:3002:
+	num_active_slaves = rte_eth_bond_active_slaves_get(bond_pid, slave_pids,

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#112: FILE: app/test-pmd/testpmd.c:3002:
+	num_active_slaves = rte_eth_bond_active_slaves_get(bond_pid, slave_pids,

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#114: FILE: app/test-pmd/testpmd.c:3004:
+	if (num_active_slaves < 0) {

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#115: FILE: app/test-pmd/testpmd.c:3005:
+		fprintf(stderr, "Failed to get slave list for port = %u
",

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#120: FILE: app/test-pmd/testpmd.c:3010:
+	for (i = 0; i < num_active_slaves; i++) {

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#121: FILE: app/test-pmd/testpmd.c:3011:
+		slave_pid = slave_pids[i];

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#121: FILE: app/test-pmd/testpmd.c:3011:
+		slave_pid = slave_pids[i];

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#122: FILE: app/test-pmd/testpmd.c:3012:
+		port = &ports[slave_pid];

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#126: FILE: app/test-pmd/testpmd.c:3016:
+				slave_pid);

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#144: FILE: app/test-pmd/testpmd.c:3080:
+			 * Stopping a bond device also stops all active slaves

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#146: FILE: app/test-pmd/testpmd.c:3082:
+			 * we need to modify the port status of all slaves.

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#149: FILE: app/test-pmd/testpmd.c:3085:
+				change_bonding_active_slave_port_status(pi);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#167: FILE: app/test-pmd/testpmd.h:240:
+	uint8_t                 slave_flag : 1, /**< bonding slave port */

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#167: FILE: app/test-pmd/testpmd.h:240:
+	uint8_t                 slave_flag : 1, /**< bonding slave port */

total: 0 errors, 22 warnings, 83 lines checked
Warning in app/test-pmd/testpmd.c:
Using rte_atomicNN_xxx

           reply	other threads:[~2021-10-25  6:41 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20211025063922.34066-2-humin29@huawei.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211025064137.A2958121E44@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=humin29@huawei.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).