automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Tianli Lai <laitianli@tom.com>
Subject: |WARNING| pw104123 [PATCH] mempool: fix rte primary program coredump
Date: Wed, 10 Nov 2021 16:58:19 +0100 (CET)	[thread overview]
Message-ID: <20211110155819.37764120735@dpdk.org> (raw)
In-Reply-To: <1636559839-6553-1-git-send-email-laitianli@tom.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/104123

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#81: 
 #0  0x00007ffff5f2cc0b in bucket_stack_pop (stack=0xffff00010000) at /ofp/dpdk/drivers/mempool/bucket/rte_mempool_bucket.c:95

ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#168: FILE: lib/librte_mempool/rte_mempool_ops.c

ERROR:CODE_INDENT: code indent should use tabs where possible
#183: FILE: lib/librte_mempool/rte_mempool_ops.c:78:
+                "dpaa2", "dpaa", "bucket",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#183: FILE: lib/librte_mempool/rte_mempool_ops.c:78:
+                "dpaa2", "dpaa", "bucket",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#184: FILE: lib/librte_mempool/rte_mempool_ops.c:79:
+        };$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#184: FILE: lib/librte_mempool/rte_mempool_ops.c:79:
+        };$

ERROR:SPACING: spaces required around that '=' (ctx:VxW)
#189: FILE: lib/librte_mempool/rte_mempool_ops.c:84:
+	uint32_t i = 0, j= 0;
 	                 ^

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#192: FILE: lib/librte_mempool/rte_mempool_ops.c:87:
+		const char* name = memops_name[i];

ERROR:SPACING: space required before the open parenthesis '('
#193: FILE: lib/librte_mempool/rte_mempool_ops.c:88:
+		if(name && strlen(name)) {

ERROR:SPACING: space required before the open parenthesis '('
#194: FILE: lib/librte_mempool/rte_mempool_ops.c:89:
+			for(j = 0; j < rte_mempool_ops_table.num_ops; j++) {

ERROR:SPACING: space required before the open parenthesis '('
#195: FILE: lib/librte_mempool/rte_mempool_ops.c:90:
+				if(strcmp(name, rte_mempool_ops_table.ops[j].name))

total: 8 errors, 3 warnings, 57 lines checked

       reply	other threads:[~2021-11-10 15:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1636559839-6553-1-git-send-email-laitianli@tom.com>
2021-11-10 15:58 ` checkpatch [this message]
2021-11-10 16:39 ` |FAILURE| " 0-day Robot
2021-11-10 16:29 |WARNING| " dpdklab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211110155819.37764120735@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=laitianli@tom.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).