From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 01591A034F
	for <public@inbox.dpdk.org>; Wed, 10 Nov 2021 16:58:20 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id EACB04068B;
	Wed, 10 Nov 2021 16:58:20 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 4FA7A40683
 for <test-report@dpdk.org>; Wed, 10 Nov 2021 16:58:19 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 37764120735; Wed, 10 Nov 2021 16:58:19 +0100 (CET)
Subject: |WARNING| pw104123 [PATCH] mempool: fix rte primary program coredump
In-Reply-To: <1636559839-6553-1-git-send-email-laitianli@tom.com>
References: <1636559839-6553-1-git-send-email-laitianli@tom.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Tianli Lai <laitianli@tom.com>
Message-Id: <20211110155819.37764120735@dpdk.org>
Date: Wed, 10 Nov 2021 16:58:19 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/104123

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#81: 
 #0  0x00007ffff5f2cc0b in bucket_stack_pop (stack=0xffff00010000) at /ofp/dpdk/drivers/mempool/bucket/rte_mempool_bucket.c:95

ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#168: FILE: lib/librte_mempool/rte_mempool_ops.c

ERROR:CODE_INDENT: code indent should use tabs where possible
#183: FILE: lib/librte_mempool/rte_mempool_ops.c:78:
+                "dpaa2", "dpaa", "bucket",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#183: FILE: lib/librte_mempool/rte_mempool_ops.c:78:
+                "dpaa2", "dpaa", "bucket",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#184: FILE: lib/librte_mempool/rte_mempool_ops.c:79:
+        };$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#184: FILE: lib/librte_mempool/rte_mempool_ops.c:79:
+        };$

ERROR:SPACING: spaces required around that '=' (ctx:VxW)
#189: FILE: lib/librte_mempool/rte_mempool_ops.c:84:
+	uint32_t i = 0, j= 0;
 	                 ^

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#192: FILE: lib/librte_mempool/rte_mempool_ops.c:87:
+		const char* name = memops_name[i];

ERROR:SPACING: space required before the open parenthesis '('
#193: FILE: lib/librte_mempool/rte_mempool_ops.c:88:
+		if(name && strlen(name)) {

ERROR:SPACING: space required before the open parenthesis '('
#194: FILE: lib/librte_mempool/rte_mempool_ops.c:89:
+			for(j = 0; j < rte_mempool_ops_table.num_ops; j++) {

ERROR:SPACING: space required before the open parenthesis '('
#195: FILE: lib/librte_mempool/rte_mempool_ops.c:90:
+				if(strcmp(name, rte_mempool_ops_table.ops[j].name))

total: 8 errors, 3 warnings, 57 lines checked