From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Gregory Etelson <getelson@nvidia.com>
Subject: |WARNING| pw105365 [PATCH] net/mlx5: fix RSS expansion with explicit next protocol
Date: Thu, 23 Dec 2021 14:10:10 +0100 (CET) [thread overview]
Message-ID: <20211223131010.7B0D2120D7B@dpdk.org> (raw)
In-Reply-To: <20211223130817.14077-1-getelson@nvidia.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/105365
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fld' - possible side-effects?
#235: FILE: drivers/net/mlx5/mlx5_flow.c:246:
+#define MLX5_XSET_ITEM_MASK_SPEC(type, fld) \
+ do { \
+ const void *m = item->mask; \
+ const void *s = item->spec; \
+ mask = m ? \
+ ((const struct rte_flow_item_##type *)m)->fld : \
+ rte_flow_item_##type##_mask.fld; \
+ spec = ((const struct rte_flow_item_##type *)s)->fld; \
+ } while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fld' may be better as '(fld)' to avoid precedence issues
#235: FILE: drivers/net/mlx5/mlx5_flow.c:246:
+#define MLX5_XSET_ITEM_MASK_SPEC(type, fld) \
+ do { \
+ const void *m = item->mask; \
+ const void *s = item->spec; \
+ mask = m ? \
+ ((const struct rte_flow_item_##type *)m)->fld : \
+ rte_flow_item_##type##_mask.fld; \
+ spec = ((const struct rte_flow_item_##type *)s)->fld; \
+ } while (0)
total: 0 errors, 0 warnings, 2 checks, 236 lines checked
next parent reply other threads:[~2021-12-23 13:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211223130817.14077-1-getelson@nvidia.com>
2021-12-23 13:10 ` checkpatch [this message]
2021-12-23 14:39 ` |SUCCESS| " 0-day Robot
2021-12-23 18:22 |WARNING| " dpdklab
2021-12-23 18:24 dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211223131010.7B0D2120D7B@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=getelson@nvidia.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).