From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CA7A9A0350
	for <public@inbox.dpdk.org>; Thu, 23 Dec 2021 14:10:12 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BD9DE410E0;
	Thu, 23 Dec 2021 14:10:12 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id A13C140E01
 for <test-report@dpdk.org>; Thu, 23 Dec 2021 14:10:11 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 7B0D2120D7B; Thu, 23 Dec 2021 14:10:10 +0100 (CET)
Subject: |WARNING| pw105365 [PATCH] net/mlx5: fix RSS expansion with explicit
 next protocol
In-Reply-To: <20211223130817.14077-1-getelson@nvidia.com>
References: <20211223130817.14077-1-getelson@nvidia.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Gregory Etelson <getelson@nvidia.com>
Message-Id: <20211223131010.7B0D2120D7B@dpdk.org>
Date: Thu, 23 Dec 2021 14:10:10 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/105365

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fld' - possible side-effects?
#235: FILE: drivers/net/mlx5/mlx5_flow.c:246:
+#define MLX5_XSET_ITEM_MASK_SPEC(type, fld)                              \
+	do {                                                             \
+		const void *m = item->mask;                              \
+		const void *s = item->spec;                              \
+		mask = m ?                                               \
+			((const struct rte_flow_item_##type *)m)->fld :  \
+			rte_flow_item_##type##_mask.fld;                 \
+		spec = ((const struct rte_flow_item_##type *)s)->fld;    \
+	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fld' may be better as '(fld)' to avoid precedence issues
#235: FILE: drivers/net/mlx5/mlx5_flow.c:246:
+#define MLX5_XSET_ITEM_MASK_SPEC(type, fld)                              \
+	do {                                                             \
+		const void *m = item->mask;                              \
+		const void *s = item->spec;                              \
+		mask = m ?                                               \
+			((const struct rte_flow_item_##type *)m)->fld :  \
+			rte_flow_item_##type##_mask.fld;                 \
+		spec = ((const struct rte_flow_item_##type *)s)->fld;    \
+	} while (0)

total: 0 errors, 0 warnings, 2 checks, 236 lines checked