|WARNING| pw105369 [PATCH] event/cnxk: add timer adapter periodic mode support

|WARNING| pw105369 [PATCH] event/cnxk: add timer adapter periodic mode support

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 2909 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/105369

_apply patch failure_

Submitter: Shijith Thotton <sthotton@marvell.com>
Date: Thursday, December 23 2021 16:06:22 
Applied on: CommitID:042f5a355a57b31a9f87824173a9d427b21abdb8
Apply patch set 105369 failed:

Checking patch drivers/event/cnxk/cnxk_tim_evdev.c...
Hunk #1 succeeded at 56 (offset -2 lines).
Hunk #2 succeeded at 110 (offset -2 lines).
error: while searching for:
		goto tim_hw_free;
	}

	if (rcfg->timer_tick_ns < min_intvl_ns) {
		if (rcfg->flags & RTE_EVENT_TIMER_ADAPTER_F_ADJUST_RES) {
			rcfg->timer_tick_ns = min_intvl_ns;

error: patch failed: drivers/event/cnxk/cnxk_tim_evdev.c:237
error: while searching for:
		}
	}

	if (rcfg->timer_tick_ns > rcfg->max_tmo_ns) {
		plt_err("Max timeout to too high");
		rc = -ERANGE;

error: patch failed: drivers/event/cnxk/cnxk_tim_evdev.c:246
error: while searching for:
	if (rc < 0)
		goto tim_bkt_free;

	rc = roc_tim_lf_config(&dev->tim, tim_ring->ring_id, clk_src, 0, 0,
			       tim_ring->nb_bkts, tim_ring->chunk_sz,
			       tim_ring->tck_int, tim_ring->tck_nsec, clk_freq);
	if (rc < 0) {

error: patch failed: drivers/event/cnxk/cnxk_tim_evdev.c:322
Hunk #6 succeeded at 377 (offset -128 lines).
Checking patch drivers/event/cnxk/cnxk_tim_evdev.h...
Hunk #1 succeeded at 140 (offset 5 lines).
Applying patch drivers/event/cnxk/cnxk_tim_evdev.c with 3 rejects...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Rejected hunk #3.
Rejected hunk #4.
Rejected hunk #5.
Hunk #6 applied cleanly.
Applied patch drivers/event/cnxk/cnxk_tim_evdev.h cleanly.
diff a/drivers/event/cnxk/cnxk_tim_evdev.c b/drivers/event/cnxk/cnxk_tim_evdev.c	(rejected hunks)
@@ -237,6 +239,12 @@ cnxk_tim_ring_create(struct rte_event_timer_adapter *adptr)
 		goto tim_hw_free;
 	}
 
+	if (rcfg->flags & RTE_EVENT_TIMER_ADAPTER_F_PERIODIC) {
+		/* Use 2 buckets to avoid contention */
+		rcfg->timer_tick_ns /= 2;
+		tim_ring->ena_periodic = 1;
+	}
+
 	if (rcfg->timer_tick_ns < min_intvl_ns) {
 		if (rcfg->flags & RTE_EVENT_TIMER_ADAPTER_F_ADJUST_RES) {
 			rcfg->timer_tick_ns = min_intvl_ns;
@@ -246,6 +254,9 @@ cnxk_tim_ring_create(struct rte_event_timer_adapter *adptr)
 		}
 	}
 
+	if (tim_ring->ena_periodic)
+		rcfg->max_tmo_ns = rcfg->timer_tick_ns * 2;
+
 	if (rcfg->timer_tick_ns > rcfg->max_tmo_ns) {
 		plt_err("Max timeout to too high");
 		rc = -ERANGE;
@@ -322,7 +333,8 @@ cnxk_tim_ring_create(struct rte_event_timer_adapter *adptr)
 	if (rc < 0)
 		goto tim_bkt_free;
 
-	rc = roc_tim_lf_config(&dev->tim, tim_ring->ring_id, clk_src, 0, 0,
+	rc = roc_tim_lf_config(&dev->tim, tim_ring->ring_id, clk_src,
+			       tim_ring->ena_periodic, tim_ring->ena_dfb,
 			       tim_ring->nb_bkts, tim_ring->chunk_sz,
 			       tim_ring->tck_int, tim_ring->tck_nsec, clk_freq);
 	if (rc < 0) {

https://lab.dpdk.org/results/dashboard/patchsets/20557/

UNH-IOL DPDK Community Lab

|WARNING| pw105369 [PATCH] event/cnxk: add timer adapter periodic mode support

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/105369

_coding style issues_


WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#93: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:61:
+		tim_ring->ena_dfb = tim_ring->ena_periodic ? 1 : 0;

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#93: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:61:
+		tim_ring->ena_dfb = tim_ring->ena_periodic ? 1 : 0;

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#102: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:115:
+	adptr_info->min_resolution_ns = tim_ring->ena_periodic ?

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#103: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:116:
+						tim_ring->max_tout :

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#104: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:117:
+						tim_ring->tck_nsec;

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#115: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:245:
+		tim_ring->ena_periodic = 1;

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#125: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:257:
+	if (tim_ring->ena_periodic)

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#136: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:336:
+	rc = roc_tim_lf_config(&dev->tim, tim_ring->ring_id, clk_src,

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#136: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:336:
+	rc = roc_tim_lf_config(&dev->tim, tim_ring->ring_id, clk_src,

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#136: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:336:
+	rc = roc_tim_lf_config(&dev->tim, tim_ring->ring_id, clk_src,

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#137: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:337:
+			       tim_ring->ena_periodic, tim_ring->ena_dfb,

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#137: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:337:
+			       tim_ring->ena_periodic, tim_ring->ena_dfb,

total: 0 errors, 12 warnings, 64 lines checked