From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Brandon Lo <blo@iol.unh.edu>
Subject: |WARNING| pw106709 [PATCH v2 3/5] examples/fips_validation: add json parsing
Date: Sat, 29 Jan 2022 18:04:21 +0100 (CET) [thread overview]
Message-ID: <20220129170421.D0D16120715@dpdk.org> (raw)
In-Reply-To: <20220129170313.489986-4-blo@iol.unh.edu>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/106709
_coding style issues_
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#139: FILE: examples/fips_validation/fips_validation.c:349:
+ if (info.file_type == FIPS_TYPE_JSON) return 0;
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#156: FILE: examples/fips_validation/fips_validation.c:459:
+ if (strstr(algo_str, "AES-GCM")) info.algo = FIPS_TEST_ALGO_AES_GCM;
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#157: FILE: examples/fips_validation/fips_validation.c:460:
+ else return -EINVAL;
WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#170: FILE: examples/fips_validation/fips_validation.c:473:
+ json_t *param = json_object_get(json_info.json_test_group, info.interim_callbacks[i].key);
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#174: FILE: examples/fips_validation/fips_validation.c:477:
+ /* First argument is blank because the key
+ is not included in the string being parsed. */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#174: FILE: examples/fips_validation/fips_validation.c:477:
+ is not included in the string being parsed. */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#199: FILE: examples/fips_validation/fips_validation.c:502:
+ /* First argument is blank because the key
+ is not included in the string being parsed. */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#199: FILE: examples/fips_validation/fips_validation.c:502:
+ is not included in the string being parsed. */
total: 3 errors, 5 warnings, 117 lines checked
Warning in examples/fips_validation/fips_validation.c:
Using %l format, prefer %PRI*64 if type is [u]int64_t
parent reply other threads:[~2022-01-29 17:04 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220129170313.489986-4-blo@iol.unh.edu>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220129170421.D0D16120715@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=blo@iol.unh.edu \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).