From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Min Hu (Connor)" <humin29@huawei.com>
Subject: |WARNING| pw108524 [PATCH] dpdk: show dev basic info
Date: Fri, 4 Mar 2022 02:24:53 +0100 (CET) [thread overview]
Message-ID: <20220304012453.DD0D71234A0@dpdk.org> (raw)
In-Reply-To: <20220304012257.39247-3-humin29@huawei.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/108524
_coding style issues_
ERROR:SPACING: space required after that close brace '}'
#169: FILE: app/proc-info/main.c:173:
+}eth_speed_table[] = {
ERROR:SPACING: space prohibited after that open parenthesis '('
#220: FILE: app/proc-info/main.c:795:
+ printf( " -- maximum number of MAC addresses: %u
"
ERROR:SPACING: space prohibited after that open parenthesis '('
#272: FILE: app/proc-info/main.c:847:
+ printf( " -- RSS disabled");
WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(eth_speed_table)
#291: FILE: app/proc-info/main.c:866:
+ int size = sizeof(eth_speed_table) / sizeof(eth_speed_table[0]);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#299: FILE: app/proc-info/main.c:874:
+ if (!(speed_capa & ETH_LINK_SPEED_FIXED)) {
+ printf("auto");
+ }
ERROR:SPACING: space prohibited after that open parenthesis '('
#318: FILE: app/proc-info/main.c:893:
+ printf( " -- Rx burst mode: %s%s
"
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#488: FILE: drivers/net/hns3/hns3_ethdev_dump.c:18:
+ static const char *state_name[] = {
ERROR:TRAILING_WHITESPACE: trailing whitespace
#566: FILE: drivers/net/hns3/hns3_ethdev_dump.c:96:
+^I};^I$
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#578: FILE: drivers/net/hns3/hns3_ethdev_dump.c:108:
+ static const char *tuple_name[] = {
WARNING:TYPO_SPELLING: '2st' may be misspelled - perhaps '2nd'?
#582: FILE: drivers/net/hns3/hns3_ethdev_dump.c:112:
+ "outer_vlan_2st_tag",
ERROR:TRAILING_WHITESPACE: trailing whitespace
#834: FILE: drivers/net/hns3/hns3_ethdev_dump.c:364:
+}^I^I^I$
ERROR:SPACING: space required after that ',' (ctx:VxV)
#900: FILE: drivers/net/hns3/hns3_ethdev_dump.c:430:
+ fprintf(file," - Rx/Tx Queue Info:
");
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#1096: FILE: drivers/net/hns3/hns3_ethdev_dump.c:626:
+ fprintf(file," - VLAN Config Info:
");
^
ERROR:TRAILING_WHITESPACE: trailing whitespace
#1109: FILE: drivers/net/hns3/hns3_ethdev_dump.c:639:
+^Iget_port_pvid_info(file, hw);^I$
CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#1125: FILE: drivers/net/hns3/hns3_ethdev_dump.c:655:
+ " id=%u reference_count=%u peak_rate=%"PRIu64"Bps
",
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1125: FILE: drivers/net/hns3/hns3_ethdev_dump.c:655:
+ " id=%u reference_count=%u peak_rate=%"PRIu64"Bps
",
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#1139: FILE: drivers/net/hns3/hns3_ethdev_dump.c:669:
+ " port_node:
"
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#1157: FILE: drivers/net/hns3/hns3_ethdev_dump.c:687:
+ fprintf(file, " tc_node:
");
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#1224: FILE: drivers/net/hns3/hns3_ethdev_dump.c:754:
+ " queue_node:
"
ERROR:TRAILING_WHITESPACE: trailing whitespace
#1377: FILE: drivers/net/hns3/hns3_ethdev_dump.c:907:
+^I^Ireturn 0;^I$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#1382: FILE: drivers/net/hns3/hns3_ethdev_dump.c:912:
+^Iget_fdir_basic_info(file, &hns->pf);^I$
total: 11 errors, 8 warnings, 1365 lines checked
next parent reply other threads:[~2022-03-04 1:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220304012257.39247-3-humin29@huawei.com>
2022-03-04 1:24 ` checkpatch [this message]
2022-03-04 2:09 dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304012453.DD0D71234A0@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=humin29@huawei.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).