* |WARNING| pw108526 [PATCH] net/bonding: fix slaves initializing on mtu setting
@ 2022-03-04 1:38 dpdklab
0 siblings, 0 replies; 2+ messages in thread
From: dpdklab @ 2022-03-04 1:38 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
[-- Attachment #1: Type: text/plain, Size: 6724 bytes --]
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/108526
_apply patch failure_
Submitter: Min Hu (Connor) <humin29@huawei.com>
Date: Friday, March 04 2022 01:22:56
Applied on: CommitID:305769000c40a4fdf1ed0cf24c157b447b91ea7d
Apply patch set 108526 failed:
Checking patch app/test/test_link_bonding.c...
error: while searching for:
test_params->nb_tx_q, &default_pmd_conf),
"rte_eth_dev_configure for port %d failed", port_id);
for (q_id = 0; q_id < test_params->nb_rx_q; q_id++)
TEST_ASSERT_SUCCESS(rte_eth_rx_queue_setup(port_id, q_id, RX_RING_SIZE,
rte_eth_dev_socket_id(port_id), &rx_conf_default,
error: patch failed: app/test/test_link_bonding.c:181
Checking patch app/test/test_link_bonding_rssconf.c...
error: while searching for:
RXTX_QUEUE_COUNT, eth_conf) == 0, "Failed to configure device %u",
port_id);
for (rxq = 0; rxq < RXTX_QUEUE_COUNT; rxq++) {
TEST_ASSERT(rte_eth_rx_queue_setup(port_id, rxq, RXTX_RING_SIZE,
rte_eth_dev_socket_id(port_id), NULL,
error: patch failed: app/test/test_link_bonding_rssconf.c:128
Checking patch drivers/net/bonding/eth_bond_private.h...
error: while searching for:
slave_configure(struct rte_eth_dev *bonded_eth_dev,
struct rte_eth_dev *slave_eth_dev);
void
slave_remove(struct bond_dev_private *internals,
struct rte_eth_dev *slave_eth_dev);
error: patch failed: drivers/net/bonding/eth_bond_private.h:246
Checking patch drivers/net/bonding/rte_eth_bond_api.c...
Hunk #1 succeeded at 572 (offset 6 lines).
Checking patch drivers/net/bonding/rte_eth_bond_pmd.c...
error: while searching for:
slave_configure(struct rte_eth_dev *bonded_eth_dev,
struct rte_eth_dev *slave_eth_dev)
{
struct bond_rx_queue *bd_rx_q;
struct bond_tx_queue *bd_tx_q;
uint16_t nb_rx_queues;
uint16_t nb_tx_queues;
int errval;
uint16_t q_id;
struct rte_flow_error flow_error;
struct bond_dev_private *internals = bonded_eth_dev->data->dev_private;
error: patch failed: drivers/net/bonding/rte_eth_bond_pmd.c:1678
error: while searching for:
slave_eth_dev->data->port_id, errval);
return errval;
}
/* Setup Rx Queues */
for (q_id = 0; q_id < bonded_eth_dev->data->nb_rx_queues; q_id++) {
error: patch failed: drivers/net/bonding/rte_eth_bond_pmd.c:1758
error: while searching for:
return errval;
}
if (internals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id] != NULL)
rte_flow_destroy(slave_eth_dev->data->port_id,
internals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id],
&flow_error);
errval = bond_ethdev_8023ad_flow_set(bonded_eth_dev,
slave_eth_dev->data->port_id);
error: patch failed: drivers/net/bonding/rte_eth_bond_pmd.c:1806
Hunk #4 succeeded at 2020 (offset 7 lines).
Hunk #5 succeeded at 268 (offset -3598 lines).
Applying patch app/test/test_link_bonding.c with 1 reject...
Rejected hunk #1.
Applying patch app/test/test_link_bonding_rssconf.c with 1 reject...
Rejected hunk #1.
Applying patch drivers/net/bonding/eth_bond_private.h with 1 reject...
Rejected hunk #1.
Applied patch drivers/net/bonding/rte_eth_bond_api.c cleanly.
Applying patch drivers/net/bonding/rte_eth_bond_pmd.c with 3 rejects...
Rejected hunk #1.
Rejected hunk #2.
Rejected hunk #3.
Hunk #4 applied cleanly.
Hunk #5 applied cleanly.
diff a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c (rejected hunks)
@@ -181,6 +181,10 @@ configure_ethdev(uint16_t port_id, uint8_t start, uint8_t en_isr)
test_params->nb_tx_q, &default_pmd_conf),
"rte_eth_dev_configure for port %d failed", port_id);
+ int ret = rte_eth_dev_set_mtu(port_id, 1550);
+ RTE_TEST_ASSERT(ret == 0 || ret == -ENOTSUP,
+ "rte_eth_dev_set_mtu for port %d failed", port_id);
+
for (q_id = 0; q_id < test_params->nb_rx_q; q_id++)
TEST_ASSERT_SUCCESS(rte_eth_rx_queue_setup(port_id, q_id, RX_RING_SIZE,
rte_eth_dev_socket_id(port_id), &rx_conf_default,
diff a/app/test/test_link_bonding_rssconf.c b/app/test/test_link_bonding_rssconf.c (rejected hunks)
@@ -128,6 +128,10 @@ configure_ethdev(uint16_t port_id, struct rte_eth_conf *eth_conf,
RXTX_QUEUE_COUNT, eth_conf) == 0, "Failed to configure device %u",
port_id);
+ int ret = rte_eth_dev_set_mtu(port_id, 1550);
+ RTE_TEST_ASSERT(ret == 0 || ret == -ENOTSUP,
+ "rte_eth_dev_set_mtu for port %d failed", port_id);
+
for (rxq = 0; rxq < RXTX_QUEUE_COUNT; rxq++) {
TEST_ASSERT(rte_eth_rx_queue_setup(port_id, rxq, RXTX_RING_SIZE,
rte_eth_dev_socket_id(port_id), NULL,
diff a/drivers/net/bonding/eth_bond_private.h b/drivers/net/bonding/eth_bond_private.h (rejected hunks)
@@ -246,6 +246,10 @@ int
slave_configure(struct rte_eth_dev *bonded_eth_dev,
struct rte_eth_dev *slave_eth_dev);
+int
+slave_start(struct rte_eth_dev *bonded_eth_dev,
+ struct rte_eth_dev *slave_eth_dev);
+
void
slave_remove(struct bond_dev_private *internals,
struct rte_eth_dev *slave_eth_dev);
diff a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c (rejected hunks)
@@ -1678,14 +1678,10 @@ int
slave_configure(struct rte_eth_dev *bonded_eth_dev,
struct rte_eth_dev *slave_eth_dev)
{
- struct bond_rx_queue *bd_rx_q;
- struct bond_tx_queue *bd_tx_q;
uint16_t nb_rx_queues;
uint16_t nb_tx_queues;
int errval;
- uint16_t q_id;
- struct rte_flow_error flow_error;
struct bond_dev_private *internals = bonded_eth_dev->data->dev_private;
@@ -1758,6 +1754,19 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,
slave_eth_dev->data->port_id, errval);
return errval;
}
+ return 0;
+}
+
+int
+slave_start(struct rte_eth_dev *bonded_eth_dev,
+ struct rte_eth_dev *slave_eth_dev)
+{
+ int errval = 0;
+ struct bond_rx_queue *bd_rx_q;
+ struct bond_tx_queue *bd_tx_q;
+ uint16_t q_id;
+ struct rte_flow_error flow_error;
+ struct bond_dev_private *internals = bonded_eth_dev->data->dev_private;
/* Setup Rx Queues */
for (q_id = 0; q_id < bonded_eth_dev->data->nb_rx_queues; q_id++) {
@@ -1806,10 +1815,13 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,
return errval;
}
- if (internals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id] != NULL)
- rte_flow_destroy(slave_eth_dev->data->port_id,
+ if (internals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id] != NULL) {
+ errval = rte_flow_destroy(slave_eth_dev->data->port_id,
internals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id],
&flow_error);
+ RTE_BOND_LOG(ERR, "bond_ethdev_8023ad_flow_destroy: port=%d, err (%d)",
+ slave_eth_dev->data->port_id, errval);
+ }
errval = bond_ethdev_8023ad_flow_set(bonded_eth_dev,
slave_eth_dev->data->port_id);
https://lab.dpdk.org/results/dashboard/patchsets/21388/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] 2+ messages in thread
* |WARNING| pw108526 [PATCH] net/bonding: fix slaves initializing on mtu setting
[not found] <20220304012257.39247-5-humin29@huawei.com>
@ 2022-03-04 1:24 ` checkpatch
0 siblings, 0 replies; 2+ messages in thread
From: checkpatch @ 2022-03-04 1:24 UTC (permalink / raw)
To: test-report; +Cc: Min Hu (Connor)
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/108526
_coding style issues_
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#33:
Subject: [PATCH] net/bonding: fix slaves initializing on mtu setting
WARNING:TYPO_SPELLING: 'Wan' may be misspelled - perhaps 'Want'?
#58:
From: Wan Junjie <wanjunjie@bytedance.com>
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#66:
-a 0000:af:00.0 --vdev="net_bonding0,mode=2,slave=0000:af:00.0"
WARNING:TYPO_SPELLING: 'compain' may be misspelled - perhaps 'complain'?
#68:
It will fail and compain for the slave device
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#68:
It will fail and compain for the slave device
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#123: FILE: drivers/net/bonding/eth_bond_private.h:250:
+slave_start(struct rte_eth_dev *bonded_eth_dev,
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#124: FILE: drivers/net/bonding/eth_bond_private.h:251:
+ struct rte_eth_dev *slave_eth_dev);
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#137: FILE: drivers/net/bonding/rte_eth_bond_api.c:569:
+ if (slave_start(bonded_eth_dev, slave_eth_dev) != 0) {
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#137: FILE: drivers/net/bonding/rte_eth_bond_api.c:569:
+ if (slave_start(bonded_eth_dev, slave_eth_dev) != 0) {
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#138: FILE: drivers/net/bonding/rte_eth_bond_api.c:570:
+ internals->slave_count--;
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#139: FILE: drivers/net/bonding/rte_eth_bond_api.c:571:
+ RTE_BOND_LOG(ERR, "rte_bond_slaves_start: port=%d",
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#140: FILE: drivers/net/bonding/rte_eth_bond_api.c:572:
+ slave_port_id);
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#173: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1761:
+slave_start(struct rte_eth_dev *bonded_eth_dev,
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#174: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1762:
+ struct rte_eth_dev *slave_eth_dev)
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#191: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1818:
+ if (internals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id] != NULL) {
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#192: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1819:
+ errval = rte_flow_destroy(slave_eth_dev->data->port_id,
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#196: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1823:
+ slave_eth_dev->data->port_id, errval);
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#205: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:2016:
+ if (slave_start(eth_dev, slave_ethdev) != 0) {
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#205: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:2016:
+ if (slave_start(eth_dev, slave_ethdev) != 0) {
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#207: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:2018:
+ "bonded port (%d) failed to start slave device (%d)",
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#209: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:2020:
+ internals->slaves[i].port_id);
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#219: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3869:
+ /* configure slaves so we can pass mtu setting */
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#220: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3870:
+ for (i = 0; i < internals->slave_count; i++) {
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#221: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3871:
+ struct rte_eth_dev *slave_ethdev =
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#222: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3872:
+ &(rte_eth_devices[internals->slaves[i].port_id]);
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#223: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3873:
+ if (slave_configure(dev, slave_ethdev) != 0) {
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#223: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3873:
+ if (slave_configure(dev, slave_ethdev) != 0) {
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#225: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3875:
+ "bonded port (%d) failed to configure slave device (%d)",
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#227: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3877:
+ internals->slaves[i].port_id);
total: 0 errors, 29 warnings, 0 checks, 121 lines checked
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-04 1:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-04 1:38 |WARNING| pw108526 [PATCH] net/bonding: fix slaves initializing on mtu setting dpdklab
[not found] <20220304012257.39247-5-humin29@huawei.com>
2022-03-04 1:24 ` checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).