From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4FDCFA0507
	for <public@inbox.dpdk.org>; Fri,  1 Apr 2022 15:31:09 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 4A38A42911;
	Fri,  1 Apr 2022 15:31:09 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 0841E4067E
 for <test-report@dpdk.org>; Fri,  1 Apr 2022 15:31:08 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 043A4120950; Fri,  1 Apr 2022 15:31:08 +0200 (CEST)
Subject: |WARNING| pw109079 [PATCH 1/3] eal/windows: translate Windows errors
 to errno-style errors
In-Reply-To: <1648819793-18948-2-git-send-email-roretzla@linux.microsoft.com>
References: <1648819793-18948-2-git-send-email-roretzla@linux.microsoft.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>
Message-Id: <20220401133108.043A4120950@dpdk.org>
Date: Fri,  1 Apr 2022 15:31:08 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/109079

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#82: FILE: lib/eal/windows/rte_thread.c:23:
+		return EINVAL;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EFAULT)
#85: FILE: lib/eal/windows/rte_thread.c:26:
+		return EFAULT;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#90: FILE: lib/eal/windows/rte_thread.c:31:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EACCES)
#95: FILE: lib/eal/windows/rte_thread.c:36:
+		return EACCES;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#98: FILE: lib/eal/windows/rte_thread.c:39:
+		return EEXIST;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EDEADLK)
#101: FILE: lib/eal/windows/rte_thread.c:42:
+		return EDEADLK;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOSYS)
#106: FILE: lib/eal/windows/rte_thread.c:47:
+		return ENOSYS;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#109: FILE: lib/eal/windows/rte_thread.c:50:
+	return EINVAL;

total: 0 errors, 8 warnings, 54 lines checked
Warning in lib/eal/windows/rte_thread.c:
Using %l format, prefer %PRI*64 if type is [u]int64_t