automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Subject: |WARNING| pw109411 [PATCH] test/crypto: add key exchange dh tests
Date: Thu,  7 Apr 2022 10:09:13 +0200 (CEST)	[thread overview]
Message-ID: <20220407080913.8D642122BA2@dpdk.org> (raw)
In-Reply-To: <20220407080722.18697-1-arkadiuszx.kusztal@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/109411

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#92: FILE: app/test/test_cryptodev_asym.c:41:
+#define TEST_CRYPTO_ASYM_NULL_RETURN(p, str) \
+	do {	\
+		if (p == NULL) {			\
+			RTE_LOG(ERR, USER1, "line %u FAILED: %s", \
+				__LINE__, str);		\
+			status = (ret == -ENOTSUP) ? \
+				TEST_SKIPPED : TEST_FAILED; \
+			goto error_exit;	\
+		}	\
+	} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#103: FILE: app/test/test_cryptodev_asym.c:52:
+#define TEST_CRYPTO_ASYM_NEG_RETURN(p, str) \
+	do {	\
+		if (p) {	\
+			RTE_LOG(ERR, USER1,	\
+				"line %u FAILED: %s",	\
+				__LINE__, str);	\
+			status = (ret == -ENOTSUP) ? \
+				TEST_SKIPPED : TEST_FAILED; \
+			goto error_exit; \
+		} \
+	} while (0)

total: 0 errors, 2 warnings, 618 lines checked

       reply	other threads:[~2022-04-07  8:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220407080722.18697-1-arkadiuszx.kusztal@intel.com>
2022-04-07  8:09 ` checkpatch [this message]
2022-04-07 10:00 ` |SUCCESS| " 0-day Robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220407080913.8D642122BA2@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).