automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: |WARNING| pw109607 [PATCH v2 1/4] eal/windows: translate Windows errors to errno-style errors
Date: Tue, 12 Apr 2022 12:44:31 +0200 (CEST)	[thread overview]
Message-ID: <20220412104431.CC217124164@dpdk.org> (raw)
In-Reply-To: <1649760220-8683-2-git-send-email-roretzla@linux.microsoft.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/109607

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#90: FILE: lib/eal/windows/rte_thread.c:24:
+		return EINVAL;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EFAULT)
#93: FILE: lib/eal/windows/rte_thread.c:27:
+		return EFAULT;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#98: FILE: lib/eal/windows/rte_thread.c:32:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EACCES)
#103: FILE: lib/eal/windows/rte_thread.c:37:
+		return EACCES;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#106: FILE: lib/eal/windows/rte_thread.c:40:
+		return EEXIST;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EDEADLK)
#109: FILE: lib/eal/windows/rte_thread.c:43:
+		return EDEADLK;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOSYS)
#114: FILE: lib/eal/windows/rte_thread.c:48:
+		return ENOSYS;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#117: FILE: lib/eal/windows/rte_thread.c:51:
+	return EINVAL;

total: 0 errors, 8 warnings, 60 lines checked
Warning in lib/eal/windows/rte_thread.c:
Using %l format, prefer %PRI*64 if type is [u]int64_t

           reply	other threads:[~2022-04-12 10:44 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1649760220-8683-2-git-send-email-roretzla@linux.microsoft.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220412104431.CC217124164@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=roretzla@linux.microsoft.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).