From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B0DF8A0509
	for <public@inbox.dpdk.org>; Tue, 12 Apr 2022 12:44:33 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AD1D840E03;
	Tue, 12 Apr 2022 12:44:33 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id CF3CC427F1
 for <test-report@dpdk.org>; Tue, 12 Apr 2022 12:44:31 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id CC217124164; Tue, 12 Apr 2022 12:44:31 +0200 (CEST)
Subject: |WARNING| pw109607 [PATCH v2 1/4] eal/windows: translate Windows
 errors to errno-style errors
In-Reply-To: <1649760220-8683-2-git-send-email-roretzla@linux.microsoft.com>
References: <1649760220-8683-2-git-send-email-roretzla@linux.microsoft.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>
Message-Id: <20220412104431.CC217124164@dpdk.org>
Date: Tue, 12 Apr 2022 12:44:31 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/109607

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#90: FILE: lib/eal/windows/rte_thread.c:24:
+		return EINVAL;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EFAULT)
#93: FILE: lib/eal/windows/rte_thread.c:27:
+		return EFAULT;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#98: FILE: lib/eal/windows/rte_thread.c:32:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EACCES)
#103: FILE: lib/eal/windows/rte_thread.c:37:
+		return EACCES;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#106: FILE: lib/eal/windows/rte_thread.c:40:
+		return EEXIST;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EDEADLK)
#109: FILE: lib/eal/windows/rte_thread.c:43:
+		return EDEADLK;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOSYS)
#114: FILE: lib/eal/windows/rte_thread.c:48:
+		return ENOSYS;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#117: FILE: lib/eal/windows/rte_thread.c:51:
+	return EINVAL;

total: 0 errors, 8 warnings, 60 lines checked
Warning in lib/eal/windows/rte_thread.c:
Using %l format, prefer %PRI*64 if type is [u]int64_t