automatic DPDK test reports
 help / color / mirror / Atom feed
From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Subject: |WARNING| pw110560 [PATCH] common/cnxk: fix channel number setting in MCAM entries
Date: Mon,  2 May 2022 05:08:47 -0400 (EDT)	[thread overview]
Message-ID: <20220502090847.D980BEEAC8@noxus.dpdklab.iol.unh.edu> (raw)

[-- Attachment #1: Type: text/plain, Size: 2462 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/110560

_apply patch failure_

Submitter: Satheesh Paul <psatheesh@marvell.com>
Date: Monday, May 02 2022 08:47:30 
Applied on: CommitID:90bf3f89ed33f78e9f41818caf123e13e508dee7
Apply patch set 110560 failed:

Checking patch drivers/common/cnxk/roc_npc_mcam.c...
error: while searching for:
	req->entry_data.kw_mask[0] &= ~(GENMASK(11, 0));
	flow->mcam_data[0] &= ~(GENMASK(11, 0));
	flow->mcam_mask[0] &= ~(GENMASK(11, 0));

	if (is_second_pass) {
		chan = (channel | NIX_CHAN_CPT_CH_START);
		mask = (chan_mask | NIX_CHAN_CPT_CH_START);
	} else {
		/*
		 * Clear bits 10 & 11 corresponding to CPT
		 * channel. By default, rules should match
		 * both first pass packets and second pass
		 * packets from CPT.
		 */
		chan = (channel & NIX_CHAN_CPT_X2P_MASK);
		mask = (chan_mask & NIX_CHAN_CPT_X2P_MASK);
	}

	req->entry_data.kw[0] |= (uint64_t)chan;

error: patch failed: drivers/common/cnxk/roc_npc_mcam.c:508
Applying patch drivers/common/cnxk/roc_npc_mcam.c with 1 reject...
Rejected hunk #1.
diff a/drivers/common/cnxk/roc_npc_mcam.c b/drivers/common/cnxk/roc_npc_mcam.c	(rejected hunks)
@@ -508,19 +508,25 @@ npc_mcam_set_channel(struct roc_npc_flow *flow,
 	req->entry_data.kw_mask[0] &= ~(GENMASK(11, 0));
 	flow->mcam_data[0] &= ~(GENMASK(11, 0));
 	flow->mcam_mask[0] &= ~(GENMASK(11, 0));
+	chan = channel;
+	mask = chan_mask;
 
-	if (is_second_pass) {
-		chan = (channel | NIX_CHAN_CPT_CH_START);
-		mask = (chan_mask | NIX_CHAN_CPT_CH_START);
-	} else {
-		/*
-		 * Clear bits 10 & 11 corresponding to CPT
-		 * channel. By default, rules should match
-		 * both first pass packets and second pass
-		 * packets from CPT.
-		 */
-		chan = (channel & NIX_CHAN_CPT_X2P_MASK);
-		mask = (chan_mask & NIX_CHAN_CPT_X2P_MASK);
+	if (roc_model_runtime_is_cn10k()) {
+		if (is_second_pass) {
+			chan = (channel | NIX_CHAN_CPT_CH_START);
+			mask = (chan_mask | NIX_CHAN_CPT_CH_START);
+		} else {
+			if (!(flow->npc_action & NIX_RX_ACTIONOP_UCAST_IPSEC)) {
+				/*
+				 * Clear bits 10 & 11 corresponding to CPT
+				 * channel. By default, rules should match
+				 * both first pass packets and second pass
+				 * packets from CPT.
+				 */
+				chan = (channel & NIX_CHAN_CPT_X2P_MASK);
+				mask = (chan_mask & NIX_CHAN_CPT_X2P_MASK);
+			}
+		}
 	}
 
 	req->entry_data.kw[0] |= (uint64_t)chan;

https://lab.dpdk.org/results/dashboard/patchsets/21978/

UNH-IOL DPDK Community Lab

             reply	other threads:[~2022-05-02  9:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-02  9:08 dpdklab [this message]
2022-05-06 17:03 dpdklab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220502090847.D980BEEAC8@noxus.dpdklab.iol.unh.edu \
    --to=dpdklab@iol.unh.edu \
    --cc=dpdk-test-reports@iol.unh.edu \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).