From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 03A1CA0093
	for <public@inbox.dpdk.org>; Tue,  3 May 2022 06:25:45 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id F421E40E2D;
	Tue,  3 May 2022 06:25:44 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 99F2140C35
 for <test-report@dpdk.org>; Tue,  3 May 2022 06:25:43 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 95342124164; Tue,  3 May 2022 06:25:43 +0200 (CEST)
Subject: |WARNING| pw110591 [PATCH 5/8] vmxnet3, version 6
In-Reply-To: <20220503042257.15626-6-pagupta@vmware.com>
References: <20220503042257.15626-6-pagupta@vmware.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Pankaj Gupta <pagupta@vmware.com>
Message-Id: <20220503042543.95342124164@dpdk.org>
Date: Tue,  3 May 2022 06:25:43 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/110591

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <Vmxnet3_IntrConfExt>
#233: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:614:
+struct Vmxnet3_IntrConfExt {

CHECK:CAMELCASE: Avoid CamelCase: <numIntrs>
#235: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:616:
+	uint8    numIntrs;      /* # of interrupts */

CHECK:CAMELCASE: Avoid CamelCase: <eventIntrIdx>
#236: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:617:
+	uint8    eventIntrIdx;

CHECK:CAMELCASE: Avoid CamelCase: <modLevels>
#240: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:621:
+	uint8    modLevels[VMXNET3_EXT_MAX_INTRS]; /* moderation level for each intr */

CHECK:CAMELCASE: Avoid CamelCase: <Vmxnet3_DSDevReadExt>
#255: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:734:
+struct Vmxnet3_DSDevReadExt {

CHECK:CAMELCASE: Avoid CamelCase: <intrConfExt>
#257: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:736:
+	struct Vmxnet3_IntrConfExt    intrConfExt;

CHECK:CAMELCASE: Avoid CamelCase: <devRead>
#283: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:829:
+	Vmxnet3_DSDevRead    devRead;

CHECK:CAMELCASE: Avoid CamelCase: <cmdInfo>
#290: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:836:
+		Vmxnet3_CmdInfo	cmdInfo;

CHECK:CAMELCASE: Avoid CamelCase: <devReadExt>
#292: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:838:
+	struct Vmxnet3_DSDevReadExt   devReadExt;

CHECK:CAMELCASE: Avoid CamelCase: <out_eventIntrIdx>
#318: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:229:
+			 uint8 **out_eventIntrIdx,

CHECK:CAMELCASE: Avoid CamelCase: <out_intrCtrl>
#319: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:230:
+			 uint32 **out_intrCtrl)

CHECK:CAMELCASE: Avoid CamelCase: <queuesExtEnabled>
#329: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:233:
+	if (VMXNET3_VERSION_GE_6(hw) && hw->queuesExtEnabled) {

CHECK:CAMELCASE: Avoid CamelCase: <intrConf>
#337: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:237:
+		*out_eventIntrIdx = &hw->shared->devRead.intrConf.eventIntrIdx;

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#559: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:1440:
+#define MIN(x, y) (((x) < (y)) ? (x) : (y))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'y' - possible side-effects?
#559: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:1440:
+#define MIN(x, y) (((x) < (y)) ? (x) : (y))

CHECK:CAMELCASE: Avoid CamelCase: <UPT1_TxStats>
#693: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:121:
+	UPT1_TxStats	      saved_tx_stats[VMXNET3_EXT_MAX_TX_QUEUES];

CHECK:CAMELCASE: Avoid CamelCase: <UPT1_RxStats>
#694: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:122:
+	UPT1_RxStats	      saved_rx_stats[VMXNET3_EXT_MAX_RX_QUEUES];

CHECK:CAMELCASE: Avoid CamelCase: <indTableSize>
#719: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1403:
+	dev_rss_conf->indTableSize = (uint16_t)(MAX_RX_QUEUES * 4);

total: 0 errors, 0 warnings, 18 checks, 559 lines checked