From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Dongdong Liu <liudongdong3@huawei.com>
Subject: |WARNING| pw112436 [PATCH v4] app/testpmd: fix slave device isn't released
Date: Tue, 7 Jun 2022 10:11:30 +0200 (CEST) [thread overview]
Message-ID: <20220607081130.97A36120945@dpdk.org> (raw)
In-Reply-To: <20220607081038.23859-1-liudongdong3@huawei.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/112436
_coding style issues_
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#34:
Subject: [PATCH v4] app/testpmd: fix slave device isn't released
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#62:
release operation for all active slaves under a bond device.
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#105: FILE: app/test-pmd/testpmd.c:3206:
+clear_bonding_slave_device(portid_t *slave_pids, uint16_t num_slaves)
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#105: FILE: app/test-pmd/testpmd.c:3206:
+clear_bonding_slave_device(portid_t *slave_pids, uint16_t num_slaves)
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#105: FILE: app/test-pmd/testpmd.c:3206:
+clear_bonding_slave_device(portid_t *slave_pids, uint16_t num_slaves)
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#109: FILE: app/test-pmd/testpmd.c:3210:
+ portid_t slave_pid;
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#112: FILE: app/test-pmd/testpmd.c:3213:
+ for (i = 0; i < num_slaves; i++) {
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#113: FILE: app/test-pmd/testpmd.c:3214:
+ slave_pid = slave_pids[i];
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#113: FILE: app/test-pmd/testpmd.c:3214:
+ slave_pid = slave_pids[i];
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#114: FILE: app/test-pmd/testpmd.c:3215:
+ if (port_is_started(slave_pid) == 1) {
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#115: FILE: app/test-pmd/testpmd.c:3216:
+ if (rte_eth_dev_stop(slave_pid) != 0)
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#117: FILE: app/test-pmd/testpmd.c:3218:
+ slave_pid);
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#119: FILE: app/test-pmd/testpmd.c:3220:
+ port = &ports[slave_pid];
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#123: FILE: app/test-pmd/testpmd.c:3224:
+ clear_port_slave_flag(slave_pid);
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#123: FILE: app/test-pmd/testpmd.c:3224:
+ clear_port_slave_flag(slave_pid);
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#125: FILE: app/test-pmd/testpmd.c:3226:
+ /* Close slave device when testpmd quit or is killed. */
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#127: FILE: app/test-pmd/testpmd.c:3228:
+ rte_eth_dev_close(slave_pid);
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#130: FILE: app/test-pmd/testpmd.c:3231:
+ RTE_SET_USED(slave_pids);
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#131: FILE: app/test-pmd/testpmd.c:3232:
+ RTE_SET_USED(num_slaves);
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#140: FILE: app/test-pmd/testpmd.c:3241:
+ portid_t slave_pids[RTE_MAX_ETHPORTS];
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#141: FILE: app/test-pmd/testpmd.c:3242:
+ int num_slaves = 0;
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#151: FILE: app/test-pmd/testpmd.c:3279:
+ num_slaves = rte_eth_bond_slaves_get(pi,
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#151: FILE: app/test-pmd/testpmd.c:3279:
+ num_slaves = rte_eth_bond_slaves_get(pi,
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#152: FILE: app/test-pmd/testpmd.c:3280:
+ slave_pids, RTE_MAX_ETHPORTS);
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#156: FILE: app/test-pmd/testpmd.c:3284:
+ * If this port is bonded device, all slaves under the
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#156: FILE: app/test-pmd/testpmd.c:3284:
+ /*
+ * If this port is bonded device, all slaves under the
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#159: FILE: app/test-pmd/testpmd.c:3287:
+ if (port->bond_flag == 1 && num_slaves > 0)
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#160: FILE: app/test-pmd/testpmd.c:3288:
+ clear_bonding_slave_device(slave_pids,
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#160: FILE: app/test-pmd/testpmd.c:3288:
+ clear_bonding_slave_device(slave_pids,
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#161: FILE: app/test-pmd/testpmd.c:3289:
+ num_slaves);
total: 0 errors, 30 warnings, 85 lines checked
next parent reply other threads:[~2022-06-07 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220607081038.23859-1-liudongdong3@huawei.com>
2022-06-07 8:11 ` checkpatch [this message]
2022-06-07 9:19 ` |SUCCESS| " 0-day Robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607081130.97A36120945@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=liudongdong3@huawei.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).