From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BF022A0032
	for <public@inbox.dpdk.org>; Fri, 24 Jun 2022 04:57:26 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BB9C340A8A;
	Fri, 24 Jun 2022 04:57:26 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 1A5FB40A87
 for <test-report@dpdk.org>; Fri, 24 Jun 2022 04:57:25 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 161D712083E; Fri, 24 Jun 2022 04:57:25 +0200 (CEST)
Subject: |WARNING| pw113367 [PATCH v3 05/12] net/nfp: add flower PF setup and
 mempool init logic
In-Reply-To: <1656039241-20955-6-git-send-email-chaoyong.he@corigine.com>
References: <1656039241-20955-6-git-send-email-chaoyong.he@corigine.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Chaoyong He <chaoyong.he@corigine.com>
Message-Id: <20220624025725.161D712083E@dpdk.org>
Date: Fri, 24 Jun 2022 04:57:25 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/113367

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#311: FILE: drivers/net/nfp/flower/nfp_flower.c:194:
+	PMD_INIT_LOG(DEBUG, "%s vNIC tx_bar_off: 0x%" PRIx64,

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'Y' - possible side-effects?
#622: FILE: drivers/net/nfp/flower/nfp_flower_ovs_compat.h:15:
+#define ROUND_UP(X, Y) (DIV_ROUND_UP(X, Y) * (Y))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'MEMBERS' - possible side-effects?
#627: FILE: drivers/net/nfp/flower/nfp_flower_ovs_compat.h:20:
+#define PADDED_MEMBERS_CACHELINE_MARKER(UNIT, CACHELINE, MEMBERS)   \
+	union {                                                         \
+		OVS_CACHE_LINE_MARKER CACHELINE;                            \
+		struct { MEMBERS };                                         \
+		uint8_t PAD_ID[ROUND_UP(sizeof(struct { MEMBERS }), UNIT)]; \
+	}

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'MEMBERS' - possible side-effects?
#634: FILE: drivers/net/nfp/flower/nfp_flower_ovs_compat.h:27:
+#define PADDED_MEMBERS_CACHELINE_MARKER(UNIT, CACHELINE, MEMBERS)           \
+	struct struct_##CACHELINE { MEMBERS };                                  \
+	union {                                                                 \
+		OVS_CACHE_LINE_MARKER CACHELINE;                                    \
+		struct { MEMBERS };                                                 \
+		uint8_t PAD_ID[ROUND_UP(sizeof(struct struct_##CACHELINE), UNIT)];  \
+	}

total: 0 errors, 0 warnings, 4 checks, 590 lines checked