From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: longli@linuxonhyperv.com
Subject: |WARNING| pw113616 [PATCH 13/17] net/mana: add function to start/stop RX queues
Date: Fri, 1 Jul 2022 11:05:44 +0200 (CEST) [thread overview]
Message-ID: <20220701090544.CB275120787@dpdk.org> (raw)
In-Reply-To: <1656666167-26035-14-git-send-email-longli@linuxonhyperv.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/113616
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#55:
MANA allocates device queues through the IB layer when starting RX queues. When
WARNING:TYPO_SPELLING: 'destory' may be misspelled - perhaps 'destroy'?
#264: FILE: drivers/net/mana/rx.c:154:
+ DRV_LOG(ERR, "rx_queue destory_qp failed %d", ret);
WARNING:VSPRINTF_SPECIFIER_PX: Using vsprintf specifier '%px' potentially exposes the kernel memory layout, if you don't really need the address please consider using '%p'.
#452: FILE: drivers/net/mana/rx.c:342:
+ DRV_LOG(INFO, "rxq cq id %u buf %px count %u size %u",
+ rxq->gdma_cq.id, rxq->gdma_cq.buffer,
+ rxq->gdma_cq.count, rxq->gdma_cq.size);
WARNING:VSPRINTF_SPECIFIER_PX: Using vsprintf specifier '%px' potentially exposes the kernel memory layout, if you don't really need the address please consider using '%p'.
#463: FILE: drivers/net/mana/rx.c:353:
+ DRV_LOG(INFO, "rxq rq id %u buf %px count %u size %u",
+ rxq->gdma_rq.id, rxq->gdma_rq.buffer,
+ rxq->gdma_rq.count, rxq->gdma_rq.size);
total: 0 errors, 4 warnings, 0 checks, 397 lines checked
Warning in drivers/net/mana/rx.c:
Declaring a variable inside for()
parent reply other threads:[~2022-07-01 9:05 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1656666167-26035-14-git-send-email-longli@linuxonhyperv.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701090544.CB275120787@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=longli@linuxonhyperv.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).