From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 02E3CA00C3
	for <public@inbox.dpdk.org>; Fri,  1 Jul 2022 11:05:46 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id F343140E03;
	Fri,  1 Jul 2022 11:05:45 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id CE8BB40A7B
 for <test-report@dpdk.org>; Fri,  1 Jul 2022 11:05:44 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id CB275120787; Fri,  1 Jul 2022 11:05:44 +0200 (CEST)
Subject: |WARNING| pw113616 [PATCH 13/17] net/mana: add function to start/stop
 RX queues
In-Reply-To: <1656666167-26035-14-git-send-email-longli@linuxonhyperv.com>
References: <1656666167-26035-14-git-send-email-longli@linuxonhyperv.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: longli@linuxonhyperv.com
Message-Id: <20220701090544.CB275120787@dpdk.org>
Date: Fri,  1 Jul 2022 11:05:44 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/113616

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#55: 
MANA allocates device queues through the IB layer when starting RX queues. When

WARNING:TYPO_SPELLING: 'destory' may be misspelled - perhaps 'destroy'?
#264: FILE: drivers/net/mana/rx.c:154:
+			DRV_LOG(ERR, "rx_queue destory_qp failed %d", ret);

WARNING:VSPRINTF_SPECIFIER_PX: Using vsprintf specifier '%px' potentially exposes the kernel memory layout, if you don't really need the address please consider using '%p'.
#452: FILE: drivers/net/mana/rx.c:342:
+		DRV_LOG(INFO, "rxq cq id %u buf %px count %u size %u",
+			rxq->gdma_cq.id, rxq->gdma_cq.buffer,
+			rxq->gdma_cq.count, rxq->gdma_cq.size);

WARNING:VSPRINTF_SPECIFIER_PX: Using vsprintf specifier '%px' potentially exposes the kernel memory layout, if you don't really need the address please consider using '%p'.
#463: FILE: drivers/net/mana/rx.c:353:
+		DRV_LOG(INFO, "rxq rq id %u buf %px count %u size %u",
+			rxq->gdma_rq.id, rxq->gdma_rq.buffer,
+			rxq->gdma_rq.count, rxq->gdma_rq.size);

total: 0 errors, 4 warnings, 0 checks, 397 lines checked
Warning in drivers/net/mana/rx.c:
Declaring a variable inside for()