From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 860DDA0544
	for <public@inbox.dpdk.org>; Wed,  6 Jul 2022 02:30:08 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6F4CB4284D;
	Wed,  6 Jul 2022 02:30:08 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id E62074113F
 for <test-report@dpdk.org>; Wed,  6 Jul 2022 02:30:06 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id CDE58120D82; Wed,  6 Jul 2022 02:30:06 +0200 (CEST)
Subject: |WARNING| pw113684 [Patch v2 01/17] net/mana: add basic driver,
 build environment and doc
In-Reply-To: <1657067328-18374-2-git-send-email-longli@linuxonhyperv.com>
References: <1657067328-18374-2-git-send-email-longli@linuxonhyperv.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: longli@linuxonhyperv.com
Message-Id: <20220706003006.CDE58120D82@dpdk.org>
Date: Wed,  6 Jul 2022 02:30:06 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/113684

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#56: 
MANA is a PCI device. It uses IB verbs to access hardware through the kernel

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects?
#246: FILE: drivers/net/mana/mana.c:33:
+#define MKSTR(name, ...) \
+	int mkstr_size_##name = snprintf(NULL, 0, "" __VA_ARGS__); \
+	char name[mkstr_size_##name + 1]; \
+	\
+	memset(name, 0, mkstr_size_##name + 1); \
+	snprintf(name, sizeof(name), "" __VA_ARGS__)

WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#280: FILE: drivers/net/mana/mana.c:67:
+static const char *mana_init_args[] = {

CHECK:CAMELCASE: Avoid CamelCase: <SCNx32>
#424: FILE: drivers/net/mana/mana.c:211:
+			   "%" SCNx32 ":%" SCNx8 ":%" SCNx8 ".%" SCNx8 "
",

CHECK:CAMELCASE: Avoid CamelCase: <SCNx8>
#424: FILE: drivers/net/mana/mana.c:211:
+			   "%" SCNx32 ":%" SCNx8 ":%" SCNx8 ".%" SCNx8 "
",

total: 0 errors, 2 warnings, 3 checks, 1288 lines checked