From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 326A1A0543 for ; Thu, 7 Jul 2022 22:31:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B8A24282F; Thu, 7 Jul 2022 22:31:28 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 94BF74280E for ; Thu, 7 Jul 2022 22:31:26 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 91560120D82; Thu, 7 Jul 2022 22:31:26 +0200 (CEST) Subject: |WARNING| pw113795 [Patch v3 01/17] net/mana: add basic driver, build environment and doc In-Reply-To: <1657225822-3512-2-git-send-email-longli@linuxonhyperv.com> References: <1657225822-3512-2-git-send-email-longli@linuxonhyperv.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: longli@linuxonhyperv.com Message-Id: <20220707203126.91560120D82@dpdk.org> Date: Thu, 7 Jul 2022 22:31:26 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/113795 _coding style issues_ WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #56: MANA is a PCI device. It uses IB verbs to access hardware through the kernel CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects? #246: FILE: drivers/net/mana/mana.c:33: +#define MKSTR(name, ...) \ + int mkstr_size_##name = snprintf(NULL, 0, "" __VA_ARGS__); \ + char name[mkstr_size_##name + 1]; \ + \ + memset(name, 0, mkstr_size_##name + 1); \ + snprintf(name, sizeof(name), "" __VA_ARGS__) WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const #280: FILE: drivers/net/mana/mana.c:67: +static const char *mana_init_args[] = { CHECK:CAMELCASE: Avoid CamelCase: #424: FILE: drivers/net/mana/mana.c:211: + "%" SCNx32 ":%" SCNx8 ":%" SCNx8 ".%" SCNx8 " ", CHECK:CAMELCASE: Avoid CamelCase: #424: FILE: drivers/net/mana/mana.c:211: + "%" SCNx32 ":%" SCNx8 ":%" SCNx8 ".%" SCNx8 " ", total: 0 errors, 2 warnings, 3 checks, 1298 lines checked