* |WARNING| pw113839 [Patch v4 01/17] net/mana: add basic driver, build environment and doc
[not found] <1657324171-31369-2-git-send-email-longli@linuxonhyperv.com>
@ 2022-07-08 23:50 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2022-07-08 23:50 UTC (permalink / raw)
To: test-report; +Cc: longli
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/113839
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects?
#249: FILE: drivers/net/mana/mana.c:33:
+#define MKSTR(name, ...) \
+ int mkstr_size_##name = snprintf(NULL, 0, "" __VA_ARGS__); \
+ char name[mkstr_size_##name + 1]; \
+ \
+ memset(name, 0, mkstr_size_##name + 1); \
+ snprintf(name, sizeof(name), "" __VA_ARGS__)
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#283: FILE: drivers/net/mana/mana.c:67:
+static const char *mana_init_args[] = {
CHECK:CAMELCASE: Avoid CamelCase: <SCNx32>
#427: FILE: drivers/net/mana/mana.c:211:
+ "%" SCNx32 ":%" SCNx8 ":%" SCNx8 ".%" SCNx8 "
",
CHECK:CAMELCASE: Avoid CamelCase: <SCNx8>
#427: FILE: drivers/net/mana/mana.c:211:
+ "%" SCNx32 ":%" SCNx8 ":%" SCNx8 ".%" SCNx8 "
",
total: 0 errors, 1 warnings, 3 checks, 1298 lines checked
^ permalink raw reply [flat|nested] only message in thread