From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EDF1A0032 for ; Mon, 11 Jul 2022 18:25:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B11340DF6; Mon, 11 Jul 2022 18:25:01 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 0B2A240C35 for ; Mon, 11 Jul 2022 18:25:00 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 037F6120D82; Mon, 11 Jul 2022 18:24:59 +0200 (CEST) Subject: |WARNING| pw113913 [PATCH v1 1/4] power: add uncore api to power library In-Reply-To: <20220711162300.3308684-2-tadhg.kearney@intel.com> References: <20220711162300.3308684-2-tadhg.kearney@intel.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: tadhgkearney Message-Id: <20220711162500.037F6120D82@dpdk.org> Date: Mon, 11 Jul 2022 18:24:59 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/113913 _coding style issues_ WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #65: Add api to allow uncore frequency adjustment. This is done through manipulating related sysfs entries to adjust the min/max uncore values. ERROR:TRAILING_WHITESPACE: trailing whitespace #92: FILE: doc/guides/prog_guide/power_man.rst:284: +Up to 60% power saving can be achieved by reducing the uncore frequency to its lowest value. $ ERROR:TRAILING_WHITESPACE: trailing whitespace #93: FILE: doc/guides/prog_guide/power_man.rst:285: +With later kernels, there is now a sysfs entry to allow adjustment of uncore frequency. $ ERROR:TRAILING_WHITESPACE: trailing whitespace #99: FILE: doc/guides/prog_guide/power_man.rst:291: +* **Uncore Power Init**: Initialise uncore power, populate frequency array and record $ ERROR:CODE_INDENT: code indent should use tabs where possible #157: FILE: lib/power/rte_power_uncore.c:16: + "/sys/devices/system/cpu/intel_uncore_frequency/package_%02u_die_%02u/max_freq_khz"$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #157: FILE: lib/power/rte_power_uncore.c:16: + "/sys/devices/system/cpu/intel_uncore_frequency/package_%02u_die_%02u/max_freq_khz"$ ERROR:CODE_INDENT: code indent should use tabs where possible #159: FILE: lib/power/rte_power_uncore.c:18: + "/sys/devices/system/cpu/intel_uncore_frequency/package_%02u_die_%02u/min_freq_khz"$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #159: FILE: lib/power/rte_power_uncore.c:18: + "/sys/devices/system/cpu/intel_uncore_frequency/package_%02u_die_%02u/min_freq_khz"$ ERROR:CODE_INDENT: code indent should use tabs where possible #161: FILE: lib/power/rte_power_uncore.c:20: + "/sys/devices/system/cpu/intel_uncore_frequency/package_%02u_die_%02u/initial_max_freq_khz"$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #161: FILE: lib/power/rte_power_uncore.c:20: + "/sys/devices/system/cpu/intel_uncore_frequency/package_%02u_die_%02u/initial_max_freq_khz"$ ERROR:CODE_INDENT: code indent should use tabs where possible #163: FILE: lib/power/rte_power_uncore.c:22: + "/sys/devices/system/cpu/intel_uncore_frequency/package_%02u_die_%02u/initial_min_freq_khz"$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #163: FILE: lib/power/rte_power_uncore.c:22: + "/sys/devices/system/cpu/intel_uncore_frequency/package_%02u_die_%02u/initial_min_freq_khz"$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #167: FILE: lib/power/rte_power_uncore.c:26: + unsigned int die; /**< Core die id */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #168: FILE: lib/power/rte_power_uncore.c:27: + unsigned int pkg; /**< Package id */$ ERROR:TRAILING_WHITESPACE: trailing whitespace #169: FILE: lib/power/rte_power_uncore.c:28: + uint32_t freqs[RTE_MAX_UNCORE_FREQS];/**< Frequency array */ $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #169: FILE: lib/power/rte_power_uncore.c:28: + uint32_t freqs[RTE_MAX_UNCORE_FREQS];/**< Frequency array */ $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #170: FILE: lib/power/rte_power_uncore.c:29: + uint32_t nb_freqs; /**< Number of available freqs */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #171: FILE: lib/power/rte_power_uncore.c:30: + FILE *f_cur_min; /**< FD of scaling_min */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #172: FILE: lib/power/rte_power_uncore.c:31: + FILE *f_cur_max; /**< FD of scaling_max */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #173: FILE: lib/power/rte_power_uncore.c:32: + FILE *f_base_min; /**< FD of initial min */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #174: FILE: lib/power/rte_power_uncore.c:33: + FILE *f_base_max; /**< FD of initial max */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #175: FILE: lib/power/rte_power_uncore.c:34: + int cur_idx; /**< Freq index in freqs array */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #176: FILE: lib/power/rte_power_uncore.c:35: + uint32_t init_max_freq; /**< Initial max frequency */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #177: FILE: lib/power/rte_power_uncore.c:36: + uint32_t init_min_freq; /**< Initial min frequency */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #186: FILE: lib/power/rte_power_uncore.c:45: + uint32_t target_uncore_freq, curr_max_freq;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #187: FILE: lib/power/rte_power_uncore.c:46: + int ret;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #189: FILE: lib/power/rte_power_uncore.c:48: + if (idx >= RTE_MAX_UNCORE_FREQS || idx >= ui->nb_freqs) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #190: FILE: lib/power/rte_power_uncore.c:49: + RTE_LOG(ERR, POWER, "Invalid uncore frequency index %u, which "$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #190: FILE: lib/power/rte_power_uncore.c:49: + RTE_LOG(ERR, POWER, "Invalid uncore frequency index %u, which "$ ERROR:CODE_INDENT: code indent should use tabs where possible #191: FILE: lib/power/rte_power_uncore.c:50: + "should be less than %u ", idx, ui->nb_freqs);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #191: FILE: lib/power/rte_power_uncore.c:50: + "should be less than %u ", idx, ui->nb_freqs);$ ERROR:CODE_INDENT: code indent should use tabs where possible #192: FILE: lib/power/rte_power_uncore.c:51: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #192: FILE: lib/power/rte_power_uncore.c:51: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #193: FILE: lib/power/rte_power_uncore.c:52: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #195: FILE: lib/power/rte_power_uncore.c:54: + target_uncore_freq = ui->freqs[idx];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #197: FILE: lib/power/rte_power_uncore.c:56: + if (fprintf(ui->f_cur_min, "%u", target_uncore_freq) < 0) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #198: FILE: lib/power/rte_power_uncore.c:57: + RTE_LOG(ERR, POWER, "Fail to write new uncore frequency for "$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #198: FILE: lib/power/rte_power_uncore.c:57: + RTE_LOG(ERR, POWER, "Fail to write new uncore frequency for "$ ERROR:CODE_INDENT: code indent should use tabs where possible #199: FILE: lib/power/rte_power_uncore.c:58: + "pkg %02u die %02u ", ui->pkg, ui->die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #199: FILE: lib/power/rte_power_uncore.c:58: + "pkg %02u die %02u ", ui->pkg, ui->die);$ ERROR:CODE_INDENT: code indent should use tabs where possible #200: FILE: lib/power/rte_power_uncore.c:59: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #200: FILE: lib/power/rte_power_uncore.c:59: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #201: FILE: lib/power/rte_power_uncore.c:60: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #203: FILE: lib/power/rte_power_uncore.c:62: + if (fprintf(ui->f_cur_max, "%u", target_uncore_freq) < 0) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #204: FILE: lib/power/rte_power_uncore.c:63: + RTE_LOG(ERR, POWER, "Fail to write new uncore frequency for "$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #204: FILE: lib/power/rte_power_uncore.c:63: + RTE_LOG(ERR, POWER, "Fail to write new uncore frequency for "$ ERROR:CODE_INDENT: code indent should use tabs where possible #205: FILE: lib/power/rte_power_uncore.c:64: + "pkg %02u die %02u ", ui->pkg, ui->die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #205: FILE: lib/power/rte_power_uncore.c:64: + "pkg %02u die %02u ", ui->pkg, ui->die);$ ERROR:CODE_INDENT: code indent should use tabs where possible #206: FILE: lib/power/rte_power_uncore.c:65: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #206: FILE: lib/power/rte_power_uncore.c:65: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #207: FILE: lib/power/rte_power_uncore.c:66: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #209: FILE: lib/power/rte_power_uncore.c:68: + POWER_DEBUG_TRACE("Uncore requency '%u' to be set for pkg %02u die %02u ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #210: FILE: lib/power/rte_power_uncore.c:69: + target_uncore_freq, ui->pkg, ui->die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #210: FILE: lib/power/rte_power_uncore.c:69: + target_uncore_freq, ui->pkg, ui->die);$ ERROR:TRAILING_WHITESPACE: trailing whitespace #211: FILE: lib/power/rte_power_uncore.c:70: + $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #211: FILE: lib/power/rte_power_uncore.c:70: + $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #212: FILE: lib/power/rte_power_uncore.c:71: + open_core_sysfs_file(&ui->f_cur_max, "rw+", POWER_UNCORE_SYSFILE_MAX_FREQ,$ ERROR:CODE_INDENT: code indent should use tabs where possible #213: FILE: lib/power/rte_power_uncore.c:72: + ui->pkg, ui->die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #213: FILE: lib/power/rte_power_uncore.c:72: + ui->pkg, ui->die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #214: FILE: lib/power/rte_power_uncore.c:73: + if (ui->f_cur_max == NULL) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #215: FILE: lib/power/rte_power_uncore.c:74: + RTE_LOG(DEBUG, POWER, "failed to open %s ",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #215: FILE: lib/power/rte_power_uncore.c:74: + RTE_LOG(DEBUG, POWER, "failed to open %s ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #216: FILE: lib/power/rte_power_uncore.c:75: + POWER_UNCORE_SYSFILE_MAX_FREQ);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #216: FILE: lib/power/rte_power_uncore.c:75: + POWER_UNCORE_SYSFILE_MAX_FREQ);$ ERROR:CODE_INDENT: code indent should use tabs where possible #217: FILE: lib/power/rte_power_uncore.c:76: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #217: FILE: lib/power/rte_power_uncore.c:76: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #218: FILE: lib/power/rte_power_uncore.c:77: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #219: FILE: lib/power/rte_power_uncore.c:78: + ret = read_core_sysfs_u32(ui->f_cur_max, &curr_max_freq);$ ERROR:CODE_INDENT: code indent should use tabs where possible #220: FILE: lib/power/rte_power_uncore.c:79: + if (ret < 0) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #220: FILE: lib/power/rte_power_uncore.c:79: + if (ret < 0) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #220: FILE: lib/power/rte_power_uncore.c:79: + if (ret < 0) { + RTE_LOG(DEBUG, POWER, "Failed to read %s ", ERROR:CODE_INDENT: code indent should use tabs where possible #221: FILE: lib/power/rte_power_uncore.c:80: + RTE_LOG(DEBUG, POWER, "Failed to read %s ",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #221: FILE: lib/power/rte_power_uncore.c:80: + RTE_LOG(DEBUG, POWER, "Failed to read %s ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #222: FILE: lib/power/rte_power_uncore.c:81: + POWER_UNCORE_SYSFILE_MAX_FREQ);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #222: FILE: lib/power/rte_power_uncore.c:81: + POWER_UNCORE_SYSFILE_MAX_FREQ);$ ERROR:CODE_INDENT: code indent should use tabs where possible #223: FILE: lib/power/rte_power_uncore.c:82: + fclose(ui->f_cur_max);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #223: FILE: lib/power/rte_power_uncore.c:82: + fclose(ui->f_cur_max);$ ERROR:CODE_INDENT: code indent should use tabs where possible #224: FILE: lib/power/rte_power_uncore.c:83: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #224: FILE: lib/power/rte_power_uncore.c:83: + return -1;$ ERROR:CODE_INDENT: code indent should use tabs where possible #225: FILE: lib/power/rte_power_uncore.c:84: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #225: FILE: lib/power/rte_power_uncore.c:84: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #227: FILE: lib/power/rte_power_uncore.c:86: + if (target_uncore_freq <= curr_max_freq){$ ERROR:SPACING: space required before the open brace '{' #227: FILE: lib/power/rte_power_uncore.c:86: + if (target_uncore_freq <= curr_max_freq){ ERROR:CODE_INDENT: code indent should use tabs where possible #228: FILE: lib/power/rte_power_uncore.c:87: + fflush(ui->f_cur_min);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #228: FILE: lib/power/rte_power_uncore.c:87: + fflush(ui->f_cur_min);$ ERROR:CODE_INDENT: code indent should use tabs where possible #229: FILE: lib/power/rte_power_uncore.c:88: + fflush(ui->f_cur_max);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #229: FILE: lib/power/rte_power_uncore.c:88: + fflush(ui->f_cur_max);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #230: FILE: lib/power/rte_power_uncore.c:89: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #231: FILE: lib/power/rte_power_uncore.c:90: + else {$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #231: FILE: lib/power/rte_power_uncore.c:90: + } + else { ERROR:CODE_INDENT: code indent should use tabs where possible #232: FILE: lib/power/rte_power_uncore.c:91: + fflush(ui->f_cur_max);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #232: FILE: lib/power/rte_power_uncore.c:91: + fflush(ui->f_cur_max);$ ERROR:CODE_INDENT: code indent should use tabs where possible #233: FILE: lib/power/rte_power_uncore.c:92: + fflush(ui->f_cur_min);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #233: FILE: lib/power/rte_power_uncore.c:92: + fflush(ui->f_cur_min);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #234: FILE: lib/power/rte_power_uncore.c:93: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #236: FILE: lib/power/rte_power_uncore.c:95: + ui->cur_idx = idx;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #238: FILE: lib/power/rte_power_uncore.c:97: + return 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #247: FILE: lib/power/rte_power_uncore.c:106: + FILE *f_base_min = NULL, *f_base_max = NULL, *f_min = NULL, *f_max = NULL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #248: FILE: lib/power/rte_power_uncore.c:107: + uint32_t base_min_freq, base_max_freq, min_freq, max_freq;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #249: FILE: lib/power/rte_power_uncore.c:108: + int ret;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #253: FILE: lib/power/rte_power_uncore.c:112: + open_core_sysfs_file(&f_base_max, "r", POWER_UNCORE_SYSFILE_BASE_MAX_FREQ,$ ERROR:CODE_INDENT: code indent should use tabs where possible #254: FILE: lib/power/rte_power_uncore.c:113: + ui->pkg, ui->die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #254: FILE: lib/power/rte_power_uncore.c:113: + ui->pkg, ui->die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #255: FILE: lib/power/rte_power_uncore.c:114: + if (f_base_max == NULL) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #256: FILE: lib/power/rte_power_uncore.c:115: + RTE_LOG(DEBUG, POWER, "failed to open %s ",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #256: FILE: lib/power/rte_power_uncore.c:115: + RTE_LOG(DEBUG, POWER, "failed to open %s ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #257: FILE: lib/power/rte_power_uncore.c:116: + POWER_UNCORE_SYSFILE_BASE_MAX_FREQ);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #257: FILE: lib/power/rte_power_uncore.c:116: + POWER_UNCORE_SYSFILE_BASE_MAX_FREQ);$ ERROR:CODE_INDENT: code indent should use tabs where possible #258: FILE: lib/power/rte_power_uncore.c:117: + goto err;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #258: FILE: lib/power/rte_power_uncore.c:117: + goto err;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #259: FILE: lib/power/rte_power_uncore.c:118: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #260: FILE: lib/power/rte_power_uncore.c:119: + ret = read_core_sysfs_u32(f_base_max, &base_max_freq);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #261: FILE: lib/power/rte_power_uncore.c:120: + if (ret < 0) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #262: FILE: lib/power/rte_power_uncore.c:121: + RTE_LOG(DEBUG, POWER, "Failed to read %s ",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #262: FILE: lib/power/rte_power_uncore.c:121: + RTE_LOG(DEBUG, POWER, "Failed to read %s ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #263: FILE: lib/power/rte_power_uncore.c:122: + POWER_UNCORE_SYSFILE_BASE_MAX_FREQ);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #263: FILE: lib/power/rte_power_uncore.c:122: + POWER_UNCORE_SYSFILE_BASE_MAX_FREQ);$ ERROR:CODE_INDENT: code indent should use tabs where possible #264: FILE: lib/power/rte_power_uncore.c:123: + goto err;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #264: FILE: lib/power/rte_power_uncore.c:123: + goto err;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #265: FILE: lib/power/rte_power_uncore.c:124: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #268: FILE: lib/power/rte_power_uncore.c:127: + open_core_sysfs_file(&f_base_min, "r", POWER_UNCORE_SYSFILE_BASE_MIN_FREQ,$ ERROR:CODE_INDENT: code indent should use tabs where possible #269: FILE: lib/power/rte_power_uncore.c:128: + ui->pkg, ui->die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #269: FILE: lib/power/rte_power_uncore.c:128: + ui->pkg, ui->die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #270: FILE: lib/power/rte_power_uncore.c:129: + if (f_base_min == NULL) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #271: FILE: lib/power/rte_power_uncore.c:130: + RTE_LOG(DEBUG, POWER, "failed to open %s ",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #271: FILE: lib/power/rte_power_uncore.c:130: + RTE_LOG(DEBUG, POWER, "failed to open %s ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #272: FILE: lib/power/rte_power_uncore.c:131: + POWER_UNCORE_SYSFILE_BASE_MIN_FREQ);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #272: FILE: lib/power/rte_power_uncore.c:131: + POWER_UNCORE_SYSFILE_BASE_MIN_FREQ);$ ERROR:CODE_INDENT: code indent should use tabs where possible #273: FILE: lib/power/rte_power_uncore.c:132: + goto err;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #273: FILE: lib/power/rte_power_uncore.c:132: + goto err;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #274: FILE: lib/power/rte_power_uncore.c:133: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #275: FILE: lib/power/rte_power_uncore.c:134: + if (f_base_min != NULL) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #276: FILE: lib/power/rte_power_uncore.c:135: + ret = read_core_sysfs_u32(f_base_min, &base_min_freq);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #276: FILE: lib/power/rte_power_uncore.c:135: + ret = read_core_sysfs_u32(f_base_min, &base_min_freq);$ ERROR:CODE_INDENT: code indent should use tabs where possible #277: FILE: lib/power/rte_power_uncore.c:136: + if (ret < 0) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #277: FILE: lib/power/rte_power_uncore.c:136: + if (ret < 0) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #277: FILE: lib/power/rte_power_uncore.c:136: + if (ret < 0) { + RTE_LOG(DEBUG, POWER, "Failed to read %s ", ERROR:CODE_INDENT: code indent should use tabs where possible #278: FILE: lib/power/rte_power_uncore.c:137: + RTE_LOG(DEBUG, POWER, "Failed to read %s ",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #278: FILE: lib/power/rte_power_uncore.c:137: + RTE_LOG(DEBUG, POWER, "Failed to read %s ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #279: FILE: lib/power/rte_power_uncore.c:138: + POWER_UNCORE_SYSFILE_BASE_MIN_FREQ);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #279: FILE: lib/power/rte_power_uncore.c:138: + POWER_UNCORE_SYSFILE_BASE_MIN_FREQ);$ ERROR:CODE_INDENT: code indent should use tabs where possible #280: FILE: lib/power/rte_power_uncore.c:139: + goto err;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #280: FILE: lib/power/rte_power_uncore.c:139: + goto err;$ ERROR:CODE_INDENT: code indent should use tabs where possible #281: FILE: lib/power/rte_power_uncore.c:140: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #281: FILE: lib/power/rte_power_uncore.c:140: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #282: FILE: lib/power/rte_power_uncore.c:141: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #285: FILE: lib/power/rte_power_uncore.c:144: + open_core_sysfs_file(&f_min, "rw+", POWER_UNCORE_SYSFILE_MIN_FREQ,$ ERROR:CODE_INDENT: code indent should use tabs where possible #286: FILE: lib/power/rte_power_uncore.c:145: + ui->pkg, ui->die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #286: FILE: lib/power/rte_power_uncore.c:145: + ui->pkg, ui->die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #287: FILE: lib/power/rte_power_uncore.c:146: + if (f_min == NULL) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #288: FILE: lib/power/rte_power_uncore.c:147: + RTE_LOG(DEBUG, POWER, "failed to open %s ",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #288: FILE: lib/power/rte_power_uncore.c:147: + RTE_LOG(DEBUG, POWER, "failed to open %s ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #289: FILE: lib/power/rte_power_uncore.c:148: + POWER_UNCORE_SYSFILE_MIN_FREQ);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #289: FILE: lib/power/rte_power_uncore.c:148: + POWER_UNCORE_SYSFILE_MIN_FREQ);$ ERROR:CODE_INDENT: code indent should use tabs where possible #290: FILE: lib/power/rte_power_uncore.c:149: + goto err;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #290: FILE: lib/power/rte_power_uncore.c:149: + goto err;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #291: FILE: lib/power/rte_power_uncore.c:150: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #292: FILE: lib/power/rte_power_uncore.c:151: + if (f_min != NULL) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #293: FILE: lib/power/rte_power_uncore.c:152: + ret = read_core_sysfs_u32(f_min, &min_freq);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #293: FILE: lib/power/rte_power_uncore.c:152: + ret = read_core_sysfs_u32(f_min, &min_freq);$ ERROR:CODE_INDENT: code indent should use tabs where possible #294: FILE: lib/power/rte_power_uncore.c:153: + if (ret < 0) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #294: FILE: lib/power/rte_power_uncore.c:153: + if (ret < 0) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #294: FILE: lib/power/rte_power_uncore.c:153: + if (ret < 0) { + RTE_LOG(DEBUG, POWER, "Failed to read %s ", ERROR:CODE_INDENT: code indent should use tabs where possible #295: FILE: lib/power/rte_power_uncore.c:154: + RTE_LOG(DEBUG, POWER, "Failed to read %s ",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #295: FILE: lib/power/rte_power_uncore.c:154: + RTE_LOG(DEBUG, POWER, "Failed to read %s ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #296: FILE: lib/power/rte_power_uncore.c:155: + POWER_UNCORE_SYSFILE_MIN_FREQ);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #296: FILE: lib/power/rte_power_uncore.c:155: + POWER_UNCORE_SYSFILE_MIN_FREQ);$ ERROR:CODE_INDENT: code indent should use tabs where possible #297: FILE: lib/power/rte_power_uncore.c:156: + goto err;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #297: FILE: lib/power/rte_power_uncore.c:156: + goto err;$ ERROR:CODE_INDENT: code indent should use tabs where possible #298: FILE: lib/power/rte_power_uncore.c:157: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #298: FILE: lib/power/rte_power_uncore.c:157: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #299: FILE: lib/power/rte_power_uncore.c:158: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #302: FILE: lib/power/rte_power_uncore.c:161: + open_core_sysfs_file(&f_max, "rw+", POWER_UNCORE_SYSFILE_MAX_FREQ,$ ERROR:CODE_INDENT: code indent should use tabs where possible #303: FILE: lib/power/rte_power_uncore.c:162: + ui->pkg, ui->die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #303: FILE: lib/power/rte_power_uncore.c:162: + ui->pkg, ui->die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #304: FILE: lib/power/rte_power_uncore.c:163: + if (f_max == NULL) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #305: FILE: lib/power/rte_power_uncore.c:164: + RTE_LOG(DEBUG, POWER, "failed to open %s ",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #305: FILE: lib/power/rte_power_uncore.c:164: + RTE_LOG(DEBUG, POWER, "failed to open %s ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #306: FILE: lib/power/rte_power_uncore.c:165: + POWER_UNCORE_SYSFILE_MAX_FREQ);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #306: FILE: lib/power/rte_power_uncore.c:165: + POWER_UNCORE_SYSFILE_MAX_FREQ);$ ERROR:CODE_INDENT: code indent should use tabs where possible #307: FILE: lib/power/rte_power_uncore.c:166: + goto err;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #307: FILE: lib/power/rte_power_uncore.c:166: + goto err;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #308: FILE: lib/power/rte_power_uncore.c:167: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #309: FILE: lib/power/rte_power_uncore.c:168: + if (f_max != NULL) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #310: FILE: lib/power/rte_power_uncore.c:169: + ret = read_core_sysfs_u32(f_max, &max_freq);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #310: FILE: lib/power/rte_power_uncore.c:169: + ret = read_core_sysfs_u32(f_max, &max_freq);$ ERROR:CODE_INDENT: code indent should use tabs where possible #311: FILE: lib/power/rte_power_uncore.c:170: + if (ret < 0) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #311: FILE: lib/power/rte_power_uncore.c:170: + if (ret < 0) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #311: FILE: lib/power/rte_power_uncore.c:170: + if (ret < 0) { + RTE_LOG(DEBUG, POWER, "Failed to read %s ", ERROR:CODE_INDENT: code indent should use tabs where possible #312: FILE: lib/power/rte_power_uncore.c:171: + RTE_LOG(DEBUG, POWER, "Failed to read %s ",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #312: FILE: lib/power/rte_power_uncore.c:171: + RTE_LOG(DEBUG, POWER, "Failed to read %s ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #313: FILE: lib/power/rte_power_uncore.c:172: + POWER_UNCORE_SYSFILE_MAX_FREQ);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #313: FILE: lib/power/rte_power_uncore.c:172: + POWER_UNCORE_SYSFILE_MAX_FREQ);$ ERROR:CODE_INDENT: code indent should use tabs where possible #314: FILE: lib/power/rte_power_uncore.c:173: + goto err;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #314: FILE: lib/power/rte_power_uncore.c:173: + goto err;$ ERROR:CODE_INDENT: code indent should use tabs where possible #315: FILE: lib/power/rte_power_uncore.c:174: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #315: FILE: lib/power/rte_power_uncore.c:174: + }$ ERROR:TRAILING_WHITESPACE: trailing whitespace #316: FILE: lib/power/rte_power_uncore.c:175: + }^I$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #316: FILE: lib/power/rte_power_uncore.c:175: + }^I$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #319: FILE: lib/power/rte_power_uncore.c:178: + ui->f_cur_min = f_min;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #320: FILE: lib/power/rte_power_uncore.c:179: + ui->f_cur_max = f_max;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #321: FILE: lib/power/rte_power_uncore.c:180: + ui->f_base_max = f_base_max;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #322: FILE: lib/power/rte_power_uncore.c:181: + ui->f_base_min = f_base_min;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #323: FILE: lib/power/rte_power_uncore.c:182: + ui->init_max_freq = base_max_freq;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #324: FILE: lib/power/rte_power_uncore.c:183: + ui->init_min_freq = base_min_freq;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #326: FILE: lib/power/rte_power_uncore.c:185: + return 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #329: FILE: lib/power/rte_power_uncore.c:188: + if (f_base_min != NULL)$ ERROR:CODE_INDENT: code indent should use tabs where possible #330: FILE: lib/power/rte_power_uncore.c:189: + fclose(f_base_min);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #330: FILE: lib/power/rte_power_uncore.c:189: + fclose(f_base_min);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #331: FILE: lib/power/rte_power_uncore.c:190: + if (f_base_max != NULL)$ ERROR:CODE_INDENT: code indent should use tabs where possible #332: FILE: lib/power/rte_power_uncore.c:191: + fclose(f_base_max);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #332: FILE: lib/power/rte_power_uncore.c:191: + fclose(f_base_max);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #333: FILE: lib/power/rte_power_uncore.c:192: + if (f_min != NULL)$ ERROR:CODE_INDENT: code indent should use tabs where possible #334: FILE: lib/power/rte_power_uncore.c:193: + fclose(f_min);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #334: FILE: lib/power/rte_power_uncore.c:193: + fclose(f_min);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #335: FILE: lib/power/rte_power_uncore.c:194: + if (f_max != NULL)$ ERROR:CODE_INDENT: code indent should use tabs where possible #336: FILE: lib/power/rte_power_uncore.c:195: + fclose(f_max);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #336: FILE: lib/power/rte_power_uncore.c:195: + fclose(f_max);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #337: FILE: lib/power/rte_power_uncore.c:196: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #347: FILE: lib/power/rte_power_uncore.c:206: + int ret = -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #348: FILE: lib/power/rte_power_uncore.c:207: + uint32_t i, num_uncore_freqs = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #350: FILE: lib/power/rte_power_uncore.c:209: + num_uncore_freqs = (ui->init_max_freq - ui->init_min_freq) / BUS_FREQ +1;$ ERROR:SPACING: need consistent spacing around '+' (ctx:WxV) #350: FILE: lib/power/rte_power_uncore.c:209: + num_uncore_freqs = (ui->init_max_freq - ui->init_min_freq) / BUS_FREQ +1; ^ WARNING:LEADING_SPACE: please, no spaces at the start of a line #351: FILE: lib/power/rte_power_uncore.c:210: + if (num_uncore_freqs >= RTE_MAX_UNCORE_FREQS) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #352: FILE: lib/power/rte_power_uncore.c:211: + RTE_LOG(ERR, POWER, "Too many available uncore frequencies: %d ",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #352: FILE: lib/power/rte_power_uncore.c:211: + RTE_LOG(ERR, POWER, "Too many available uncore frequencies: %d ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #353: FILE: lib/power/rte_power_uncore.c:212: + num_uncore_freqs);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #353: FILE: lib/power/rte_power_uncore.c:212: + num_uncore_freqs);$ ERROR:CODE_INDENT: code indent should use tabs where possible #354: FILE: lib/power/rte_power_uncore.c:213: + goto out;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #354: FILE: lib/power/rte_power_uncore.c:213: + goto out;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #355: FILE: lib/power/rte_power_uncore.c:214: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #358: FILE: lib/power/rte_power_uncore.c:217: + for (i = 0; i < num_uncore_freqs; i++) {$ WARNING:BRACES: braces {} are not necessary for single statement blocks #358: FILE: lib/power/rte_power_uncore.c:217: + for (i = 0; i < num_uncore_freqs; i++) { + ui->freqs[i] = ui->init_max_freq - (i) * BUS_FREQ; + } ERROR:CODE_INDENT: code indent should use tabs where possible #359: FILE: lib/power/rte_power_uncore.c:218: + ui->freqs[i] = ui->init_max_freq - (i) * BUS_FREQ;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #359: FILE: lib/power/rte_power_uncore.c:218: + ui->freqs[i] = ui->init_max_freq - (i) * BUS_FREQ;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #360: FILE: lib/power/rte_power_uncore.c:219: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #362: FILE: lib/power/rte_power_uncore.c:221: + ui->nb_freqs = num_uncore_freqs;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #364: FILE: lib/power/rte_power_uncore.c:223: + ret = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #366: FILE: lib/power/rte_power_uncore.c:225: + POWER_DEBUG_TRACE("%d uncore frequency(s) of pkg %02u die %02u are available ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #367: FILE: lib/power/rte_power_uncore.c:226: + num_uncore_freqs, ui->pkg, ui->die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #367: FILE: lib/power/rte_power_uncore.c:226: + num_uncore_freqs, ui->pkg, ui->die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #370: FILE: lib/power/rte_power_uncore.c:229: + return ret;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #377: FILE: lib/power/rte_power_uncore.c:236: + struct uncore_power_info *ui;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #380: FILE: lib/power/rte_power_uncore.c:239: + if (pkg >= RTE_MAX_NUMA_NODES) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #381: FILE: lib/power/rte_power_uncore.c:240: + RTE_LOG(DEBUG, POWER, "Package number %02u can not exceed %u ",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #381: FILE: lib/power/rte_power_uncore.c:240: + RTE_LOG(DEBUG, POWER, "Package number %02u can not exceed %u ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #382: FILE: lib/power/rte_power_uncore.c:241: + pkg, RTE_MAX_NUMA_NODES - 1U);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #382: FILE: lib/power/rte_power_uncore.c:241: + pkg, RTE_MAX_NUMA_NODES - 1U);$ ERROR:CODE_INDENT: code indent should use tabs where possible #383: FILE: lib/power/rte_power_uncore.c:242: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #383: FILE: lib/power/rte_power_uncore.c:242: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #384: FILE: lib/power/rte_power_uncore.c:243: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #386: FILE: lib/power/rte_power_uncore.c:245: + if (die >= RTE_MAX_NUMA_DIE) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #387: FILE: lib/power/rte_power_uncore.c:246: + RTE_LOG(DEBUG, POWER, "Die number %02u can not exceed %u ",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #387: FILE: lib/power/rte_power_uncore.c:246: + RTE_LOG(DEBUG, POWER, "Die number %02u can not exceed %u ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #388: FILE: lib/power/rte_power_uncore.c:247: + die, RTE_MAX_NUMA_DIE - 1U);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #388: FILE: lib/power/rte_power_uncore.c:247: + die, RTE_MAX_NUMA_DIE - 1U);$ ERROR:CODE_INDENT: code indent should use tabs where possible #389: FILE: lib/power/rte_power_uncore.c:248: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #389: FILE: lib/power/rte_power_uncore.c:248: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #390: FILE: lib/power/rte_power_uncore.c:249: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #392: FILE: lib/power/rte_power_uncore.c:251: + ui = &uncore_info[pkg][die];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #393: FILE: lib/power/rte_power_uncore.c:252: + ui->die = die;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #394: FILE: lib/power/rte_power_uncore.c:253: + ui->pkg = pkg;$ ERROR:TRAILING_WHITESPACE: trailing whitespace #395: FILE: lib/power/rte_power_uncore.c:254: + $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #395: FILE: lib/power/rte_power_uncore.c:254: + $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #397: FILE: lib/power/rte_power_uncore.c:256: + if (power_init_for_setting_uncore_freq(ui) < 0) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #398: FILE: lib/power/rte_power_uncore.c:257: + RTE_LOG(DEBUG, POWER, "Cannot init for setting uncore frequency for "$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #398: FILE: lib/power/rte_power_uncore.c:257: + RTE_LOG(DEBUG, POWER, "Cannot init for setting uncore frequency for "$ ERROR:CODE_INDENT: code indent should use tabs where possible #399: FILE: lib/power/rte_power_uncore.c:258: + "pkg %02u die %02u ", pkg, die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #399: FILE: lib/power/rte_power_uncore.c:258: + "pkg %02u die %02u ", pkg, die);$ ERROR:CODE_INDENT: code indent should use tabs where possible #400: FILE: lib/power/rte_power_uncore.c:259: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #400: FILE: lib/power/rte_power_uncore.c:259: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #401: FILE: lib/power/rte_power_uncore.c:260: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #404: FILE: lib/power/rte_power_uncore.c:263: + if (power_get_available_uncore_freqs(ui) < 0) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #405: FILE: lib/power/rte_power_uncore.c:264: + RTE_LOG(DEBUG, POWER, "Cannot get available uncore frequencies of "$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #405: FILE: lib/power/rte_power_uncore.c:264: + RTE_LOG(DEBUG, POWER, "Cannot get available uncore frequencies of "$ ERROR:CODE_INDENT: code indent should use tabs where possible #406: FILE: lib/power/rte_power_uncore.c:265: + "pkg %02u die %02u ", pkg, die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #406: FILE: lib/power/rte_power_uncore.c:265: + "pkg %02u die %02u ", pkg, die);$ ERROR:CODE_INDENT: code indent should use tabs where possible #407: FILE: lib/power/rte_power_uncore.c:266: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #407: FILE: lib/power/rte_power_uncore.c:266: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #408: FILE: lib/power/rte_power_uncore.c:267: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #410: FILE: lib/power/rte_power_uncore.c:269: + return 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #416: FILE: lib/power/rte_power_uncore.c:275: + struct uncore_power_info *ui;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #418: FILE: lib/power/rte_power_uncore.c:277: + if (pkg >= RTE_MAX_NUMA_NODES) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #419: FILE: lib/power/rte_power_uncore.c:278: + RTE_LOG(DEBUG, POWER, "Package number %02u can not exceed %u ",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #419: FILE: lib/power/rte_power_uncore.c:278: + RTE_LOG(DEBUG, POWER, "Package number %02u can not exceed %u ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #420: FILE: lib/power/rte_power_uncore.c:279: + pkg, RTE_MAX_NUMA_NODES - 1U);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #420: FILE: lib/power/rte_power_uncore.c:279: + pkg, RTE_MAX_NUMA_NODES - 1U);$ ERROR:CODE_INDENT: code indent should use tabs where possible #421: FILE: lib/power/rte_power_uncore.c:280: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #421: FILE: lib/power/rte_power_uncore.c:280: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #422: FILE: lib/power/rte_power_uncore.c:281: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #424: FILE: lib/power/rte_power_uncore.c:283: + if (die >= RTE_MAX_NUMA_DIE) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #425: FILE: lib/power/rte_power_uncore.c:284: + RTE_LOG(DEBUG, POWER, "Die number %02u can not exceed %u ",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #425: FILE: lib/power/rte_power_uncore.c:284: + RTE_LOG(DEBUG, POWER, "Die number %02u can not exceed %u ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #426: FILE: lib/power/rte_power_uncore.c:285: + die, RTE_MAX_NUMA_DIE - 1U);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #426: FILE: lib/power/rte_power_uncore.c:285: + die, RTE_MAX_NUMA_DIE - 1U);$ ERROR:CODE_INDENT: code indent should use tabs where possible #427: FILE: lib/power/rte_power_uncore.c:286: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #427: FILE: lib/power/rte_power_uncore.c:286: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #428: FILE: lib/power/rte_power_uncore.c:287: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #430: FILE: lib/power/rte_power_uncore.c:289: + ui = &uncore_info[pkg][die];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #433: FILE: lib/power/rte_power_uncore.c:292: + fclose(ui->f_cur_min);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #434: FILE: lib/power/rte_power_uncore.c:293: + fclose(ui->f_cur_max);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #435: FILE: lib/power/rte_power_uncore.c:294: + fclose(ui->f_base_max);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #436: FILE: lib/power/rte_power_uncore.c:295: + fclose(ui->f_base_min);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #437: FILE: lib/power/rte_power_uncore.c:296: + ui->f_cur_min = NULL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #438: FILE: lib/power/rte_power_uncore.c:297: + ui->f_cur_max = NULL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #439: FILE: lib/power/rte_power_uncore.c:298: + ui->f_base_min = NULL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #440: FILE: lib/power/rte_power_uncore.c:299: + ui->f_base_max = NULL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #442: FILE: lib/power/rte_power_uncore.c:301: + return 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #448: FILE: lib/power/rte_power_uncore.c:307: + if (pkg >= RTE_MAX_NUMA_NODES) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #449: FILE: lib/power/rte_power_uncore.c:308: + RTE_LOG(DEBUG, POWER, "Invalid package number ");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #449: FILE: lib/power/rte_power_uncore.c:308: + RTE_LOG(DEBUG, POWER, "Invalid package number ");$ ERROR:CODE_INDENT: code indent should use tabs where possible #450: FILE: lib/power/rte_power_uncore.c:309: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #450: FILE: lib/power/rte_power_uncore.c:309: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #451: FILE: lib/power/rte_power_uncore.c:310: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #453: FILE: lib/power/rte_power_uncore.c:312: + if (die >= RTE_MAX_NUMA_DIE) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #454: FILE: lib/power/rte_power_uncore.c:313: + RTE_LOG(DEBUG, POWER, "Invalid die number ");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #454: FILE: lib/power/rte_power_uncore.c:313: + RTE_LOG(DEBUG, POWER, "Invalid die number ");$ ERROR:CODE_INDENT: code indent should use tabs where possible #455: FILE: lib/power/rte_power_uncore.c:314: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #455: FILE: lib/power/rte_power_uncore.c:314: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #456: FILE: lib/power/rte_power_uncore.c:315: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #458: FILE: lib/power/rte_power_uncore.c:317: + return uncore_info[pkg][die].cur_idx;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #464: FILE: lib/power/rte_power_uncore.c:323: + if (pkg >= RTE_MAX_NUMA_NODES) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #465: FILE: lib/power/rte_power_uncore.c:324: + RTE_LOG(DEBUG, POWER, "Invalid package number ");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #465: FILE: lib/power/rte_power_uncore.c:324: + RTE_LOG(DEBUG, POWER, "Invalid package number ");$ ERROR:CODE_INDENT: code indent should use tabs where possible #466: FILE: lib/power/rte_power_uncore.c:325: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #466: FILE: lib/power/rte_power_uncore.c:325: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #467: FILE: lib/power/rte_power_uncore.c:326: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #469: FILE: lib/power/rte_power_uncore.c:328: + if (die >= RTE_MAX_NUMA_DIE) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #470: FILE: lib/power/rte_power_uncore.c:329: + RTE_LOG(DEBUG, POWER, "Invalid die number ");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #470: FILE: lib/power/rte_power_uncore.c:329: + RTE_LOG(DEBUG, POWER, "Invalid die number ");$ ERROR:CODE_INDENT: code indent should use tabs where possible #471: FILE: lib/power/rte_power_uncore.c:330: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #471: FILE: lib/power/rte_power_uncore.c:330: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #472: FILE: lib/power/rte_power_uncore.c:331: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #474: FILE: lib/power/rte_power_uncore.c:333: + return set_uncore_freq_internal(&(uncore_info[pkg][die]), index);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #480: FILE: lib/power/rte_power_uncore.c:339: + if (pkg >= RTE_MAX_NUMA_NODES) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #481: FILE: lib/power/rte_power_uncore.c:340: + RTE_LOG(DEBUG, POWER, "Invalid package number ");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #481: FILE: lib/power/rte_power_uncore.c:340: + RTE_LOG(DEBUG, POWER, "Invalid package number ");$ ERROR:CODE_INDENT: code indent should use tabs where possible #482: FILE: lib/power/rte_power_uncore.c:341: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #482: FILE: lib/power/rte_power_uncore.c:341: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #483: FILE: lib/power/rte_power_uncore.c:342: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #485: FILE: lib/power/rte_power_uncore.c:344: + if (die >= RTE_MAX_NUMA_DIE) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #486: FILE: lib/power/rte_power_uncore.c:345: + RTE_LOG(DEBUG, POWER, "Invalid die number ");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #486: FILE: lib/power/rte_power_uncore.c:345: + RTE_LOG(DEBUG, POWER, "Invalid die number ");$ ERROR:CODE_INDENT: code indent should use tabs where possible #487: FILE: lib/power/rte_power_uncore.c:346: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #487: FILE: lib/power/rte_power_uncore.c:346: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #488: FILE: lib/power/rte_power_uncore.c:347: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #490: FILE: lib/power/rte_power_uncore.c:349: + struct uncore_power_info *ui = &uncore_info[pkg][die];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #492: FILE: lib/power/rte_power_uncore.c:351: + if (fprintf(ui->f_cur_max, "%u", 0) < 0) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #493: FILE: lib/power/rte_power_uncore.c:352: + RTE_LOG(ERR, POWER, "Fail to write new uncore frequency for "$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #493: FILE: lib/power/rte_power_uncore.c:352: + RTE_LOG(ERR, POWER, "Fail to write new uncore frequency for "$ ERROR:CODE_INDENT: code indent should use tabs where possible #494: FILE: lib/power/rte_power_uncore.c:353: + "pkg %02u die %02u ", ui->pkg, ui->die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #494: FILE: lib/power/rte_power_uncore.c:353: + "pkg %02u die %02u ", ui->pkg, ui->die);$ ERROR:CODE_INDENT: code indent should use tabs where possible #495: FILE: lib/power/rte_power_uncore.c:354: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #495: FILE: lib/power/rte_power_uncore.c:354: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #496: FILE: lib/power/rte_power_uncore.c:355: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #498: FILE: lib/power/rte_power_uncore.c:357: + fflush(ui->f_cur_max);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #499: FILE: lib/power/rte_power_uncore.c:358: + return 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #506: FILE: lib/power/rte_power_uncore.c:365: + if (pkg >= RTE_MAX_NUMA_NODES) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #507: FILE: lib/power/rte_power_uncore.c:366: + RTE_LOG(DEBUG, POWER, "Invalid package number ");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #507: FILE: lib/power/rte_power_uncore.c:366: + RTE_LOG(DEBUG, POWER, "Invalid package number ");$ ERROR:CODE_INDENT: code indent should use tabs where possible #508: FILE: lib/power/rte_power_uncore.c:367: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #508: FILE: lib/power/rte_power_uncore.c:367: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #509: FILE: lib/power/rte_power_uncore.c:368: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #511: FILE: lib/power/rte_power_uncore.c:370: + if (die >= RTE_MAX_NUMA_DIE) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #512: FILE: lib/power/rte_power_uncore.c:371: + RTE_LOG(DEBUG, POWER, "Invalid die number ");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #512: FILE: lib/power/rte_power_uncore.c:371: + RTE_LOG(DEBUG, POWER, "Invalid die number ");$ ERROR:CODE_INDENT: code indent should use tabs where possible #513: FILE: lib/power/rte_power_uncore.c:372: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #513: FILE: lib/power/rte_power_uncore.c:372: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #514: FILE: lib/power/rte_power_uncore.c:373: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #516: FILE: lib/power/rte_power_uncore.c:375: + struct uncore_power_info *ui = &uncore_info[pkg][die];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #518: FILE: lib/power/rte_power_uncore.c:377: + if (fprintf(ui->f_cur_min, "%u", ui->freqs[ui->nb_freqs - 1]) < 0) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #519: FILE: lib/power/rte_power_uncore.c:378: + RTE_LOG(ERR, POWER, "Fail to write new uncore frequency for "$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #519: FILE: lib/power/rte_power_uncore.c:378: + RTE_LOG(ERR, POWER, "Fail to write new uncore frequency for "$ ERROR:CODE_INDENT: code indent should use tabs where possible #520: FILE: lib/power/rte_power_uncore.c:379: + "pkg %02u die %02u ", ui->pkg, ui->die);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #520: FILE: lib/power/rte_power_uncore.c:379: + "pkg %02u die %02u ", ui->pkg, ui->die);$ ERROR:CODE_INDENT: code indent should use tabs where possible #521: FILE: lib/power/rte_power_uncore.c:380: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #521: FILE: lib/power/rte_power_uncore.c:380: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #522: FILE: lib/power/rte_power_uncore.c:381: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #524: FILE: lib/power/rte_power_uncore.c:383: + fflush(ui->f_cur_min);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #525: FILE: lib/power/rte_power_uncore.c:384: + return 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #531: FILE: lib/power/rte_power_uncore.c:390: + if (pkg >= RTE_MAX_NUMA_NODES) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #532: FILE: lib/power/rte_power_uncore.c:391: + RTE_LOG(DEBUG, POWER, "Invalid package number ");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #532: FILE: lib/power/rte_power_uncore.c:391: + RTE_LOG(DEBUG, POWER, "Invalid package number ");$ ERROR:CODE_INDENT: code indent should use tabs where possible #533: FILE: lib/power/rte_power_uncore.c:392: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #533: FILE: lib/power/rte_power_uncore.c:392: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #534: FILE: lib/power/rte_power_uncore.c:393: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #536: FILE: lib/power/rte_power_uncore.c:395: + if (die >= RTE_MAX_NUMA_DIE) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #537: FILE: lib/power/rte_power_uncore.c:396: + RTE_LOG(DEBUG, POWER, "Invalid die number ");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #537: FILE: lib/power/rte_power_uncore.c:396: + RTE_LOG(DEBUG, POWER, "Invalid die number ");$ ERROR:CODE_INDENT: code indent should use tabs where possible #538: FILE: lib/power/rte_power_uncore.c:397: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #538: FILE: lib/power/rte_power_uncore.c:397: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #539: FILE: lib/power/rte_power_uncore.c:398: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #541: FILE: lib/power/rte_power_uncore.c:400: + return uncore_info[pkg][die].nb_freqs;$ WARNING:TYPO_SPELLING: 'managment' may be misspelled - perhaps 'management'? #568: FILE: lib/power/rte_power_uncore.h:20: + * Initialize uncore frequency managment for specific die on a package. It will check and set the ERROR:TRAILING_WHITESPACE: trailing whitespace #571: FILE: lib/power/rte_power_uncore.h:23: + * $ WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns #588: FILE: lib/power/rte_power_uncore.h:40: + * Exit uncore frequency management on a specific die on a package. It will set the governor to which ERROR:TRAILING_WHITESPACE: trailing whitespace #590: FILE: lib/power/rte_power_uncore.h:42: + * $ ERROR:TRAILING_WHITESPACE: trailing whitespace #609: FILE: lib/power/rte_power_uncore.h:61: + * $ ERROR:TRAILING_WHITESPACE: trailing whitespace #629: FILE: lib/power/rte_power_uncore.h:81: + * $ ERROR:TRAILING_WHITESPACE: trailing whitespace #651: FILE: lib/power/rte_power_uncore.h:103: + * $ ERROR:TRAILING_WHITESPACE: trailing whitespace #671: FILE: lib/power/rte_power_uncore.h:123: + * $ ERROR:TRAILING_WHITESPACE: trailing whitespace #677: FILE: lib/power/rte_power_uncore.h:129: + * Die number. $ ERROR:TRAILING_WHITESPACE: trailing whitespace #689: FILE: lib/power/rte_power_uncore.h:141: + * $ ERROR:TRAILING_WHITESPACE: trailing whitespace #693: FILE: lib/power/rte_power_uncore.h:145: + * Die number. $ ERROR:TRAILING_WHITESPACE: trailing whitespace #694: FILE: lib/power/rte_power_uncore.h:146: + * $ total: 138 errors, 267 warnings, 610 lines checked