From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0DC11A00C4
	for <public@inbox.dpdk.org>; Thu,  4 Aug 2022 19:01:09 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D000142C09;
	Thu,  4 Aug 2022 19:01:08 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 6B41A42BCA
 for <test-report@dpdk.org>; Thu,  4 Aug 2022 19:01:07 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 6804D12077C; Thu,  4 Aug 2022 19:01:07 +0200 (CEST)
Subject: |WARNING| pw114633 [PATCH 09/21] net/softnic: remove unused text
 parsing functions
In-Reply-To: <20220804165839.1074817-10-cristian.dumitrescu@intel.com>
References: <20220804165839.1074817-10-cristian.dumitrescu@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Message-Id: <20220804170107.6804D12077C@dpdk.org>
Date: Thu,  4 Aug 2022 19:01:07 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/114633

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'string == NULL'
#732: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:55:
+	if ((string == NULL) ||
+		(tokens == NULL) ||
+		(*n_tokens < 1))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tokens == NULL'
#732: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:55:
+	if ((string == NULL) ||
+		(tokens == NULL) ||
+		(*n_tokens < 1))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == *n_tokens'
#743: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:66:
+	if ((i == *n_tokens) && strtok_r(string, PARSE_DELIMITER, &string))

total: 0 errors, 0 warnings, 3 checks, 117 lines checked