From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3D22CA00C4
	for <public@inbox.dpdk.org>; Thu,  4 Aug 2022 19:03:05 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3994042BF2;
	Thu,  4 Aug 2022 19:03:05 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 1755542BF2
 for <test-report@dpdk.org>; Thu,  4 Aug 2022 19:03:04 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 0E3D4120775; Thu,  4 Aug 2022 19:03:04 +0200 (CEST)
Subject: |WARNING| pw114643 [PATCH 20/21] net/softnic: add pipeline mirroring
 CLI command
In-Reply-To: <20220804165839.1074817-21-cristian.dumitrescu@intel.com>
References: <20220804165839.1074817-21-cristian.dumitrescu@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Message-Id: <20220804170304.0E3D4120775@dpdk.org>
Date: Thu,  4 Aug 2022 19:03:04 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/114643

_coding style issues_


WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#84: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2116:
+ * ^Itruncate <truncation_length>$

CHECK:BRACES: braces {} should be used on all arms of this statement
#144: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2176:
+	if (!strcmp(tokens[8], "fast"))
[...]
+	else if (!strcmp(tokens[8], "slow"))
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#148: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2180:
+	else {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 4'
#178: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2487:
+		if ((n_tokens >= 4) &&
+			!strcmp(tokens[2], "mirror") &&
+			!strcmp(tokens[3], "session")) {

total: 0 errors, 1 warnings, 3 checks, 108 lines checked