From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: |WARNING| pw114641 [PATCH 18/21] net/softnic: add the pipeline meter CLI commands
Date: Thu, 4 Aug 2022 19:03:14 +0200 (CEST) [thread overview]
Message-ID: <20220804170314.A2CA8120775@dpdk.org> (raw)
In-Reply-To: <20220804165839.1074817-19-cristian.dumitrescu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/114641
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'idx1 < idx0'
#268: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1711:
+ if (parser_read_uint32(&idx1, tokens[7]) || (idx1 < idx0)) {
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#291: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1734:
+ * ^Iprofile <profile_name>$
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'idx1 < idx0'
#337: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1780:
+ if (parser_read_uint32(&idx1, tokens[7]) || (idx1 < idx0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'idx1 < idx0'
#413: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1856:
+ if (parser_read_uint32(&idx1, tokens[7]) || (idx1 < idx0)) {
CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#457: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1900:
+ snprintf(out, out_size, "| %7d | %16" PRIx64 " | %16" PRIx64 " | %16" PRIx64
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 6'
#479: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2161:
+ if ((n_tokens >= 6) &&
+ !strcmp(tokens[2], "meter") &&
+ !strcmp(tokens[3], "profile") &&
+ !strcmp(tokens[5], "add")) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 6'
#488: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2170:
+ if ((n_tokens >= 6) &&
+ !strcmp(tokens[2], "meter") &&
+ !strcmp(tokens[3], "profile") &&
+ !strcmp(tokens[5], "delete")) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 9'
#497: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2179:
+ if ((n_tokens >= 9) && !strcmp(tokens[2], "meter") && !strcmp(tokens[8], "reset")) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 9'
#502: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2184:
+ if ((n_tokens >= 9) && !strcmp(tokens[2], "meter") && !strcmp(tokens[8], "set")) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 9'
#507: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2189:
+ if ((n_tokens >= 9) && !strcmp(tokens[2], "meter") && !strcmp(tokens[8], "stats")) {
total: 0 errors, 1 warnings, 9 checks, 435 lines checked
parent reply other threads:[~2022-08-04 17:03 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220804165839.1074817-19-cristian.dumitrescu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220804170314.A2CA8120775@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=cristian.dumitrescu@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).