From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 684FFA00C4
	for <public@inbox.dpdk.org>; Thu,  4 Aug 2022 19:03:16 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5FDF042BF2;
	Thu,  4 Aug 2022 19:03:16 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id A68A04067C
 for <test-report@dpdk.org>; Thu,  4 Aug 2022 19:03:14 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id A2CA8120775; Thu,  4 Aug 2022 19:03:14 +0200 (CEST)
Subject: |WARNING| pw114641 [PATCH 18/21] net/softnic: add the pipeline meter
 CLI commands
In-Reply-To: <20220804165839.1074817-19-cristian.dumitrescu@intel.com>
References: <20220804165839.1074817-19-cristian.dumitrescu@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Message-Id: <20220804170314.A2CA8120775@dpdk.org>
Date: Thu,  4 Aug 2022 19:03:14 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/114641

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'idx1 < idx0'
#268: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1711:
+	if (parser_read_uint32(&idx1, tokens[7]) || (idx1 < idx0)) {

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#291: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1734:
+ * ^Iprofile <profile_name>$

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'idx1 < idx0'
#337: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1780:
+	if (parser_read_uint32(&idx1, tokens[7]) || (idx1 < idx0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'idx1 < idx0'
#413: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1856:
+	if (parser_read_uint32(&idx1, tokens[7]) || (idx1 < idx0)) {

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#457: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1900:
+		snprintf(out, out_size, "| %7d | %16" PRIx64 " | %16" PRIx64 " | %16" PRIx64

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 6'
#479: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2161:
+		if ((n_tokens >= 6) &&
+			!strcmp(tokens[2], "meter") &&
+			!strcmp(tokens[3], "profile") &&
+			!strcmp(tokens[5], "add")) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 6'
#488: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2170:
+		if ((n_tokens >= 6) &&
+			!strcmp(tokens[2], "meter") &&
+			!strcmp(tokens[3], "profile") &&
+			!strcmp(tokens[5], "delete")) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 9'
#497: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2179:
+		if ((n_tokens >= 9) && !strcmp(tokens[2], "meter") && !strcmp(tokens[8], "reset")) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 9'
#502: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2184:
+		if ((n_tokens >= 9) && !strcmp(tokens[2], "meter") && !strcmp(tokens[8], "set")) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 9'
#507: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2189:
+		if ((n_tokens >= 9) && !strcmp(tokens[2], "meter") && !strcmp(tokens[8], "stats")) {

total: 0 errors, 1 warnings, 9 checks, 435 lines checked