From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Cheng Jiang <cheng1.jiang@intel.com>
Subject: |WARNING| pw114948 [RFC 2/2] vhost: add egress API for port mirroring datapath
Date: Sun, 14 Aug 2022 15:20:57 +0200 (CEST) [thread overview]
Message-ID: <20220814132057.F0A5D120775@dpdk.org> (raw)
In-Reply-To: <20220814124920.14338-3-cheng1.jiang@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/114948
_coding style issues_
ERROR:INITIALISED_STATIC: do not initialise statics to 0
#318: FILE: lib/vhost/virtio_net.c:4018:
+ static uint64_t total = 0;
WARNING:LONG_LINE: line length of 144 exceeds 100 columns
#360: FILE: lib/vhost/virtio_net.c:4060:
+ if ((((uintptr_t)rte_pktmbuf_iova_offset(cur, mbuf_offset) & 0xFFF) ^ ((uint64_t)mirror_hpa & 0xFFF)) != 0 && flag == 0)
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#360: FILE: lib/vhost/virtio_net.c:4060:
+ if ((((uintptr_t)rte_pktmbuf_iova_offset(cur, mbuf_offset) & 0xFFF) ^ ((uint64_t)mirror_hpa & 0xFFF)) != 0 && flag == 0)
+ {
WARNING:LONG_LINE: line length of 173 exceeds 100 columns
#363: FILE: lib/vhost/virtio_net.c:4063:
+ VHOST_LOG_DATA(ERR, "%lu.........mbuf=%p mirror_hpa=%p.
", total, (void *)(uintptr_t)rte_pktmbuf_iova_offset(cur, mbuf_offset), mirror_hpa);
WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#621: FILE: lib/vhost/virtio_net.c:4321:
+ ret = vq->async_ops.transfer_data(dev->vid, queue_id, tdes, 0, nr_async_burst, true);
WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#807: FILE: lib/vhost/virtio_net.c:4507:
+#if 0
total: 2 errors, 4 warnings, 764 lines checked
Warning in lib/vhost/virtio_net.c:
Using %l format, prefer %PRI*64 if type is [u]int64_t
parent reply other threads:[~2022-08-14 13:20 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220814124920.14338-3-cheng1.jiang@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220814132057.F0A5D120775@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=cheng1.jiang@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).