From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 86AB1A034C
	for <public@inbox.dpdk.org>; Sun, 14 Aug 2022 15:20:58 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 827FF40698;
	Sun, 14 Aug 2022 15:20:58 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 150BD40697
 for <test-report@dpdk.org>; Sun, 14 Aug 2022 15:20:58 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id F0A5D120775; Sun, 14 Aug 2022 15:20:57 +0200 (CEST)
Subject: |WARNING| pw114948 [RFC 2/2] vhost: add egress API for port mirroring
 datapath
In-Reply-To: <20220814124920.14338-3-cheng1.jiang@intel.com>
References: <20220814124920.14338-3-cheng1.jiang@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Cheng Jiang <cheng1.jiang@intel.com>
Message-Id: <20220814132057.F0A5D120775@dpdk.org>
Date: Sun, 14 Aug 2022 15:20:57 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/114948

_coding style issues_


ERROR:INITIALISED_STATIC: do not initialise statics to 0
#318: FILE: lib/vhost/virtio_net.c:4018:
+	static uint64_t total = 0;

WARNING:LONG_LINE: line length of 144 exceeds 100 columns
#360: FILE: lib/vhost/virtio_net.c:4060:
+			if ((((uintptr_t)rte_pktmbuf_iova_offset(cur, mbuf_offset) & 0xFFF) ^ ((uint64_t)mirror_hpa & 0xFFF)) != 0 && flag == 0)

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#360: FILE: lib/vhost/virtio_net.c:4060:
+			if ((((uintptr_t)rte_pktmbuf_iova_offset(cur, mbuf_offset) & 0xFFF) ^ ((uint64_t)mirror_hpa & 0xFFF)) != 0 && flag == 0)
+			{

WARNING:LONG_LINE: line length of 173 exceeds 100 columns
#363: FILE: lib/vhost/virtio_net.c:4063:
+				VHOST_LOG_DATA(ERR, "%lu.........mbuf=%p mirror_hpa=%p.
", total, (void *)(uintptr_t)rte_pktmbuf_iova_offset(cur, mbuf_offset), mirror_hpa);

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#621: FILE: lib/vhost/virtio_net.c:4321:
+		ret = vq->async_ops.transfer_data(dev->vid, queue_id, tdes, 0, nr_async_burst, true);

WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#807: FILE: lib/vhost/virtio_net.c:4507:
+#if 0

total: 2 errors, 4 warnings, 764 lines checked
Warning in lib/vhost/virtio_net.c:
Using %l format, prefer %PRI*64 if type is [u]int64_t