From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53803A00C3 for ; Mon, 15 Aug 2022 01:07:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B8E141181; Mon, 15 Aug 2022 01:07:00 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 001E84014F for ; Mon, 15 Aug 2022 01:06:58 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id F0D11120775; Mon, 15 Aug 2022 01:06:58 +0200 (CEST) Subject: |WARNING| pw114977 [PATCH 20/70] net/ice/base: refactor DDP code In-Reply-To: <20220815071306.2910599-21-qi.z.zhang@intel.com> References: <20220815071306.2910599-21-qi.z.zhang@intel.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Qi Zhang Message-Id: <20220814230658.F0D11120775@dpdk.org> Date: Mon, 15 Aug 2022 01:06:58 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/114977 _coding style issues_ WARNING:TYPO_SPELLING: 'Aslo' may be misspelled - perhaps 'Also'? #68: Aslo added support for DDP signature segments. CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects? #3172: FILE: drivers/net/ice/base/ice_defs.h:31: +#define ROUND_UP(a, b) ((b) * DIVIDE_AND_ROUND_UP((a), (b))) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_t' - possible side-effects? #3174: FILE: drivers/net/ice/base/ice_defs.h:33: +#define MIN_T(_t, _a, _b) min((_t)(_a), (_t)(_b)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ptr' - possible side-effects? #3185: FILE: drivers/net/ice/base/ice_defs.h:44: +#define ice_struct_size(ptr, field, num) \ + (sizeof(*(ptr)) + sizeof(*(ptr)->field) * (num)) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'field' may be better as '(field)' to avoid precedence issues #3185: FILE: drivers/net/ice/base/ice_defs.h:44: +#define ice_struct_size(ptr, field, num) \ + (sizeof(*(ptr)) + sizeof(*(ptr)->field) * (num)) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_mem' may be better as '(_mem)' to avoid precedence issues #3188: FILE: drivers/net/ice/base/ice_defs.h:47: +#define FLEX_ARRAY_SIZE(_ptr, _mem, cnt) ((cnt) * sizeof(_ptr->_mem[0])) WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'? #5156: FILE: drivers/net/ice/base/ice_flex_pipe.c:191: + * dont_care: b0 0 1 1 0 0 WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'? #5163: FILE: drivers/net/ice/base/ice_flex_pipe.c:197: +ice_gen_key_word(u8 val, u8 valid, u8 dont_care, u8 nvr_mtch, u8 *key, WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'? #5174: FILE: drivers/net/ice/base/ice_flex_pipe.c:203: + /* 'dont_care' and 'nvr_mtch' masks cannot overlap */ WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'? #5175: FILE: drivers/net/ice/base/ice_flex_pipe.c:204: + if ((dont_care ^ nvr_mtch) != (dont_care | nvr_mtch)) WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'? #5175: FILE: drivers/net/ice/base/ice_flex_pipe.c:204: + if ((dont_care ^ nvr_mtch) != (dont_care | nvr_mtch)) WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'? #5197: FILE: drivers/net/ice/base/ice_flex_pipe.c:218: + } else if (dont_care & 0x1) { /* don't care bit */ WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'? #5214: FILE: drivers/net/ice/base/ice_flex_pipe.c:232: + dont_care >>= 1; total: 0 errors, 8 warnings, 5 checks, 5876 lines checked