From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE646A0032 for ; Wed, 17 Aug 2022 13:00:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB05240DDA; Wed, 17 Aug 2022 13:00:09 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 740054068E for ; Wed, 17 Aug 2022 13:00:08 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 5ED38121D40; Wed, 17 Aug 2022 13:00:08 +0200 (CEST) Subject: |WARNING| pw115207 [PATCH] app/test: random test vectors for Asymc RSA In-Reply-To: <20220817105751.17656-1-przemyslawx.zegan@intel.com> References: <20220817105751.17656-1-przemyslawx.zegan@intel.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Przemyslaw Zegan Message-Id: <20220817110008.5ED38121D40@dpdk.org> Date: Wed, 17 Aug 2022 13:00:08 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/115207 _coding style issues_ ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #409: FILE: app/test/test_cryptodev_asym_common.c:11: +int ats_common_setup(struct crypto_testsuite_params_asym* ts) ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #440: FILE: app/test/test_cryptodev_asym_common.c:42: +void ats_common_teardown(struct crypto_testsuite_params_asym* ts) ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #454: FILE: app/test/test_cryptodev_asym_common.c:56: +void ats_err_msg_op(char* msg, uint32_t len, uint32_t line) ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #461: FILE: app/test/test_cryptodev_asym_common.c:63: +void ats_err_msg_mod_len(char* msg, uint32_t len, uint32_t line) ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #468: FILE: app/test/test_cryptodev_asym_common.c:70: +void ats_err_msg_inv_alg(char* msg, uint32_t len, uint32_t line) ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #475: FILE: app/test/test_cryptodev_asym_common.c:77: +void ats_err_msg_sess_create(char* msg, uint32_t len, uint32_t line) ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #482: FILE: app/test/test_cryptodev_asym_common.c:84: +void ats_err_msg_sess_init(char* msg, uint32_t len, uint32_t line) WARNING:TYPO_SPELLING: 'enque' may be misspelled - perhaps 'enqueue'? #489: FILE: app/test/test_cryptodev_asym_common.c:91: +void ats_err_msg_enque(char* msg, uint32_t len, uint32_t line) ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #489: FILE: app/test/test_cryptodev_asym_common.c:91: +void ats_err_msg_enque(char* msg, uint32_t len, uint32_t line) ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #496: FILE: app/test/test_cryptodev_asym_common.c:98: +void ats_err_msg_burst(char* msg, uint32_t len, uint32_t line) ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #503: FILE: app/test/test_cryptodev_asym_common.c:105: +void ats_err_msg_deq(char* msg, uint32_t len, uint32_t line) ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #510: FILE: app/test/test_cryptodev_asym_common.c:112: +void ats_err_msg_ver(char* msg, uint32_t len, uint32_t line) ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #545: FILE: app/test/test_cryptodev_asym_common.h:24: +int ats_common_setup(struct crypto_testsuite_params_asym* ts); ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #547: FILE: app/test/test_cryptodev_asym_common.h:26: +void ats_common_teardown(struct crypto_testsuite_params_asym* ts); ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #551: FILE: app/test/test_cryptodev_asym_common.h:30: +void ats_err_msg_op(char* msg, uint32_t len, uint32_t line); ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #553: FILE: app/test/test_cryptodev_asym_common.h:32: +void ats_err_msg_mod_len(char* msg, uint32_t len, uint32_t line); ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #555: FILE: app/test/test_cryptodev_asym_common.h:34: +void ats_err_msg_inv_alg(char* msg, uint32_t len, uint32_t line); ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #557: FILE: app/test/test_cryptodev_asym_common.h:36: +void ats_err_msg_sess_create(char* msg, uint32_t len, uint32_t line); ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #559: FILE: app/test/test_cryptodev_asym_common.h:38: +void ats_err_msg_sess_init(char* msg, uint32_t len, uint32_t line); WARNING:TYPO_SPELLING: 'enque' may be misspelled - perhaps 'enqueue'? #561: FILE: app/test/test_cryptodev_asym_common.h:40: +void ats_err_msg_enque(char* msg, uint32_t len, uint32_t line); ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #561: FILE: app/test/test_cryptodev_asym_common.h:40: +void ats_err_msg_enque(char* msg, uint32_t len, uint32_t line); ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #563: FILE: app/test/test_cryptodev_asym_common.h:42: +void ats_err_msg_burst(char* msg, uint32_t len, uint32_t line); ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #565: FILE: app/test/test_cryptodev_asym_common.h:44: +void ats_err_msg_deq(char* msg, uint32_t len, uint32_t line); ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #567: FILE: app/test/test_cryptodev_asym_common.h:46: +void ats_err_msg_ver(char* msg, uint32_t len, uint32_t line); ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #593: FILE: app/test/test_cryptodev_asym_creator.c:17: +int atv_create_data(uint8_t* data, int len) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #593: FILE: app/test/test_cryptodev_asym_creator.c:17: +int atv_create_data(uint8_t* data, int len) { ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #609: FILE: app/test/test_cryptodev_asym_creator.c:33: + int* dt = (int*) data; ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #609: FILE: app/test/test_cryptodev_asym_creator.c:33: + int* dt = (int*) data; ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #634: FILE: app/test/test_cryptodev_asym_creator.h:11: +int atv_create_data(uint8_t* data, int len); ERROR:INITIALISED_STATIC: do not initialise statics to NULL #664: FILE: app/test/test_cryptodev_asym_rsa.c:22: +static struct asym_test_rsa_vct* vct = NULL; ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #664: FILE: app/test/test_cryptodev_asym_rsa.c:22: +static struct asym_test_rsa_vct* vct = NULL; ERROR:INITIALISED_STATIC: do not initialise statics to 0 #665: FILE: app/test/test_cryptodev_asym_rsa.c:23: +static int vct_nb = 0; WARNING:AVOID_EXTERNS: externs should be avoided in .c files #667: FILE: app/test/test_cryptodev_asym_rsa.c:25: +extern struct crypto_testsuite_params_asym testsuite_params_asym; WARNING:SPACE_BEFORE_TAB: please, no space before tabs #730: FILE: app/test/test_cryptodev_asym_rsa.c:88: +^I^Iop->asym->rsa.op_type ^I= op_type;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #731: FILE: app/test/test_cryptodev_asym_rsa.c:89: +^I^Ixform_tc.rsa.e.data ^I= data_tc->e.data;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #732: FILE: app/test/test_cryptodev_asym_rsa.c:90: +^I^Ixform_tc.rsa.e.length ^I= data_tc->e.len;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #733: FILE: app/test/test_cryptodev_asym_rsa.c:91: +^I^Ixform_tc.rsa.n.data ^I= data_tc->n.data;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #734: FILE: app/test/test_cryptodev_asym_rsa.c:92: +^I^Ixform_tc.rsa.n.length ^I= data_tc->n.len;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #737: FILE: app/test/test_cryptodev_asym_rsa.c:95: +^I^I^Ixform_tc.rsa.d.data ^I^I= data_tc->d.data;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #738: FILE: app/test/test_cryptodev_asym_rsa.c:96: +^I^I^Ixform_tc.rsa.d.length ^I^I= data_tc->d.len;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #740: FILE: app/test/test_cryptodev_asym_rsa.c:98: +^I^I^Ixform_tc.rsa.qt.p.data ^I^I= data_tc->p.data;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #741: FILE: app/test/test_cryptodev_asym_rsa.c:99: +^I^I^Ixform_tc.rsa.qt.p.length ^I= data_tc->p.len;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #742: FILE: app/test/test_cryptodev_asym_rsa.c:100: +^I^I^Ixform_tc.rsa.qt.q.data ^I^I= data_tc->q.data;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #743: FILE: app/test/test_cryptodev_asym_rsa.c:101: +^I^I^Ixform_tc.rsa.qt.q.length ^I= data_tc->q.len;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #744: FILE: app/test/test_cryptodev_asym_rsa.c:102: +^I^I^Ixform_tc.rsa.qt.dP.data ^I= data_tc->dP.data;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #745: FILE: app/test/test_cryptodev_asym_rsa.c:103: +^I^I^Ixform_tc.rsa.qt.dP.length ^I= data_tc->dP.len;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #746: FILE: app/test/test_cryptodev_asym_rsa.c:104: +^I^I^Ixform_tc.rsa.qt.dQ.data ^I= data_tc->dQ.data;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #747: FILE: app/test/test_cryptodev_asym_rsa.c:105: +^I^I^Ixform_tc.rsa.qt.dQ.length ^I= data_tc->dQ.len;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #748: FILE: app/test/test_cryptodev_asym_rsa.c:106: +^I^I^Ixform_tc.rsa.qt.qInv.data ^I= data_tc->qInv.data;$ WARNING:TYPO_SPELLING: 'enque' may be misspelled - perhaps 'enqueue'? #802: FILE: app/test/test_cryptodev_asym_rsa.c:160: + ats_err_msg_enque(test_msg, ASYM_TEST_MSG_LEN, __LINE__); WARNING:BRACES: braces {} are not necessary for single statement blocks #841: FILE: app/test/test_cryptodev_asym_rsa.c:199: + if (sess != NULL) { + rte_cryptodev_asym_session_free(dev_id, sess); + } ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1000: FILE: app/test/test_cryptodev_asym_rsa_creator.c:21: +static int rsa_result(RSA* rsa, struct asym_test_rsa_vct* vct, ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1000: FILE: app/test/test_cryptodev_asym_rsa_creator.c:21: +static int rsa_result(RSA* rsa, struct asym_test_rsa_vct* vct, ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #1000: FILE: app/test/test_cryptodev_asym_rsa_creator.c:21: +static int rsa_result(RSA* rsa, struct asym_test_rsa_vct* vct, + enum rte_crypto_rsa_padding_type padding) { ERROR:C99_COMMENTS: do not use C99 // comments #1011: FILE: app/test/test_cryptodev_asym_rsa_creator.c:32: + // encrypt plain text WARNING:BRACES: braces {} are not necessary for any arm of this statement #1015: FILE: app/test/test_cryptodev_asym_rsa_creator.c:36: + if (clen >= 0) { [...] + } else [...] ERROR:C99_COMMENTS: do not use C99 // comments #1020: FILE: app/test/test_cryptodev_asym_rsa_creator.c:41: + // checking decryption ERROR:C99_COMMENTS: do not use C99 // comments #1028: FILE: app/test/test_cryptodev_asym_rsa_creator.c:49: + // create digest and sign WARNING:BRACES: braces {} are not necessary for any arm of this statement #1046: FILE: app/test/test_cryptodev_asym_rsa_creator.c:67: + if (clen >= 0) { [...] + } else [...] WARNING:INDENTED_LABEL: labels should not be indented #1053: FILE: app/test/test_cryptodev_asym_rsa_creator.c:74: + err: return state; ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1056: FILE: app/test/test_cryptodev_asym_rsa_creator.c:77: +int atv_rsa_creator(struct asym_test_rsa_vct* vct, ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #1056: FILE: app/test/test_cryptodev_asym_rsa_creator.c:77: +int atv_rsa_creator(struct asym_test_rsa_vct* vct, + struct asym_test_rsa_rule* rule) { ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1057: FILE: app/test/test_cryptodev_asym_rsa_creator.c:78: + struct asym_test_rsa_rule* rule) { ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1059: FILE: app/test/test_cryptodev_asym_rsa_creator.c:80: + BN_CTX* ctx = NULL; ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1061: FILE: app/test/test_cryptodev_asym_rsa_creator.c:82: + BIGNUM* exp = NULL; ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1063: FILE: app/test/test_cryptodev_asym_rsa_creator.c:84: + const BIGNUM* n = NULL; ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1064: FILE: app/test/test_cryptodev_asym_rsa_creator.c:85: + const BIGNUM* e = NULL; ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1065: FILE: app/test/test_cryptodev_asym_rsa_creator.c:86: + const BIGNUM* p = NULL; ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1066: FILE: app/test/test_cryptodev_asym_rsa_creator.c:87: + const BIGNUM* d = NULL; ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1067: FILE: app/test/test_cryptodev_asym_rsa_creator.c:88: + const BIGNUM* q = NULL; ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1068: FILE: app/test/test_cryptodev_asym_rsa_creator.c:89: + const BIGNUM* dmp1 = NULL; ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1069: FILE: app/test/test_cryptodev_asym_rsa_creator.c:90: + const BIGNUM* dmq1 = NULL; ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1070: FILE: app/test/test_cryptodev_asym_rsa_creator.c:91: + const BIGNUM* iqmp = NULL; ERROR:OPEN_BRACE: that open brace { should be on the previous line #1072: FILE: app/test/test_cryptodev_asym_rsa_creator.c:93: + for(;;) + { ERROR:SPACING: space required before the open parenthesis '(' #1072: FILE: app/test/test_cryptodev_asym_rsa_creator.c:93: + for(;;) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1082: FILE: app/test/test_cryptodev_asym_rsa_creator.c:103: + if ((ret = BN_set_word(exp, RSA_F4)) == 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1085: FILE: app/test/test_cryptodev_asym_rsa_creator.c:106: + if ((ret = RSA_generate_key_ex(rsa, rule->key_size, exp, NULL)) == 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1088: FILE: app/test/test_cryptodev_asym_rsa_creator.c:109: + if ((ret = rsa_result(rsa, vct, rule->padding)) == 0) WARNING:INDENTED_LABEL: labels should not be indented #1105: FILE: app/test/test_cryptodev_asym_rsa_creator.c:126: + err: WARNING:SUSPECT_COMMA_SEMICOLON: Possible comma where semicolon could be used #1115: FILE: app/test/test_cryptodev_asym_rsa_creator.c:136: + vct->padding = rule->padding, + vct->op_type_flags = rule->operation; ERROR:C99_COMMENTS: do not use C99 // comments #1120: FILE: app/test/test_cryptodev_asym_rsa_creator.c:141: + // create description ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1142: FILE: app/test/test_cryptodev_asym_rsa_creator.h:13: +int atv_rsa_creator(struct asym_test_rsa_vct* vct, struct asym_test_rsa_rule* rule); ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1142: FILE: app/test/test_cryptodev_asym_rsa_creator.h:13: +int atv_rsa_creator(struct asym_test_rsa_vct* vct, struct asym_test_rsa_rule* rule); ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1188: FILE: app/test/test_cryptodev_asym_vectors.c:12: +void atv_free(void* vct) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #1188: FILE: app/test/test_cryptodev_asym_vectors.c:12: +void atv_free(void* vct) { ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1192: FILE: app/test/test_cryptodev_asym_vectors.c:16: +struct asym_test_rsa_vct* atv_rsa(int* vct_nb) { ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1192: FILE: app/test/test_cryptodev_asym_vectors.c:16: +struct asym_test_rsa_vct* atv_rsa(int* vct_nb) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #1192: FILE: app/test/test_cryptodev_asym_vectors.c:16: +struct asym_test_rsa_vct* atv_rsa(int* vct_nb) { ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1193: FILE: app/test/test_cryptodev_asym_vectors.c:17: + struct asym_test_rsa_vct* vct = NULL; ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1223: FILE: app/test/test_cryptodev_asym_vectors.h:12: +void atv_free(void* vct); ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1225: FILE: app/test/test_cryptodev_asym_vectors.h:14: +struct asym_test_modex_vct* atv_modex(int* vct_nb); ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1225: FILE: app/test/test_cryptodev_asym_vectors.h:14: +struct asym_test_modex_vct* atv_modex(int* vct_nb); ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1227: FILE: app/test/test_cryptodev_asym_vectors.h:16: +struct asym_test_rsa_vct* atv_rsa(int* vct_nb); ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1227: FILE: app/test/test_cryptodev_asym_vectors.h:16: +struct asym_test_rsa_vct* atv_rsa(int* vct_nb); ERROR:TRAILING_WHITESPACE: trailing whitespace #1228: FILE: app/test/test_cryptodev_asym_vectors.h:17: + $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1228: FILE: app/test/test_cryptodev_asym_vectors.h:17: + $ ERROR:OPEN_BRACE: open brace '{' following struct go on the same line #1309: FILE: app/test/test_cryptodev_asym_vectors_def.h:74: +struct asym_test_rsa_rule +{ ERROR:OPEN_BRACE: open brace '{' following struct go on the same line #1358: FILE: app/test/test_cryptodev_asym_vectors_def.h:123: +struct asym_test_modexp_rule +{ ERROR:OPEN_BRACE: open brace '{' following struct go on the same line #1365: FILE: app/test/test_cryptodev_asym_vectors_def.h:130: +struct asym_test_modinv_rule +{ ERROR:OPEN_BRACE: that open brace { should be on the previous line #1389: FILE: app/test/test_cryptodev_asym_vectors_rules.h:13: +static struct asym_test_rsa_rule asym_test_rsa_rules[] = +{ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1391: FILE: app/test/test_cryptodev_asym_vectors_rules.h:15: +^I^I.key_size ^I= 1024,$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1393: FILE: app/test/test_cryptodev_asym_vectors_rules.h:17: +^I^I.padding ^I= RTE_CRYPTO_RSA_PADDING_NONE,$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1394: FILE: app/test/test_cryptodev_asym_vectors_rules.h:18: +^I^I.pt_len ^I= 128,$ total: 73 errors, 30 warnings, 1202 lines checked