From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Buckley, Daniel M" <daniel.m.buckley@intel.com>
Subject: |WARNING| pw115567 [PATCH 2/2] net/iavf: support inner and outer checksum offload
Date: Mon, 29 Aug 2022 09:02:38 +0200 (CEST) [thread overview]
Message-ID: <20220829070238.C543F121DAD@dpdk.org> (raw)
In-Reply-To: <20220812165223.470777-2-peng1x.zhang@intel.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 3358 bytes --]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/115567
_coding style issues_
WARNING:BAD_SIGN_OFF: email address 'beilei.xing@intel.com, jingjing.wu@intel.com,' might be better as 'beilei.xing@intel.com,jingjing.wu@intel.com,'
#199:
Cc: beilei.xing@intel.com, jingjing.wu@intel.com,
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#299: FILE: drivers/net/iavf/iavf_rxtx.c:2421:
+ /* L4TUNLEN: L4 Tunneling Length, in Words
+ *
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#307: FILE: drivers/net/iavf/iavf_rxtx.c:2429:
+ */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#311: FILE: drivers/net/iavf/iavf_rxtx.c:2433:
+ /**
+ * Calculate the tunneling UDP checksum.
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#313: FILE: drivers/net/iavf/iavf_rxtx.c:2435:
+ */
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#314: FILE: drivers/net/iavf/iavf_rxtx.c:2436:
+ if (!(eip_typ & IAVF_TX_CTX_EXT_IP_NONE) &&
[...]
+ eip_typ |= IAVF_TXD_CTX_QW0_L4T_CS_MASK;
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#324: FILE: drivers/net/iavf/iavf_rxtx.c:2457:
if (m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK)
+ total_length -= m->outer_l3_len + m->outer_l2_len;
WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#326: FILE: drivers/net/iavf/iavf_rxtx.c:2458:
+ total_length -= m->outer_l3_len + m->outer_l2_len;
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#336: FILE: drivers/net/iavf/iavf_rxtx.c:2576:
+ if (m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK)
+ offset |= (m->outer_l2_len >> 1)
CHECK:SPACING: spaces preferred around that '<<' (ctx:VxW)
#338: FILE: drivers/net/iavf/iavf_rxtx.c:2578:
+ << IAVF_TX_DESC_LENGTH_MACLEN_SHIFT;
^
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#339: FILE: drivers/net/iavf/iavf_rxtx.c:2579:
+ else
[...]
+ << IAVF_TX_DESC_LENGTH_MACLEN_SHIFT;
CHECK:SPACING: spaces preferred around that '<<' (ctx:VxW)
#341: FILE: drivers/net/iavf/iavf_rxtx.c:2581:
+ << IAVF_TX_DESC_LENGTH_MACLEN_SHIFT;
^
CHECK:SPACING: spaces preferred around that '|' (ctx:WxV)
#355: FILE: drivers/net/iavf/iavf_rxtx.h:30:
+ RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM | \
^
CHECK:SPACING: spaces preferred around that '|' (ctx:WxV)
#373: FILE: drivers/net/iavf/iavf_rxtx.h:73:
+ RTE_MBUF_F_TX_TUNNEL_MASK | \
^
total: 0 errors, 10 warnings, 4 checks, 110 lines checked
prev parent reply other threads:[~2022-08-29 7:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220812165223.470777-2-peng1x.zhang@intel.com>
2022-08-12 9:04 ` |SUCCESS| pw114859 " checkpatch
2022-08-29 7:02 ` checkpatch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220829070238.C543F121DAD@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=daniel.m.buckley@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).