From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Subject: |WARNING| pw115690 [PATCH] net/virtio: fix crash when dev is configured twice
Date: Wed, 31 Aug 2022 05:01:43 -0400 (EDT) [thread overview]
Message-ID: <20220831090143.8C9D36D509@noxus.dpdklab.iol.unh.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 1356 bytes --]
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/115690
_apply patch failure_
Submitter: Alexander Chernavin <achernavin@netgate.com>
Date: Wednesday, August 31 2022 08:40:59
Applied on: CommitID:4aee6110bb10b0225fa9562f2e48af233a9058a1
Apply patch set 115690 failed:
Checking patch drivers/net/virtio/virtio_ethdev.c...
error: while searching for:
return ret;
}
if ((rxmode->mq_mode & RTE_ETH_MQ_RX_RSS_FLAG) &&
!virtio_with_feature(hw, VIRTIO_NET_F_RSS)) {
PMD_DRV_LOG(ERR, "RSS support requested but not supported by the device");
error: patch failed: drivers/net/virtio/virtio_ethdev.c:2616
Applying patch drivers/net/virtio/virtio_ethdev.c with 1 reject...
Rejected hunk #1.
diff a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c (rejected hunks)
@@ -2616,6 +2616,13 @@ virtio_dev_configure(struct rte_eth_dev *dev)
return ret;
}
+ /* if queues are not allocated, reinit the device */
+ if (hw->vqs == NULL) {
+ ret = virtio_init_device(dev, hw->req_guest_features);
+ if (ret < 0)
+ return ret;
+ }
+
if ((rxmode->mq_mode & RTE_ETH_MQ_RX_RSS_FLAG) &&
!virtio_with_feature(hw, VIRTIO_NET_F_RSS)) {
PMD_DRV_LOG(ERR, "RSS support requested but not supported by the device");
https://lab.dpdk.org/results/dashboard/patchsets/23358/
UNH-IOL DPDK Community Lab
next reply other threads:[~2022-08-31 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 9:01 dpdklab [this message]
[not found] <20220831084059.43918-1-achernavin@netgate.com>
2022-08-31 8:42 ` checkpatch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220831090143.8C9D36D509@noxus.dpdklab.iol.unh.edu \
--to=dpdklab@iol.unh.edu \
--cc=dpdk-test-reports@iol.unh.edu \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).