|WARNING| pw115690 [PATCH] net/virtio: fix crash when dev is configured twice

|WARNING| pw115690 [PATCH] net/virtio: fix crash when dev is configured twice

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 1356 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/115690

_apply patch failure_

Submitter: Alexander Chernavin <achernavin@netgate.com>
Date: Wednesday, August 31 2022 08:40:59 
Applied on: CommitID:4aee6110bb10b0225fa9562f2e48af233a9058a1
Apply patch set 115690 failed:

Checking patch drivers/net/virtio/virtio_ethdev.c...
error: while searching for:
     return ret;
 }

 if ((rxmode->mq_mode & RTE_ETH_MQ_RX_RSS_FLAG) &&
     !virtio_with_feature(hw, VIRTIO_NET_F_RSS)) {
   PMD_DRV_LOG(ERR, "RSS support requested but not supported by the device");

error: patch failed: drivers/net/virtio/virtio_ethdev.c:2616
Applying patch drivers/net/virtio/virtio_ethdev.c with 1 reject...
Rejected hunk #1.
diff a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c	(rejected hunks)
@@ -2616,6 +2616,13 @@ virtio_dev_configure(struct rte_eth_dev *dev)
      return ret;
  }
 
+ /* if queues are not allocated, reinit the device */
+ if (hw->vqs == NULL) {
+   ret = virtio_init_device(dev, hw->req_guest_features);
+   if (ret < 0)
+     return ret;
+ }
+
  if ((rxmode->mq_mode & RTE_ETH_MQ_RX_RSS_FLAG) &&
      !virtio_with_feature(hw, VIRTIO_NET_F_RSS)) {
    PMD_DRV_LOG(ERR, "RSS support requested but not supported by the device");

https://lab.dpdk.org/results/dashboard/patchsets/23358/

UNH-IOL DPDK Community Lab

|WARNING| pw115690 [PATCH] net/virtio: fix crash when dev is configured twice

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/115690

_coding style issues_


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#113: FILE: drivers/net/virtio/virtio_ethdev.c:2620:
+ if (hw->vqs == NULL) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (1, 3)
#113: FILE: drivers/net/virtio/virtio_ethdev.c:2620:
+ if (hw->vqs == NULL) {
+   ret = virtio_init_device(dev, hw->req_guest_features);

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#114: FILE: drivers/net/virtio/virtio_ethdev.c:2621:
+   ret = virtio_init_device(dev, hw->req_guest_features);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#115: FILE: drivers/net/virtio/virtio_ethdev.c:2622:
+   if (ret < 0)$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (3, 5)
#115: FILE: drivers/net/virtio/virtio_ethdev.c:2622:
+   if (ret < 0)
+     return ret;

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#116: FILE: drivers/net/virtio/virtio_ethdev.c:2623:
+     return ret;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: drivers/net/virtio/virtio_ethdev.c:2624:
+ }$

total: 0 errors, 7 warnings, 0 checks, 13 lines checked