From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABB28A0543 for ; Thu, 22 Sep 2022 21:09:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9DF040156; Thu, 22 Sep 2022 21:09:26 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 056A9400D7 for ; Thu, 22 Sep 2022 21:09:25 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id F250D121F02; Thu, 22 Sep 2022 21:09:24 +0200 (CEST) Subject: |WARNING| pw116672 [v1 09/19] net/mlx5/hws: Add HWS command layer In-Reply-To: <20220922190345.394-10-valex@nvidia.com> References: <20220922190345.394-10-valex@nvidia.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Alex Vesker Message-Id: <20220922190924.F250D121F02@dpdk.org> Date: Thu, 22 Sep 2022 21:09:24 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/116672 _coding style issues_ ERROR:CODE_INDENT: code indent should use tabs where possible #664: FILE: drivers/common/mlx5/mlx5_prm.h:3397: + struct mlx5_ifc_general_obj_in_cmd_hdr_bits hdr;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #664: FILE: drivers/common/mlx5/mlx5_prm.h:3397: + struct mlx5_ifc_general_obj_in_cmd_hdr_bits hdr;$ ERROR:CODE_INDENT: code indent should use tabs where possible #665: FILE: drivers/common/mlx5/mlx5_prm.h:3398: + struct mlx5_ifc_definer_bits definer;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #665: FILE: drivers/common/mlx5/mlx5_prm.h:3398: + struct mlx5_ifc_definer_bits definer;$ ERROR:CODE_INDENT: code indent should use tabs where possible #669: FILE: drivers/common/mlx5/mlx5_prm.h:3402: + struct mlx5_ifc_general_obj_in_cmd_hdr_bits hdr;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #669: FILE: drivers/common/mlx5/mlx5_prm.h:3402: + struct mlx5_ifc_general_obj_in_cmd_hdr_bits hdr;$ ERROR:CODE_INDENT: code indent should use tabs where possible #670: FILE: drivers/common/mlx5/mlx5_prm.h:3403: + struct mlx5_ifc_arg_bits arg;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #670: FILE: drivers/common/mlx5/mlx5_prm.h:3403: + struct mlx5_ifc_arg_bits arg;$ ERROR:CODE_INDENT: code indent should use tabs where possible #674: FILE: drivers/common/mlx5/mlx5_prm.h:3407: + struct mlx5_ifc_general_obj_in_cmd_hdr_bits hdr;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #674: FILE: drivers/common/mlx5/mlx5_prm.h:3407: + struct mlx5_ifc_general_obj_in_cmd_hdr_bits hdr;$ ERROR:CODE_INDENT: code indent should use tabs where possible #675: FILE: drivers/common/mlx5/mlx5_prm.h:3408: + struct mlx5_ifc_header_modify_pattern_in_bits pattern;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #675: FILE: drivers/common/mlx5/mlx5_prm.h:3408: + struct mlx5_ifc_header_modify_pattern_in_bits pattern;$ WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #708: FILE: drivers/common/mlx5/mlx5_prm.h:4643: + u8 lag_master_next_table_id[0x18]; WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return #1315: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:419: + return rte_errno; + break; WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1655: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:759: + capability.cmd_hca_cap.log_header_modify_argument_granularity_offset); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'capability.cmd_hca_cap_2.format_select_dw_8_6_ext' #1680: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:784: + capability.cmd_hca_cap_2. + format_select_dw_8_6_ext); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'capability.cmd_hca_cap_2.format_select_dw_gtpu_dw_0' #1684: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:788: + capability.cmd_hca_cap_2. + format_select_dw_gtpu_dw_0); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'capability.cmd_hca_cap_2.format_select_dw_gtpu_dw_1' #1688: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:792: + capability.cmd_hca_cap_2. + format_select_dw_gtpu_dw_1); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'capability.cmd_hca_cap_2.format_select_dw_gtpu_dw_2' #1692: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:796: + capability.cmd_hca_cap_2. + format_select_dw_gtpu_dw_2); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'capability.cmd_hca_cap_2.format_select_dw_gtpu_first_ext_dw_0' #1696: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:800: + capability.cmd_hca_cap_2. + format_select_dw_gtpu_first_ext_dw_0); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'capability.flow_table_nic_cap.flow_table_properties_nic_receive.max_ft_level' #1711: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:815: + capability.flow_table_nic_cap. + flow_table_properties_nic_receive.max_ft_level); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'capability.flow_table_nic_cap.flow_table_properties_nic_receive.reparse' #1715: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:819: + capability.flow_table_nic_cap. + flow_table_properties_nic_receive.reparse); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'capability.wqe_based_flow_table_cap.rtc_reparse_mode' #1731: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:835: + capability.wqe_based_flow_table_cap. + rtc_reparse_mode); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'capability.wqe_based_flow_table_cap.ste_format' #1735: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:839: + capability.wqe_based_flow_table_cap. + ste_format); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'capability.wqe_based_flow_table_cap.rtc_index_mode' #1739: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:843: + capability.wqe_based_flow_table_cap. + rtc_index_mode); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'capability.wqe_based_flow_table_cap.rtc_log_depth_max' #1743: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:847: + capability.wqe_based_flow_table_cap. + rtc_log_depth_max); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'capability.wqe_based_flow_table_cap.ste_alloc_log_max' #1747: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:851: + capability.wqe_based_flow_table_cap. + ste_alloc_log_max); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'capability.wqe_based_flow_table_cap.ste_alloc_log_granularity' #1751: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:855: + capability.wqe_based_flow_table_cap. + ste_alloc_log_granularity); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'capability.wqe_based_flow_table_cap.trivial_match_definer' #1755: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:859: + capability.wqe_based_flow_table_cap. + trivial_match_definer); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'capability.wqe_based_flow_table_cap.stc_alloc_log_max' #1759: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:863: + capability.wqe_based_flow_table_cap. + stc_alloc_log_max); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'capability.wqe_based_flow_table_cap.stc_alloc_log_granularity' #1763: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:867: + capability.wqe_based_flow_table_cap. + stc_alloc_log_granularity); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'capability.flow_table_nic_cap.flow_table_properties_nic_receive.max_ft_level' #1780: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:884: + capability.flow_table_nic_cap. + flow_table_properties_nic_receive.max_ft_level); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'capability.flow_table_nic_cap.flow_table_properties_nic_receive.reparse' #1784: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:888: + capability.flow_table_nic_cap. + flow_table_properties_nic_receive.reparse); ERROR:C99_COMMENTS: do not use C99 // comments #1803: FILE: drivers/net/mlx5/hws/mlx5dr_cmd.c:907: + // TODO Current FW don't set this bit (yet) total: 7 errors, 27 warnings, 0 checks, 1923 lines checked