From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Alex Vesker <valex@nvidia.com>
Subject: |WARNING| pw118210 [v3 09/18] net/mlx5/hws: Add HWS pool and buddy
Date: Fri, 14 Oct 2022 13:53:51 +0200 (CEST) [thread overview]
Message-ID: <20221014115351.2ABA3120778@dpdk.org> (raw)
In-Reply-To: <20221014114833.13389-10-valex@nvidia.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/118210
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#213: FILE: drivers/net/mlx5/hws/mlx5dr_buddy.c:67:
+ DR_LOG(ERR, "Unexpected bit (%d < %"PRIx64") from bitmap", pos, n);
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#213: FILE: drivers/net/mlx5/hws/mlx5dr_buddy.c:67:
+ DR_LOG(ERR, "Unexpected bit (%d < %"PRIx64") from bitmap", pos, n);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#291: FILE: drivers/net/mlx5/hws/mlx5dr_buddy.c:145:
+ for (i = 0; i <= (int)buddy->max_order; ++i) {
+ rte_free(buddy->bits[i]);
+ }
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#498: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:117:
+ return ENOMEM;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#749: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:368:
+ return ENOMEM;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#771: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:390:
+ return ENOMEM;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#779: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:398:
+ return ENOMEM;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#802: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:421:
+ return ENOMEM;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#806: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:425:
+ return ENOMEM;
WARNING:TYPO_SPELLING: 'elemnt' may be misspelled - perhaps 'element'?
#850: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:469:
+ DR_LOG(ERR, "No mem for general elemnt_manager");
WARNING:TYPO_SPELLING: 'elemnt' may be misspelled - perhaps 'element'?
#940: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:559:
+ DR_LOG(ERR, "No mem for general elemnt_manager");
total: 0 errors, 9 warnings, 2 checks, 1047 lines checked
parent reply other threads:[~2022-10-14 11:53 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20221014114833.13389-10-valex@nvidia.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014115351.2ABA3120778@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=valex@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).