* |WARNING| pw118986 [PATCH] [v2] net/iavf: fix handling of IPsec events
@ 2022-10-24 16:48 dpdklab
0 siblings, 0 replies; 2+ messages in thread
From: dpdklab @ 2022-10-24 16:48 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
[-- Attachment #1: Type: text/plain, Size: 2837 bytes --]
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/118986
_apply patch failure_
Submitter: Radu Nicolau <radu.nicolau@intel.com>
Date: Monday, October 24 2022 11:34:47
Applied on: CommitID:269f027453ae7a9ac1bf0d6786388f598a139314
Apply patch set 118986 failed:
Checking patch drivers/net/iavf/iavf_vchnl.c...
error: while searching for:
iavf_handle_pf_event_msg(dev, info.msg_buf,
info.msg_len);
} else {
/* check for inline IPsec events */
struct inline_ipsec_msg *imsg =
(struct inline_ipsec_msg *)info.msg_buf;
struct rte_eth_event_ipsec_desc desc;
if (msg_opc ==
VIRTCHNL_OP_INLINE_IPSEC_CRYPTO &&
imsg->ipsec_opcode ==
INLINE_IPSEC_OP_EVENT) {
struct virtchnl_ipsec_event *ev =
imsg->ipsec_data.event;
desc.subtype =
RTE_ETH_EVENT_IPSEC_UNKNOWN;
desc.metadata = ev->ipsec_event_data;
iavf_dev_event_post(dev, RTE_ETH_EVENT_IPSEC,
&desc, sizeof(desc));
return;
}
/* read message and it's expected one */
error: patch failed: drivers/net/iavf/iavf_vchnl.c:488
Applying patch drivers/net/iavf/iavf_vchnl.c with 1 reject...
Rejected hunk #1.
diff a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c (rejected hunks)
@@ -488,22 +488,32 @@ iavf_handle_virtchnl_msg(struct rte_eth_dev *dev)
iavf_handle_pf_event_msg(dev, info.msg_buf,
info.msg_len);
} else {
- /* check for inline IPsec events */
- struct inline_ipsec_msg *imsg =
- (struct inline_ipsec_msg *)info.msg_buf;
- struct rte_eth_event_ipsec_desc desc;
- if (msg_opc ==
- VIRTCHNL_OP_INLINE_IPSEC_CRYPTO &&
- imsg->ipsec_opcode ==
- INLINE_IPSEC_OP_EVENT) {
- struct virtchnl_ipsec_event *ev =
- imsg->ipsec_data.event;
- desc.subtype =
- RTE_ETH_EVENT_IPSEC_UNKNOWN;
- desc.metadata = ev->ipsec_event_data;
- iavf_dev_event_post(dev, RTE_ETH_EVENT_IPSEC,
- &desc, sizeof(desc));
- return;
+ /* check for unsolicited messages i.e. events */
+ if (info.msg_len > 0) {
+ switch (msg_opc) {
+ case VIRTCHNL_OP_INLINE_IPSEC_CRYPTO: {
+ struct inline_ipsec_msg *imsg =
+ (struct inline_ipsec_msg *)info.msg_buf;
+ if (imsg->ipsec_opcode
+ == INLINE_IPSEC_OP_EVENT) {
+ struct rte_eth_event_ipsec_desc desc;
+ struct virtchnl_ipsec_event *ev =
+ imsg->ipsec_data.event;
+ desc.subtype =
+ RTE_ETH_EVENT_IPSEC_UNKNOWN;
+ desc.metadata =
+ ev->ipsec_event_data;
+ iavf_dev_event_post(dev,
+ RTE_ETH_EVENT_IPSEC,
+ &desc, sizeof(desc));
+ continue;
+ }
+ }
+ break;
+ default:
+ break;
+ }
+
}
/* read message and it's expected one */
https://lab.dpdk.org/results/dashboard/patchsets/24147/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] 2+ messages in thread
* |WARNING| pw118986 [PATCH v2] net/iavf: fix handling of IPsec events
[not found] <20221024113447.4077048-1-radu.nicolau@intel.com>
@ 2022-10-24 11:35 ` checkpatch
0 siblings, 0 replies; 2+ messages in thread
From: checkpatch @ 2022-10-24 11:35 UTC (permalink / raw)
To: test-report; +Cc: Radu Nicolau
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/118986
_coding style issues_
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#109: FILE: drivers/net/iavf/iavf_vchnl.c:497:
+ if (imsg->ipsec_opcode
total: 0 errors, 1 warnings, 0 checks, 48 lines checked
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-24 16:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-24 16:48 |WARNING| pw118986 [PATCH] [v2] net/iavf: fix handling of IPsec events dpdklab
[not found] <20221024113447.4077048-1-radu.nicolau@intel.com>
2022-10-24 11:35 ` |WARNING| pw118986 [PATCH v2] " checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).