Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/122884

_apply patch failure_

Submitter: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Date: Thursday, February 02 2023 07:55:09 
Applied on: CommitID:5003661613fa7663347b7ea75f2560b8a6458a30
Apply patch set 122884 failed:

Checking patch drivers/common/cnxk/roc_sso.c...
error: while searching for:
	struct mbox *mbox;
	int rc;

	plt_spinlock_lock(&sso->mbox_lock);
	mbox = mbox_get(dev->mbox);
	req_rsp = (struct sso_hws_stats *)mbox_alloc_msg_sso_hws_get_stats(
		mbox);

error: patch failed: drivers/common/cnxk/roc_sso.c:327
error: while searching for:
	stats->arbitration = req_rsp->arbitration;
fail:
	mbox_put(mbox);
	plt_spinlock_unlock(&sso->mbox_lock);
	return rc;
}


error: patch failed: drivers/common/cnxk/roc_sso.c:354
error: while searching for:
	struct mbox *mbox;
	int rc;

	plt_spinlock_lock(&sso->mbox_lock);
	mbox = mbox_get(dev->mbox);
	req_rsp = (struct sso_grp_stats *)mbox_alloc_msg_sso_grp_get_stats(
		mbox);

error: patch failed: drivers/common/cnxk/roc_sso.c:368
error: while searching for:

fail:
	mbox_put(mbox);
	plt_spinlock_unlock(&sso->mbox_lock);
	return rc;
}


error: patch failed: drivers/common/cnxk/roc_sso.c:403
error: while searching for:
	struct mbox *mbox;
	int i, rc;

	plt_spinlock_lock(&sso->mbox_lock);
	mbox = mbox_get(dev->mbox);
	for (i = 0; i < nb_qos; i++) {
		uint8_t iaq_prcnt = qos[i].iaq_prcnt;

error: patch failed: drivers/common/cnxk/roc_sso.c:427
error: while searching for:
		rc = -EIO;
fail:
	mbox_put(mbox);
	plt_spinlock_unlock(&sso->mbox_lock);
	return rc;
}


error: patch failed: drivers/common/cnxk/roc_sso.c:461
Hunk #7 succeeded at 517 (offset -39 lines).
Hunk #8 succeeded at 553 (offset -39 lines).
Hunk #9 succeeded at 584 (offset -45 lines).
Hunk #10 succeeded at 611 (offset -54 lines).
error: while searching for:
	struct mbox *mbox;
	int rc = -ENOSPC;

	plt_spinlock_lock(&sso->mbox_lock);
	mbox = mbox_get(dev->mbox);
	req = mbox_alloc_msg_sso_grp_set_priority(mbox);
	if (req == NULL)

error: patch failed: drivers/common/cnxk/roc_sso.c:693
error: while searching for:
		goto fail;
	}
	mbox_put(mbox);
	plt_spinlock_unlock(&sso->mbox_lock);
	plt_sso_dbg("HWGRP %d weight %d affinity %d priority %d", hwgrp, weight,
		    affinity, priority);

	return 0;
fail:
	mbox_put(mbox);
	plt_spinlock_unlock(&sso->mbox_lock);
	return rc;
}


error: patch failed: drivers/common/cnxk/roc_sso.c:709
Hunk #13 succeeded at 706 (offset -9 lines).
Hunk #14 succeeded at 772 (offset 15 lines).
Hunk #15 succeeded at 785 (offset 15 lines).
Hunk #16 succeeded at 806 (offset 15 lines).
error: while searching for:
	sso = roc_sso_to_sso_priv(roc_sso);
	memset(sso, 0, sizeof(*sso));
	pci_dev = roc_sso->pci_dev;
	plt_spinlock_init(&sso->mbox_lock);

	rc = dev_init(&sso->dev, pci_dev);
	if (rc < 0) {

error: patch failed: drivers/common/cnxk/roc_sso.c:830
Hunk #18 succeeded at 838 (offset 22 lines).
Hunk #19 succeeded at 879 (offset 22 lines).
Hunk #20 succeeded at 886 (offset 22 lines).
Checking patch drivers/common/cnxk/roc_sso_priv.h...
Applying patch drivers/common/cnxk/roc_sso.c with 9 rejects...
Rejected hunk #1.
Rejected hunk #2.
Rejected hunk #3.
Rejected hunk #4.
Rejected hunk #5.
Rejected hunk #6.
Hunk #7 applied cleanly.
Hunk #8 applied cleanly.
Hunk #9 applied cleanly.
Hunk #10 applied cleanly.
Rejected hunk #11.
Rejected hunk #12.
Hunk #13 applied cleanly.
Hunk #14 applied cleanly.
Hunk #15 applied cleanly.
Hunk #16 applied cleanly.
Rejected hunk #17.
Hunk #18 applied cleanly.
Hunk #19 applied cleanly.
Hunk #20 applied cleanly.
Applied patch drivers/common/cnxk/roc_sso_priv.h cleanly.
diff a/drivers/common/cnxk/roc_sso.c b/drivers/common/cnxk/roc_sso.c	(rejected hunks)
@@ -327,7 +327,6 @@ roc_sso_hws_stats_get(struct roc_sso *roc_sso, uint8_t hws,
 	struct mbox *mbox;
 	int rc;

-	plt_spinlock_lock(&sso->mbox_lock);
 	mbox = mbox_get(dev->mbox);
 	req_rsp = (struct sso_hws_stats *)mbox_alloc_msg_sso_hws_get_stats(
 		mbox);
@@ -354,7 +353,6 @@ roc_sso_hws_stats_get(struct roc_sso *roc_sso, uint8_t hws,
 	stats->arbitration = req_rsp->arbitration;
 fail:
 	mbox_put(mbox);
-	plt_spinlock_unlock(&sso->mbox_lock);
 	return rc;
 }

@@ -368,7 +366,6 @@ roc_sso_hwgrp_stats_get(struct roc_sso *roc_sso, uint8_t hwgrp,
 	struct mbox *mbox;
 	int rc;

-	plt_spinlock_lock(&sso->mbox_lock);
 	mbox = mbox_get(dev->mbox);
 	req_rsp = (struct sso_grp_stats *)mbox_alloc_msg_sso_grp_get_stats(
 		mbox);
@@ -403,7 +400,6 @@ roc_sso_hwgrp_stats_get(struct roc_sso *roc_sso, uint8_t hwgrp,

 fail:
 	mbox_put(mbox);
-	plt_spinlock_unlock(&sso->mbox_lock);
 	return rc;
 }

@@ -427,7 +423,6 @@ roc_sso_hwgrp_qos_config(struct roc_sso *roc_sso, struct roc_sso_hwgrp_qos *qos,
 	struct mbox *mbox;
 	int i, rc;

-	plt_spinlock_lock(&sso->mbox_lock);
 	mbox = mbox_get(dev->mbox);
 	for (i = 0; i < nb_qos; i++) {
 		uint8_t iaq_prcnt = qos[i].iaq_prcnt;
@@ -461,7 +456,6 @@ roc_sso_hwgrp_qos_config(struct roc_sso *roc_sso, struct roc_sso_hwgrp_qos *qos,
 		rc = -EIO;
 fail:
 	mbox_put(mbox);
-	plt_spinlock_unlock(&sso->mbox_lock);
 	return rc;
 }

@@ -693,7 +679,6 @@ roc_sso_hwgrp_set_priority(struct roc_sso *roc_sso, uint16_t hwgrp,
 	struct mbox *mbox;
 	int rc = -ENOSPC;

-	plt_spinlock_lock(&sso->mbox_lock);
 	mbox = mbox_get(dev->mbox);
 	req = mbox_alloc_msg_sso_grp_set_priority(mbox);
 	if (req == NULL)
@@ -709,14 +694,12 @@ roc_sso_hwgrp_set_priority(struct roc_sso *roc_sso, uint16_t hwgrp,
 		goto fail;
 	}
 	mbox_put(mbox);
-	plt_spinlock_unlock(&sso->mbox_lock);
 	plt_sso_dbg("HWGRP %d weight %d affinity %d priority %d", hwgrp, weight,
 		    affinity, priority);

 	return 0;
 fail:
 	mbox_put(mbox);
-	plt_spinlock_unlock(&sso->mbox_lock);
 	return rc;
 }

@@ -830,7 +809,6 @@ roc_sso_dev_init(struct roc_sso *roc_sso)
 	sso = roc_sso_to_sso_priv(roc_sso);
 	memset(sso, 0, sizeof(*sso));
 	pci_dev = roc_sso->pci_dev;
-	plt_spinlock_init(&sso->mbox_lock);

 	rc = dev_init(&sso->dev, pci_dev);
 	if (rc < 0) {

https://lab.dpdk.org/results/dashboard/patchsets/25161/

UNH-IOL DPDK Community Lab