From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@amd.com>
Subject: |WARNING| pw123044 [PATCH v7 3/7] ethdev: use VXLAN protocol struct for flow matching
Date: Fri, 3 Feb 2023 17:50:37 +0100 (CET) [thread overview]
Message-ID: <20230203165037.D06F7121E50@dpdk.org> (raw)
In-Reply-To: <20230203164854.602595-4-ferruh.yigit@amd.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/123044
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_spec->hdr.rsvd0[0] != 0'
#307: FILE: drivers/net/bnxt/bnxt_flow.c:566:
+ if ((vxlan_spec->hdr.rsvd0[0] != 0) ||
+ (vxlan_spec->hdr.rsvd0[1] != 0) ||
+ (vxlan_spec->hdr.rsvd0[2] != 0) ||
+ (vxlan_spec->hdr.rsvd1 != 0) ||
+ (vxlan_spec->hdr.flags != 8)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_spec->hdr.rsvd0[1] != 0'
#307: FILE: drivers/net/bnxt/bnxt_flow.c:566:
+ if ((vxlan_spec->hdr.rsvd0[0] != 0) ||
+ (vxlan_spec->hdr.rsvd0[1] != 0) ||
+ (vxlan_spec->hdr.rsvd0[2] != 0) ||
+ (vxlan_spec->hdr.rsvd1 != 0) ||
+ (vxlan_spec->hdr.flags != 8)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_spec->hdr.rsvd0[2] != 0'
#307: FILE: drivers/net/bnxt/bnxt_flow.c:566:
+ if ((vxlan_spec->hdr.rsvd0[0] != 0) ||
+ (vxlan_spec->hdr.rsvd0[1] != 0) ||
+ (vxlan_spec->hdr.rsvd0[2] != 0) ||
+ (vxlan_spec->hdr.rsvd1 != 0) ||
+ (vxlan_spec->hdr.flags != 8)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_spec->hdr.rsvd1 != 0'
#307: FILE: drivers/net/bnxt/bnxt_flow.c:566:
+ if ((vxlan_spec->hdr.rsvd0[0] != 0) ||
+ (vxlan_spec->hdr.rsvd0[1] != 0) ||
+ (vxlan_spec->hdr.rsvd0[2] != 0) ||
+ (vxlan_spec->hdr.rsvd1 != 0) ||
+ (vxlan_spec->hdr.flags != 8)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_spec->hdr.flags != 8'
#307: FILE: drivers/net/bnxt/bnxt_flow.c:566:
+ if ((vxlan_spec->hdr.rsvd0[0] != 0) ||
+ (vxlan_spec->hdr.rsvd0[1] != 0) ||
+ (vxlan_spec->hdr.rsvd0[2] != 0) ||
+ (vxlan_spec->hdr.rsvd1 != 0) ||
+ (vxlan_spec->hdr.flags != 8)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_mask->hdr.vni[0] != 0xFF'
#544: FILE: drivers/net/ixgbe/ixgbe_flow.c:2492:
+ if ((vxlan_mask->hdr.vni[0] || vxlan_mask->hdr.vni[1] ||
+ vxlan_mask->hdr.vni[2]) &&
+ ((vxlan_mask->hdr.vni[0] != 0xFF) ||
+ (vxlan_mask->hdr.vni[1] != 0xFF) ||
+ (vxlan_mask->hdr.vni[2] != 0xFF))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_mask->hdr.vni[1] != 0xFF'
#544: FILE: drivers/net/ixgbe/ixgbe_flow.c:2492:
+ if ((vxlan_mask->hdr.vni[0] || vxlan_mask->hdr.vni[1] ||
+ vxlan_mask->hdr.vni[2]) &&
+ ((vxlan_mask->hdr.vni[0] != 0xFF) ||
+ (vxlan_mask->hdr.vni[1] != 0xFF) ||
+ (vxlan_mask->hdr.vni[2] != 0xFF))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_mask->hdr.vni[2] != 0xFF'
#544: FILE: drivers/net/ixgbe/ixgbe_flow.c:2492:
+ if ((vxlan_mask->hdr.vni[0] || vxlan_mask->hdr.vni[1] ||
+ vxlan_mask->hdr.vni[2]) &&
+ ((vxlan_mask->hdr.vni[0] != 0xFF) ||
+ (vxlan_mask->hdr.vni[1] != 0xFF) ||
+ (vxlan_mask->hdr.vni[2] != 0xFF))) {
total: 0 errors, 0 warnings, 568 lines checked
parent reply other threads:[~2023-02-03 16:50 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230203164854.602595-4-ferruh.yigit@amd.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203165037.D06F7121E50@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).