From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id F0DD141BBE
	for <public@inbox.dpdk.org>; Fri,  3 Feb 2023 17:50:39 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E9B1342D1D;
	Fri,  3 Feb 2023 17:50:39 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id D34384067B
 for <test-report@dpdk.org>; Fri,  3 Feb 2023 17:50:37 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id D06F7121E50; Fri,  3 Feb 2023 17:50:37 +0100 (CET)
Subject: |WARNING| pw123044 [PATCH v7 3/7] ethdev: use VXLAN protocol struct
 for flow matching
In-Reply-To: <20230203164854.602595-4-ferruh.yigit@amd.com>
References: <20230203164854.602595-4-ferruh.yigit@amd.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@amd.com>
Message-Id: <20230203165037.D06F7121E50@dpdk.org>
Date: Fri,  3 Feb 2023 17:50:37 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/123044

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_spec->hdr.rsvd0[0] != 0'
#307: FILE: drivers/net/bnxt/bnxt_flow.c:566:
+			if ((vxlan_spec->hdr.rsvd0[0] != 0) ||
+			    (vxlan_spec->hdr.rsvd0[1] != 0) ||
+			    (vxlan_spec->hdr.rsvd0[2] != 0) ||
+			    (vxlan_spec->hdr.rsvd1 != 0) ||
+			    (vxlan_spec->hdr.flags != 8)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_spec->hdr.rsvd0[1] != 0'
#307: FILE: drivers/net/bnxt/bnxt_flow.c:566:
+			if ((vxlan_spec->hdr.rsvd0[0] != 0) ||
+			    (vxlan_spec->hdr.rsvd0[1] != 0) ||
+			    (vxlan_spec->hdr.rsvd0[2] != 0) ||
+			    (vxlan_spec->hdr.rsvd1 != 0) ||
+			    (vxlan_spec->hdr.flags != 8)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_spec->hdr.rsvd0[2] != 0'
#307: FILE: drivers/net/bnxt/bnxt_flow.c:566:
+			if ((vxlan_spec->hdr.rsvd0[0] != 0) ||
+			    (vxlan_spec->hdr.rsvd0[1] != 0) ||
+			    (vxlan_spec->hdr.rsvd0[2] != 0) ||
+			    (vxlan_spec->hdr.rsvd1 != 0) ||
+			    (vxlan_spec->hdr.flags != 8)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_spec->hdr.rsvd1 != 0'
#307: FILE: drivers/net/bnxt/bnxt_flow.c:566:
+			if ((vxlan_spec->hdr.rsvd0[0] != 0) ||
+			    (vxlan_spec->hdr.rsvd0[1] != 0) ||
+			    (vxlan_spec->hdr.rsvd0[2] != 0) ||
+			    (vxlan_spec->hdr.rsvd1 != 0) ||
+			    (vxlan_spec->hdr.flags != 8)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_spec->hdr.flags != 8'
#307: FILE: drivers/net/bnxt/bnxt_flow.c:566:
+			if ((vxlan_spec->hdr.rsvd0[0] != 0) ||
+			    (vxlan_spec->hdr.rsvd0[1] != 0) ||
+			    (vxlan_spec->hdr.rsvd0[2] != 0) ||
+			    (vxlan_spec->hdr.rsvd1 != 0) ||
+			    (vxlan_spec->hdr.flags != 8)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_mask->hdr.vni[0] != 0xFF'
#544: FILE: drivers/net/ixgbe/ixgbe_flow.c:2492:
+		if ((vxlan_mask->hdr.vni[0] || vxlan_mask->hdr.vni[1] ||
+			vxlan_mask->hdr.vni[2]) &&
+			((vxlan_mask->hdr.vni[0] != 0xFF) ||
+			(vxlan_mask->hdr.vni[1] != 0xFF) ||
+				(vxlan_mask->hdr.vni[2] != 0xFF))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_mask->hdr.vni[1] != 0xFF'
#544: FILE: drivers/net/ixgbe/ixgbe_flow.c:2492:
+		if ((vxlan_mask->hdr.vni[0] || vxlan_mask->hdr.vni[1] ||
+			vxlan_mask->hdr.vni[2]) &&
+			((vxlan_mask->hdr.vni[0] != 0xFF) ||
+			(vxlan_mask->hdr.vni[1] != 0xFF) ||
+				(vxlan_mask->hdr.vni[2] != 0xFF))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_mask->hdr.vni[2] != 0xFF'
#544: FILE: drivers/net/ixgbe/ixgbe_flow.c:2492:
+		if ((vxlan_mask->hdr.vni[0] || vxlan_mask->hdr.vni[1] ||
+			vxlan_mask->hdr.vni[2]) &&
+			((vxlan_mask->hdr.vni[0] != 0xFF) ||
+			(vxlan_mask->hdr.vni[1] != 0xFF) ||
+				(vxlan_mask->hdr.vni[2] != 0xFF))) {

total: 0 errors, 0 warnings, 568 lines checked