From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 234D241DCB
	for <public@inbox.dpdk.org>; Sat,  4 Mar 2023 04:06:39 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1C4F2400D7;
	Sat,  4 Mar 2023 04:06:39 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 6FE74400D7
 for <test-report@dpdk.org>; Sat,  4 Mar 2023 04:06:37 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 5766D120D89; Sat,  4 Mar 2023 04:06:37 +0100 (CET)
Subject: |WARNING| pw124801 [PATCH] log: add timestamp for log
In-Reply-To: <20230304030437.706-1-luzhipeng@cestc.cn>
References: <20230304030437.706-1-luzhipeng@cestc.cn>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: luzhipeng <luzhipeng@cestc.cn>
Message-Id: <20230304030637.5766D120D89@dpdk.org>
Date: Sat,  4 Mar 2023 04:06:37 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/124801

_coding style issues_


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#83: FILE: lib/eal/common/eal_common_log.c:487:
+    struct tm *info;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#84: FILE: lib/eal/common/eal_common_log.c:488:
+    char date[24];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#85: FILE: lib/eal/common/eal_common_log.c:489:
+    struct timespec ts;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#86: FILE: lib/eal/common/eal_common_log.c:490:
+    long usec;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#88: FILE: lib/eal/common/eal_common_log.c:492:
+    clock_gettime(CLOCK_REALTIME, &ts);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#89: FILE: lib/eal/common/eal_common_log.c:493:
+    info = localtime(&ts.tv_sec);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#90: FILE: lib/eal/common/eal_common_log.c:494:
+    usec = ts.tv_nsec / 1000;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#91: FILE: lib/eal/common/eal_common_log.c:495:
+    if (info == NULL) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#92: FILE: lib/eal/common/eal_common_log.c:496:
+        snprintf(buf, buf_size, "[%s.%06ld] ", "unknown date", usec);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#92: FILE: lib/eal/common/eal_common_log.c:496:
+        snprintf(buf, buf_size, "[%s.%06ld] ", "unknown date", usec);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#93: FILE: lib/eal/common/eal_common_log.c:497:
+        return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#93: FILE: lib/eal/common/eal_common_log.c:497:
+        return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#94: FILE: lib/eal/common/eal_common_log.c:498:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#96: FILE: lib/eal/common/eal_common_log.c:500:
+    strftime(date, sizeof(date), "%Y-%m-%d %H:%M:%S", info);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#97: FILE: lib/eal/common/eal_common_log.c:501:
+    snprintf(buf, buf_size, "[%s.%06ld] ", date, usec);$

ERROR:SPACING: space required after that ',' (ctx:VxV)
#117: FILE: lib/eal/common/eal_common_log.c:524:
+	fprintf(f,"%s ",timestamp);
 	         ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#117: FILE: lib/eal/common/eal_common_log.c:524:
+	fprintf(f,"%s ",timestamp);
 	               ^

total: 4 errors, 13 warnings, 43 lines checked
zhipeng Lu <luzhipeng@cestc.cn> is unknown, please fix the commit message or update .mailmap.
zhipeng Lu <luzhipeng@cestc.cn> is unknown, please fix the commit message or update .mailmap.