From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Subject: |WARNING| pw124873 [PATCH] [v3] net/mlx5: use just sufficient barrier for ARM platforms
Date: Sat, 11 Mar 2023 09:39:00 +0000 (UTC) [thread overview]
Message-ID: <20230311093900.420366011D@dpdk-ubuntu.dpdklab.iol.unh.edu> (raw)
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/124873
_apply patch failure_
Submitter: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Date: Thursday, March 09 2023 02:32:47
Applied on: CommitID:b15d75b2872efce397d827dac78692a919358302
Apply patch set 124873 failed:
Checking patch drivers/common/mlx5/mlx5_common.h...
error: while searching for:
if (unlikely((op_owner != (!!(idx))) || (op_code == MLX5_CQE_INVALID)))
return MLX5_CQE_STATUS_HW_OWN;
rte_io_rmb();
if (unlikely(op_code == MLX5_CQE_RESP_ERR ||
op_code == MLX5_CQE_REQ_ERR))
return MLX5_CQE_STATUS_ERR;
error: patch failed: drivers/common/mlx5/mlx5_common.h:203
Applying patch drivers/common/mlx5/mlx5_common.h with 1 reject...
Rejected hunk #1.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h (rejected hunks)
@@ -203,7 +203,11 @@ check_cqe(volatile struct mlx5_cqe *cqe, const uint16_t cqes_n,
if (unlikely((op_owner != (!!(idx))) || (op_code == MLX5_CQE_INVALID)))
return MLX5_CQE_STATUS_HW_OWN;
- rte_io_rmb();
+ /* Prevent speculative reading of other fields in CQE until
+ * CQE is valid.
+ */
+ rte_atomic_thread_fence(__ATOMIC_ACQUIRE);
+
if (unlikely(op_code == MLX5_CQE_RESP_ERR ||
op_code == MLX5_CQE_REQ_ERR))
return MLX5_CQE_STATUS_ERR;
https://lab.dpdk.org/results/dashboard/patchsets/25649/
UNH-IOL DPDK Community Lab
next reply other threads:[~2023-03-11 9:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 9:39 dpdklab [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-11 8:51 dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230311093900.420366011D@dpdk-ubuntu.dpdklab.iol.unh.edu \
--to=dpdklab@iol.unh.edu \
--cc=dpdk-test-reports@iol.unh.edu \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).