From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1658342B71 for ; Mon, 22 May 2023 15:22:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 119FA40EE5; Mon, 22 May 2023 15:22:24 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id E05EC40EE5 for ; Mon, 22 May 2023 15:22:22 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id D6345120927; Mon, 22 May 2023 15:22:22 +0200 (CEST) Subject: |WARNING| pw127175 [PATCH v2 5/5] net/hns3: add Tx/Rx descriptor logs In-Reply-To: <20230522131740.30043-6-liudongdong3@huawei.com> References: <20230522131740.30043-6-liudongdong3@huawei.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Dongdong Liu Message-Id: <20230522132222.D6345120927@dpdk.org> Date: Mon, 22 May 2023 15:22:22 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/127175 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'rxdp' - possible side-effects? #149: FILE: drivers/net/hns3/hns3_rxtx.h:556: +#define RX_BD_LOG(hw, level, rxdp) \ + PMD_RX_LOG(hw, level, "Rx descriptor: " \ + "l234_info=%#x pkt_len=%u size=%u rss_hash=%#x fd_id=%u vlan_tag=%u " \ + "o_dm_vlan_id_fb=%#x ot_vlan_tag=%u bd_base_info=%#x", \ + rte_le_to_cpu_32((rxdp)->rx.l234_info), \ + rte_le_to_cpu_16((rxdp)->rx.pkt_len), \ + rte_le_to_cpu_16((rxdp)->rx.size), \ + rte_le_to_cpu_32((rxdp)->rx.rss_hash), \ + rte_le_to_cpu_16((rxdp)->rx.fd_id), \ + rte_le_to_cpu_16((rxdp)->rx.vlan_tag), \ + rte_le_to_cpu_16((rxdp)->rx.o_dm_vlan_id_fb), \ + rte_le_to_cpu_16((rxdp)->rx.ot_vlan_tag), \ + rte_le_to_cpu_32((rxdp)->rx.bd_base_info)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txdp' - possible side-effects? #163: FILE: drivers/net/hns3/hns3_rxtx.h:570: +#define TX_BD_LOG(hw, level, txdp) \ + PMD_TX_LOG(hw, level, "Tx descriptor: " \ + "vlan_tag=%u send_size=%u type_cs_vlan_tso_len=%#x outer_vlan_tag=%u " \ + "tv=%#x ol_type_vlan_len_msec=%#x paylen_fd_dop_ol4cs=%#x " \ + "tp_fe_sc_vld_ra_ri=%#x ckst_mss=%u", \ + rte_le_to_cpu_16((txdp)->tx.vlan_tag), \ + rte_le_to_cpu_16((txdp)->tx.send_size), \ + rte_le_to_cpu_32((txdp)->tx.type_cs_vlan_tso_len), \ + rte_le_to_cpu_16((txdp)->tx.outer_vlan_tag), \ + rte_le_to_cpu_16((txdp)->tx.tv), \ + rte_le_to_cpu_32((txdp)->tx.ol_type_vlan_len_msec), \ + rte_le_to_cpu_32((txdp)->tx.paylen_fd_dop_ol4cs), \ + rte_le_to_cpu_16((txdp)->tx.tp_fe_sc_vld_ra_ri), \ + rte_le_to_cpu_16((txdp)->tx.ckst_mss)) total: 0 errors, 0 warnings, 2 checks, 88 lines checked