From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96B6C42C0E for ; Fri, 2 Jun 2023 08:03:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6977040695; Fri, 2 Jun 2023 08:03:37 +0200 (CEST) Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mails.dpdk.org (Postfix) with ESMTP id B0EBC40695 for ; Fri, 2 Jun 2023 08:03:35 +0200 (CEST) Received: from loongson.cn (unknown [10.40.46.153]) by gateway (Coremail) with SMTP id _____8BxmPE1hnlkz4YDAA--.7712S3; Fri, 02 Jun 2023 14:03:33 +0800 (CST) Received: from localhost.localdomain (unknown [10.40.46.153]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Axmr00hnlkR22FAA--.18574S3; Fri, 02 Jun 2023 14:03:32 +0800 (CST) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by localhost.localdomain (8.15.2/8.15.2) with ESMTPS id 3525nTkf1870636 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 2 Jun 2023 13:49:29 +0800 Received: (from root@localhost) by localhost.localdomain (8.15.2/8.15.2/Submit) id 3525nTPZ1870635; Fri, 2 Jun 2023 13:49:29 +0800 Date: Fri, 2 Jun 2023 13:49:29 +0800 From: qemudev@loongson.cn Message-Id: <202306020549.3525nTPZ1870635@localhost.localdomain> Content-Type: text/plain; charset="utf-8" Subject: |WARNING| pw127946 [PATCH v3] gro : ipv6-gro review comments to reduce code duplication across v4 and v6 In-Reply-To: <20230602060215.23900-1-kumaraparamesh92@gmail.com> References: <20230602060215.23900-1-kumaraparamesh92@gmail.com> To: test-report@dpdk.org Cc: Kumara Parameshwaran , zhoumin@loongson.cn X-CM-TRANSID: AQAAf8Axmr00hnlkR22FAA--.18574S3 X-CM-SenderInfo: pthp3vthy6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBjvJXoWxuFykAw1Uury5WFW8uF4DJwb_yoW7Xr13pF 45K343WFs7Zry8Xrs3Jr4fCF15JryFya4rGr9rKws5tF9IgF17WFyFkry2kFyUKa43u39x uF42kFW8ZFW7JFUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj qI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUU b0AFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wA2ocxC64kIII0Yj41l84x0c7CEw4 AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26r1I6r4UM28EF7xvwVC0I7IYx2IY6xkF 7I0E14v26r4j6F4UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7 CjxVAFwI0_Gr1j6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYIkI8VC2 zVCFFI0UMc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VCjz48v1sIEY20_WwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lw4CEc2x0rVAKj4xxMxAIw28IcxkI7VAKI48JMxAIw28IcVCjz48v1sIE Y20_WwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E74 80Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jrv_JF1lIxkGc2Ij64vIr41lIxAIcVC0 I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04 k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7Cj xVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0zRhvtAUUUUU= X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: loongarch-compilation Test-Status: WARNING http://dpdk.org/patch/127946 _apply patch failure_ Submitter: Kumara Parameshwaran Date: Fri, 2 Jun 2023 11:32:15 +0530 DPDK git baseline: Repo:dpdk Branch: main CommitID: abaa473297cf21cb81e5348185a7694ae2f221e7 Apply patch set 127946 failed: /home/zhoumin/dpdk-ci/tools/../series/28316/127946.patch:192: trailing whitespace. int32_t /home/zhoumin/dpdk-ci/tools/../series/28316/127946.patch:193: trailing whitespace. gro_tcp_reassemble(struct rte_mbuf *pkt, /home/zhoumin/dpdk-ci/tools/../series/28316/127946.patch:194: trailing whitespace. void *tbl, /home/zhoumin/dpdk-ci/tools/../series/28316/127946.patch:195: trailing whitespace. void *key, /home/zhoumin/dpdk-ci/tools/../series/28316/127946.patch:219: trailing whitespace. sent_seq = rte_be_to_cpu_32(tcp_hdr->sent_seq); Checking patch lib/gro/gro_tcp.c... Checking patch lib/gro/gro_tcp.h... error: lib/gro/gro_tcp.h: No such file or directory Checking patch lib/gro/gro_tcp4.c... Hunk #1 succeeded at 71 (offset -1 lines). error: while searching for: } static inline uint32_t insert_new_item(struct gro_tcp4_tbl *tbl, struct rte_mbuf *pkt, uint64_t start_time, uint32_t prev_idx, uint32_t sent_seq, uint16_t ip_id, uint8_t is_atomic) { uint32_t item_idx; item_idx = find_an_empty_item(tbl); if (item_idx == INVALID_ARRAY_INDEX) return INVALID_ARRAY_INDEX; tbl->items[item_idx].firstseg = pkt; tbl->items[item_idx].lastseg = rte_pktmbuf_lastseg(pkt); tbl->items[item_idx].start_time = start_time; tbl->items[item_idx].next_pkt_idx = INVALID_ARRAY_INDEX; tbl->items[item_idx].sent_seq = sent_seq; tbl->items[item_idx].ip_id = ip_id; tbl->items[item_idx].nb_merged = 1; tbl->items[item_idx].is_atomic = is_atomic; tbl->item_num++; /* if the previous packet exists, chain them together. */ if (prev_idx != INVALID_ARRAY_INDEX) { tbl->items[item_idx].next_pkt_idx = tbl->items[prev_idx].next_pkt_idx; tbl->items[prev_idx].next_pkt_idx = item_idx; } return item_idx; } static inline uint32_t delete_item(struct gro_tcp4_tbl *tbl, uint32_t item_idx, uint32_t prev_item_idx) { uint32_t next_idx = tbl->items[item_idx].next_pkt_idx; /* NULL indicates an empty item */ tbl->items[item_idx].firstseg = NULL; tbl->item_num--; if (prev_item_idx != INVALID_ARRAY_INDEX) tbl->items[prev_item_idx].next_pkt_idx = next_idx; return next_idx; } static inline uint32_t insert_new_flow(struct gro_tcp4_tbl *tbl, struct tcp4_flow_key *src, uint32_t item_idx) { struct tcp4_flow_key *dst; uint32_t flow_idx; flow_idx = find_an_empty_flow(tbl); if (unlikely(flow_idx == INVALID_ARRAY_INDEX)) return INVALID_ARRAY_INDEX; dst = &(tbl->flows[flow_idx].key); rte_ether_addr_copy(&(src->eth_saddr), &(dst->eth_saddr)); rte_ether_addr_copy(&(src->eth_daddr), &(dst->eth_daddr)); dst->ip_src_addr = src->ip_src_addr; dst->ip_dst_addr = src->ip_dst_addr; dst->recv_ack = src->recv_ack; dst->src_port = src->src_port; dst->dst_port = src->dst_port; tbl->flows[flow_idx].start_index = item_idx; tbl->flow_num++; return flow_idx; } /* * update the packet length for the flushed packet. */ static inline void update_header(struct gro_tcp_item *item) { struct rte_ipv4_hdr *ipv4_hdr; struct rte_mbuf *pkt = item->firstseg; ipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) + pkt->l2_len); ipv4_hdr->total_length = rte_cpu_to_be_16(pkt->pkt_len - pkt->l2_len); } int32_t gro_tcp4_reassemble(struct rte_mbuf *pkt, struct gro_tcp4_tbl *tbl, error: patch failed: lib/gro/gro_tcp4.c:97 error: lib/gro/gro_tcp4.c: patch does not apply Checking patch lib/gro/gro_tcp4.h... error: while searching for: #ifndef _GRO_TCP4_H_ #define _GRO_TCP4_H_ #define INVALID_ARRAY_INDEX 0xffffffffUL #define GRO_TCP4_TBL_MAX_ITEM_NUM (1024UL * 1024UL) /* Header fields representing a TCP/IPv4 flow */ struct tcp4_flow_key { struct rte_ether_addr eth_saddr; struct rte_ether_addr eth_daddr; uint32_t ip_src_addr; uint32_t ip_dst_addr; uint32_t recv_ack; uint16_t src_port; uint16_t dst_port; }; struct gro_tcp4_flow { error: patch failed: lib/gro/gro_tcp4.h:5 error: lib/gro/gro_tcp4.h: patch does not apply Checking patch lib/gro/gro_tcp6.c... error: lib/gro/gro_tcp6.c: No such file or directory Checking patch lib/gro/gro_tcp6.h... error: lib/gro/gro_tcp6.h: No such file or directory Checking patch lib/gro/gro_vxlan_tcp4.c... Hunk #1 succeeded at 163 (offset -1 lines). Hunk #2 succeeded at 351 (offset -1 lines). Checking patch lib/gro/meson.build... error: while searching for: sources = files( 'rte_gro.c', 'gro_tcp4.c', 'gro_tcp6.c', 'gro_udp4.c', error: patch failed: lib/gro/meson.build:3 error: lib/gro/meson.build: patch does not apply