* |SUCCESS| pw128163 [PATCH] net/cnxk: add atomic fc check in poll mode Tx path [not found] <20230606061249.833290-1-rbhansali@marvell.com> @ 2023-06-06 6:02 ` qemudev 2023-06-06 6:06 ` qemudev 2023-06-06 6:13 ` |WARNING| " checkpatch 2 siblings, 0 replies; 3+ messages in thread From: qemudev @ 2023-06-06 6:02 UTC (permalink / raw) To: test-report Test-Label: loongarch-compilation Test-Status: SUCCESS http://dpdk.org/patch/128163 _Compilation OK_ Submitter: Rahul Bhansali <rbhansali@marvell.com> Date: Tue, 6 Jun 2023 11:42:49 +0530 DPDK git baseline: Repo:dpdk-next-net-mrvl Branch: for-next-net CommitID: acd91653e50b4cfaa9c0bd1e68b48d7c1cacd93f 128163 --> meson & ninja build successfully Test environment and result as below: +---------------------+----------------+ | Environment | compilation | +---------------------+----------------+ | Loongnix-Server 8.3 | PASS | +---------------------+----------------+ Loongnix-Server 8.3 Kernel: 4.19.190+ Compiler: gcc 8.3 ^ permalink raw reply [flat|nested] 3+ messages in thread
* |SUCCESS| pw128163 [PATCH] net/cnxk: add atomic fc check in poll mode Tx path [not found] <20230606061249.833290-1-rbhansali@marvell.com> 2023-06-06 6:02 ` |SUCCESS| pw128163 [PATCH] net/cnxk: add atomic fc check in poll mode Tx path qemudev @ 2023-06-06 6:06 ` qemudev 2023-06-06 6:13 ` |WARNING| " checkpatch 2 siblings, 0 replies; 3+ messages in thread From: qemudev @ 2023-06-06 6:06 UTC (permalink / raw) To: test-report Test-Label: loongarch-unit-testing Test-Status: SUCCESS http://dpdk.org/patch/128163 _Unit Testing PASS_ Submitter: Rahul Bhansali <rbhansali@marvell.com> Date: Tue, 6 Jun 2023 11:42:49 +0530 DPDK git baseline: Repo:dpdk-next-net-mrvl Branch: for-next-net CommitID: acd91653e50b4cfaa9c0bd1e68b48d7c1cacd93f 128163 --> testing pass Test environment and result as below: +---------------------+----------------+ | Environment | dpdk_unit_test | +---------------------+----------------+ | Loongnix-Server 8.3 | PASS | +---------------------+----------------+ Loongnix-Server 8.3 Kernel: 4.19.190+ Compiler: gcc 8.3 Test result details: 1/104 DPDK:fast-tests / acl_autotest OK 2.83s 2/104 DPDK:fast-tests / atomic_autotest OK 7.08s 3/104 DPDK:fast-tests / bitmap_autotest OK 0.07s 4/104 DPDK:fast-tests / bpf_autotest OK 0.07s 5/104 DPDK:fast-tests / bpf_convert_autotest OK 0.07s 6/104 DPDK:fast-tests / bitops_autotest OK 0.07s 7/104 DPDK:fast-tests / byteorder_autotest OK 0.07s 8/104 DPDK:fast-tests / cksum_autotest OK 0.07s 9/104 DPDK:fast-tests / cmdline_autotest OK 0.07s 10/104 DPDK:fast-tests / common_autotest OK 0.92s 11/104 DPDK:fast-tests / cpuflags_autotest OK 0.07s 12/104 DPDK:fast-tests / debug_autotest OK 0.67s 13/104 DPDK:fast-tests / devargs_autotest OK 0.07s 14/104 DPDK:fast-tests / eal_flags_c_opt_autotest OK 0.67s 15/104 DPDK:fast-tests / eal_flags_main_opt_autotest OK 0.22s 16/104 DPDK:fast-tests / eal_flags_n_opt_autotest OK 0.17s 17/104 DPDK:fast-tests / eal_flags_hpet_autotest OK 0.12s 18/104 DPDK:fast-tests / eal_flags_no_huge_autotest OK 0.22s 19/104 DPDK:fast-tests / eal_flags_a_opt_autotest OK 0.27s 20/104 DPDK:fast-tests / eal_flags_b_opt_autotest OK 0.22s 21/104 DPDK:fast-tests / eal_flags_vdev_opt_autotest OK 0.17s 22/104 DPDK:fast-tests / eal_flags_r_opt_autotest OK 0.17s 23/104 DPDK:fast-tests / eal_flags_mem_autotest OK 0.52s 24/104 DPDK:fast-tests / eal_flags_file_prefix_autotest OK 22.41s 25/104 DPDK:fast-tests / eal_flags_misc_autotest OK 0.77s 26/104 DPDK:fast-tests / eal_fs_autotest OK 0.07s 27/104 DPDK:fast-tests / errno_autotest OK 0.07s 28/104 DPDK:fast-tests / ethdev_link_status OK 0.07s 29/104 DPDK:fast-tests / event_ring_autotest OK 0.07s 30/104 DPDK:fast-tests / fib_autotest OK 0.87s 31/104 DPDK:fast-tests / fib6_autotest OK 0.92s 32/104 DPDK:fast-tests / func_reentrancy_autotest OK 2.13s 33/104 DPDK:fast-tests / hash_autotest OK 1.02s 34/104 DPDK:fast-tests / interrupt_autotest OK 1.37s 35/104 DPDK:fast-tests / ipfrag_autotest OK 0.07s 36/104 DPDK:fast-tests / lcores_autotest OK 5.12s 37/104 DPDK:fast-tests / logs_autotest OK 0.07s 38/104 DPDK:fast-tests / lpm_autotest OK 5.96s 39/104 DPDK:fast-tests / lpm6_autotest OK 8.92s 40/104 DPDK:fast-tests / malloc_autotest OK 62.20s 41/104 DPDK:fast-tests / mbuf_autotest OK 6.53s 42/104 DPDK:fast-tests / mcslock_autotest OK 4.27s 43/104 DPDK:fast-tests / memcpy_autotest OK 6.68s 44/104 DPDK:fast-tests / memory_autotest OK 0.12s 45/104 DPDK:fast-tests / mempool_autotest OK 0.47s 46/104 DPDK:fast-tests / memzone_autotest OK 0.17s 47/104 DPDK:fast-tests / meter_autotest OK 0.07s 48/104 DPDK:fast-tests / multiprocess_autotest OK 0.17s 49/104 DPDK:fast-tests / per_lcore_autotest OK 0.17s 50/104 DPDK:fast-tests / pflock_autotest OK 0.87s 51/104 DPDK:fast-tests / prefetch_autotest OK 0.07s 52/104 DPDK:fast-tests / rcu_qsbr_autotest OK 0.57s 53/104 DPDK:fast-tests / pie_autotest OK 0.07s 54/104 DPDK:fast-tests / rib_autotest OK 10.30s 55/104 DPDK:fast-tests / rib6_autotest OK 10.30s 56/104 DPDK:fast-tests / ring_autotest OK 0.12s 57/104 DPDK:fast-tests / rwlock_test1_autotest OK 0.82s 58/104 DPDK:fast-tests / rwlock_rda_autotest OK 5.07s 59/104 DPDK:fast-tests / rwlock_rds_wrm_autotest OK 5.07s 60/104 DPDK:fast-tests / rwlock_rde_wro_autotest OK 5.07s 61/104 DPDK:fast-tests / sched_autotest OK 0.07s 62/104 DPDK:fast-tests / security_autotest OK 0.07s 63/104 DPDK:fast-tests / seqlock_autotest OK 2.07s 64/104 DPDK:fast-tests / spinlock_autotest OK 0.17s 65/104 DPDK:fast-tests / stack_autotest OK 0.87s 66/104 DPDK:fast-tests / stack_lf_autotest SKIP 0.07s exit status 77 67/104 DPDK:fast-tests / string_autotest OK 0.07s 68/104 DPDK:fast-tests / tailq_autotest OK 0.07s 69/104 DPDK:fast-tests / ticketlock_autotest OK 0.22s 70/104 DPDK:fast-tests / timer_autotest OK 3.97s 71/104 DPDK:fast-tests / user_delay_us OK 0.07s 72/104 DPDK:fast-tests / version_autotest OK 0.07s 73/104 DPDK:fast-tests / crc_autotest OK 0.07s 74/104 DPDK:fast-tests / distributor_autotest OK 1.22s 75/104 DPDK:fast-tests / eventdev_common_autotest OK 0.07s 76/104 DPDK:fast-tests / fbarray_autotest OK 0.07s 77/104 DPDK:fast-tests / hash_readwrite_func_autotest OK 6.44s 78/104 DPDK:fast-tests / ipsec_autotest SKIP 0.07s exit status 77 79/104 DPDK:fast-tests / kni_autotest SKIP 0.07s exit status 77 80/104 DPDK:fast-tests / kvargs_autotest OK 0.07s 81/104 DPDK:fast-tests / member_autotest OK 1.22s 82/104 DPDK:fast-tests / power_cpufreq_autotest SKIP 0.07s exit status 77 83/104 DPDK:fast-tests / power_autotest OK 0.07s 84/104 DPDK:fast-tests / power_kvm_vm_autotest SKIP 0.07s exit status 77 85/104 DPDK:fast-tests / power_intel_uncore_autotest SKIP 0.07s exit status 77 86/104 DPDK:fast-tests / reorder_autotest OK 0.12s 87/104 DPDK:fast-tests / service_autotest OK 3.02s 88/104 DPDK:fast-tests / thash_autotest OK 0.07s 89/104 DPDK:fast-tests / threads_autotest OK 0.27s 90/104 DPDK:fast-tests / trace_autotest OK 0.07s 91/104 DPDK:fast-tests / trace_autotest_with_traces OK 0.12s 92/104 DPDK:fast-tests / metrics_autotest OK 0.07s 93/104 DPDK:fast-tests / telemetry_json_autotest OK 0.07s 94/104 DPDK:fast-tests / telemetry_data_autotest OK 0.07s 95/104 DPDK:fast-tests / table_autotest OK 10.21s 96/104 DPDK:fast-tests / ring_pmd_autotest OK 0.07s 97/104 DPDK:fast-tests / event_eth_tx_adapter_autotest OK 1.47s 98/104 DPDK:fast-tests / bitratestats_autotest OK 0.07s 99/104 DPDK:fast-tests / latencystats_autotest OK 0.07s 100/104 DPDK:fast-tests / pdump_autotest OK 5.17s 101/104 DPDK:fast-tests / vdev_autotest OK 0.07s 102/104 DPDK:fast-tests / rawdev_autotest OK 0.07s 103/104 DPDK:fast-tests / compressdev_autotest SKIP 0.07s exit status 77 104/104 DPDK:fast-tests / telemetry_all OK 14.85s Ok: 97 Expected Fail: 0 Fail: 0 Unexpected Pass: 0 Skipped: 7 Timeout: 0 ^ permalink raw reply [flat|nested] 3+ messages in thread
* |WARNING| pw128163 [PATCH] net/cnxk: add atomic fc check in poll mode Tx path [not found] <20230606061249.833290-1-rbhansali@marvell.com> 2023-06-06 6:02 ` |SUCCESS| pw128163 [PATCH] net/cnxk: add atomic fc check in poll mode Tx path qemudev 2023-06-06 6:06 ` qemudev @ 2023-06-06 6:13 ` checkpatch 2 siblings, 0 replies; 3+ messages in thread From: checkpatch @ 2023-06-06 6:13 UTC (permalink / raw) To: test-report; +Cc: Rahul Bhansali Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/128163 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects? #119: FILE: drivers/net/cnxk/cn10k_tx.h:50: +#define NIX_XMIT_FC_OR_RETURN_MTS(txq, pkts) \ + do { \ + int64_t *fc_cache = &(txq)->fc_cache_pkts; \ + uint8_t retry_count = 8; \ + int64_t val, newval; \ + retry: \ + /* Reduce the cached count */ \ + val = (int64_t)__atomic_fetch_sub(fc_cache, pkts, __ATOMIC_RELAXED); \ + val -= pkts; \ + /* Cached value is low, Update the fc_cache_pkts */ \ + if (unlikely(val < 0)) { \ + /* Multiply with sqe_per_sqb to express in pkts */ \ + newval = txq->nb_sqb_bufs_adj - __atomic_load_n(txq->fc_mem, \ + __ATOMIC_RELAXED); \ + newval = (newval << (txq)->sqes_per_sqb_log2) - newval; \ + newval -= pkts; \ + if (!__atomic_compare_exchange_n(fc_cache, &val, newval, false, \ + __ATOMIC_RELAXED, __ATOMIC_RELAXED)) { \ + if (retry_count) { \ + retry_count--; \ + goto retry; \ + } else \ + return 0; \ + } \ + /* Update and check it again for the room */ \ + if (unlikely(newval < 0)) \ + return 0; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pkts' - possible side-effects? #119: FILE: drivers/net/cnxk/cn10k_tx.h:50: +#define NIX_XMIT_FC_OR_RETURN_MTS(txq, pkts) \ + do { \ + int64_t *fc_cache = &(txq)->fc_cache_pkts; \ + uint8_t retry_count = 8; \ + int64_t val, newval; \ + retry: \ + /* Reduce the cached count */ \ + val = (int64_t)__atomic_fetch_sub(fc_cache, pkts, __ATOMIC_RELAXED); \ + val -= pkts; \ + /* Cached value is low, Update the fc_cache_pkts */ \ + if (unlikely(val < 0)) { \ + /* Multiply with sqe_per_sqb to express in pkts */ \ + newval = txq->nb_sqb_bufs_adj - __atomic_load_n(txq->fc_mem, \ + __ATOMIC_RELAXED); \ + newval = (newval << (txq)->sqes_per_sqb_log2) - newval; \ + newval -= pkts; \ + if (!__atomic_compare_exchange_n(fc_cache, &val, newval, false, \ + __ATOMIC_RELAXED, __ATOMIC_RELAXED)) { \ + if (retry_count) { \ + retry_count--; \ + goto retry; \ + } else \ + return 0; \ + } \ + /* Update and check it again for the room */ \ + if (unlikely(newval < 0)) \ + return 0; \ + } \ + } while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #119: FILE: drivers/net/cnxk/cn10k_tx.h:50: +#define NIX_XMIT_FC_OR_RETURN_MTS(txq, pkts) \ + do { \ + int64_t *fc_cache = &(txq)->fc_cache_pkts; \ + uint8_t retry_count = 8; \ + int64_t val, newval; \ + retry: \ + /* Reduce the cached count */ \ + val = (int64_t)__atomic_fetch_sub(fc_cache, pkts, __ATOMIC_RELAXED); \ + val -= pkts; \ + /* Cached value is low, Update the fc_cache_pkts */ \ + if (unlikely(val < 0)) { \ + /* Multiply with sqe_per_sqb to express in pkts */ \ + newval = txq->nb_sqb_bufs_adj - __atomic_load_n(txq->fc_mem, \ + __ATOMIC_RELAXED); \ + newval = (newval << (txq)->sqes_per_sqb_log2) - newval; \ + newval -= pkts; \ + if (!__atomic_compare_exchange_n(fc_cache, &val, newval, false, \ + __ATOMIC_RELAXED, __ATOMIC_RELAXED)) { \ + if (retry_count) { \ + retry_count--; \ + goto retry; \ + } else \ + return 0; \ + } \ + /* Update and check it again for the room */ \ + if (unlikely(newval < 0)) \ + return 0; \ + } \ + } while (0) WARNING:INDENTED_LABEL: labels should not be indented #124: FILE: drivers/net/cnxk/cn10k_tx.h:55: + retry: \ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects? #149: FILE: drivers/net/cnxk/cn10k_tx.h:80: +#define NIX_XMIT_FC_CHECK_RETURN(txq, pkts) \ + do { \ + if (unlikely((txq)->flag)) \ + NIX_XMIT_FC_OR_RETURN_MTS(txq, pkts); \ + else { \ + NIX_XMIT_FC_OR_RETURN(txq, pkts); \ + /* Reduce the cached count */ \ + txq->fc_cache_pkts -= pkts; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pkts' - possible side-effects? #149: FILE: drivers/net/cnxk/cn10k_tx.h:80: +#define NIX_XMIT_FC_CHECK_RETURN(txq, pkts) \ + do { \ + if (unlikely((txq)->flag)) \ + NIX_XMIT_FC_OR_RETURN_MTS(txq, pkts); \ + else { \ + NIX_XMIT_FC_OR_RETURN(txq, pkts); \ + /* Reduce the cached count */ \ + txq->fc_cache_pkts -= pkts; \ + } \ + } while (0) total: 0 errors, 2 warnings, 4 checks, 103 lines checked ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-06 6:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230606061249.833290-1-rbhansali@marvell.com>
2023-06-06 6:02 ` |SUCCESS| pw128163 [PATCH] net/cnxk: add atomic fc check in poll mode Tx path qemudev
2023-06-06 6:06 ` qemudev
2023-06-06 6:13 ` |WARNING| " checkpatch
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).