|FAILURE| pw128387 [PATCH] cryptodev: avoid algorithm strings null pointers

|FAILURE| pw128387 [PATCH] cryptodev: avoid algorithm strings null pointers

[qemudev]

Test-Label: loongarch-compilation
Test-Status: FAILURE
http://dpdk.org/patch/128387

_ninja build failure_

Submitter: xixin.liu <liuxixin2020@outlook.com>
Date: Thu,  8 Jun 2023 13:31:31 +0800
DPDK git baseline: Repo:dpdk-next-crypto
  Branch: for-main
  CommitID: ea71e5c0d77a75ec10b4808fc6568c3baaf94488

128387 --> ninja build failed

Test environment and result as below:

+---------------------+----------------+
|     Environment     | compilation    |
+---------------------+----------------+
| Loongnix-Server 8.3 | FAIL           |
+---------------------+----------------+

Loongnix-Server 8.3
    Kernel: 4.19.190+
    Compiler: gcc 8.3


Ninja build logs:
-------------------------------BEGIN LOGS----------------------------
FAILED: lib/librte_cryptodev.a.p/cryptodev_rte_cryptodev.c.o
cc -Ilib/librte_cryptodev.a.p -Ilib -I../lib -Ilib/cryptodev -I../lib/cryptodev -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/loongarch/include -I../lib/eal/loongarch/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/rcu -I../lib/rcu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=loongarch64 -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_AP
 I -Wno-format-truncation -DRTE_LOG_DEFAULT_LOGTYPE=lib.cryptodev -MD -MQ lib/librte_cryptodev.a.p/cryptodev_rte_cryptodev.c.o -MF lib/librte_cryptodev.a.p/cryptodev_rte_cryptodev.c.o.d -o lib/librte_cryptodev.a.p/cryptodev_rte_cryptodev.c.o -c ../lib/cryptodev/rte_cryptodev.c
./lib/cryptodev/rte_cryptodev.c: In function ‘rte_cryptodev_get_aead_algo_enum’:
./lib/cryptodev/rte_cryptodev.c:396:47: error: stray ‘357’ in program
if (crypto_aead_algorithm_strings[i] == NULL）
^
./lib/cryptodev/rte_cryptodev.c:396:48: error: stray ‘274’ in program
if (crypto_aead_algorithm_strings[i] == NULL）
^
./lib/cryptodev/rte_cryptodev.c:396:49: error: stray ‘211’ in program
if (crypto_aead_algorithm_strings[i] == NULL）
^
./lib/cryptodev/rte_cryptodev.c:397:4: error: expected ‘)’ before ‘continue’
continue;
^~~~~~~~
./lib/cryptodev/rte_cryptodev.c:396:6: note: to match this ‘(’
if (crypto_aead_algorithm_strings[i] == NULL）
^
./lib/cryptodev/rte_cryptodev.c:403:2: error: expected expression before ‘}’ token
}
^
./lib/cryptodev/rte_cryptodev.c: In function ‘rte_cryptodev_asym_get_xform_enum’:
./lib/cryptodev/rte_cryptodev.c:418:7: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
if (crypto_asym_xform_strings[i] = NULL)
^~~~~~~~~~~~~~~~~~~~~~~~~
[163/2879] Compiling C object lib/librte_eventdev.a.p/eventdev_eventdev_private.c.o
[164/2879] Compiling C object lib/librte_compressdev.a.p/compressdev_rte_compressdev.c.o
[165/2879] Generating net.sym_chk with a custom command (wrapped by meson to capture output)
[166/2879] Compiling C object lib/librte_port.a.p/port_rte_port_sym_crypto.c.o
[167/2879] Compiling C object lib/librte_ethdev.a.p/ethdev_rte_flow.c.o
[168/2879] Compiling C object lib/librte_bpf.a.p/bpf_bpf_pkt.c.o
[169/2879] Compiling C object lib/librte_distributor.a.p/distributor_rte_distributor_single.c.o
[170/2879] Generating pci.sym_chk with a custom command (wrapped by meson to capture output)
[171/2879] Compiling C object lib/librte_acl.a.p/acl_acl_bld.c.o
[172/2879] Compiling C object lib/librte_eventdev.a.p/eventdev_rte_event_ring.c.o
[173/2879] Compiling C object lib/librte_cryptodev.a.p/cryptodev_cryptodev_trace_points.c.o
[174/2879] Compiling C object lib/librte_ethdev.a.p/ethdev_ethdev_trace_points.c.o
[175/2879] Compiling C object lib/librte_bpf.a.p/bpf_bpf_validate.c.o
[176/2879] Generating symbol file lib/librte_kvargs.so.23.2.p/librte_kvargs.so.23.2.symbols
[177/2879] Compiling C object lib/librte_eventdev.a.p/eventdev_eventdev_trace_points.c.o
[178/2879] Generating bitratestats.sym_chk with a custom command (wrapped by meson to capture output)
[179/2879] Generating metrics.sym_chk with a custom command (wrapped by meson to capture output)
[180/2879] Generating telemetry.sym_chk with a custom command (wrapped by meson to capture output)
[181/2879] Generating mempool.sym_chk with a custom command (wrapped by meson to capture output)
[182/2879] Generating bbdev.sym_chk with a custom command (wrapped by meson to capture output)
[183/2879] Generating rcu.sym_chk with a custom command (wrapped by meson to capture output)
[184/2879] Generating mbuf.sym_chk with a custom command (wrapped by meson to capture output)
[185/2879] Compiling C object lib/librte_distributor.a.p/distributor_rte_distributor.c.o
[186/2879] Generating cfgfile.sym_chk with a custom command (wrapped by meson to capture output)
[187/2879] Generating timer.sym_chk with a custom command (wrapped by meson to capture output)
[188/2879] Compiling C object lib/librte_efd.a.p/efd_rte_efd.c.o
[189/2879] Compiling C object lib/librte_eventdev.a.p/eventdev_rte_event_crypto_adapter.c.o
[190/2879] Generating cmdline.sym_chk with a custom command (wrapped by meson to capture output)
[191/2879] Compiling C object lib/librte_eventdev.a.p/eventdev_rte_event_eth_tx_adapter.c.o
[192/2879] Compiling C object lib/librte_hash.a.p/hash_rte_cuckoo_hash.c.o
[193/2879] Compiling C object lib/librte_eventdev.a.p/eventdev_rte_event_eth_rx_adapter.c.o
[194/2879] Compiling C object lib/librte_ethdev.a.p/ethdev_rte_ethdev.c.o
[195/2879] Generating eal.sym_chk with a custom command (wrapped by meson to capture output)
ninja: build stopped: subcommand failed.
-------------------------------END LOGS------------------------------

|WARNING| pw128387 [PATCH] cryptodev: avoid algorithm strings null pointers

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/128387

_coding style issues_


ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#159: FILE: lib/cryptodev/rte_cryptodev.c:415:
+		if (crypto_asym_xform_strings[i] = NULL)

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 2 errors, 0 warnings, 32 lines checked