From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Itamar Gozlan <igozlan@nvidia.com>
Subject: |WARNING| pw129196 [v2 2/5] app/testpmd: support indirect actions list syntax
Date: Mon, 3 Jul 2023 11:22:29 +0200 (CEST) [thread overview]
Message-ID: <20230703092229.197B2120922@dpdk.org> (raw)
In-Reply-To: <20230702045758.23244-2-igozlan@nvidia.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/129196
_coding style issues_
ERROR:CODE_INDENT: code indent should use tabs where possible
#321: FILE: app/test-pmd/cmdline_flow.c:7330:
+^I^I^I^I rte_flow_action_indirect_list)),$
ERROR:C99_COMMENTS: do not use C99 // comments
#341: FILE: app/test-pmd/cmdline_flow.c:7350:
+// .comp = comp_none,
ERROR:C99_COMMENTS: do not use C99 // comments
#347: FILE: app/test-pmd/cmdline_flow.c:7356:
+// .comp = comp_none,
ERROR:CODE_INDENT: code indent should use tabs where possible
#369: FILE: app/test-pmd/cmdline_flow.c:7893:
+ case INDIRECT_ACTION_FLOW_CONF:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#369: FILE: app/test-pmd/cmdline_flow.c:7893:
+ case INDIRECT_ACTION_FLOW_CONF:$
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#382: FILE: app/test-pmd/cmdline_flow.c:11405:
+ void __rte_unused *buf, unsigned int __rte_unused size)
^
ERROR:CODE_INDENT: code indent should use tabs where possible
#403: FILE: app/test-pmd/cmdline_flow.c:11426:
+ action_conf->handle = (typeof(action_conf->handle))$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#403: FILE: app/test-pmd/cmdline_flow.c:11426:
+ action_conf->handle = (typeof(action_conf->handle))$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#501: FILE: app/test-pmd/cmdline_flow.c:12531:
+ if (indlst_conf)
+ printf("created indirect action list configuration %u
",
ERROR:CODE_INDENT: code indent should use tabs where possible
#502: FILE: app/test-pmd/cmdline_flow.c:12532:
+ printf("created indirect action list configuration %u
",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#502: FILE: app/test-pmd/cmdline_flow.c:12532:
+ printf("created indirect action list configuration %u
",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#503: FILE: app/test-pmd/cmdline_flow.c:12533:
+ in->args.vc.attr.group);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#503: FILE: app/test-pmd/cmdline_flow.c:12533:
+ in->args.vc.attr.group);$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#504: FILE: app/test-pmd/cmdline_flow.c:12534:
+ else
+ printf("cannot create indirect action list configuration %u
",
ERROR:CODE_INDENT: code indent should use tabs where possible
#505: FILE: app/test-pmd/cmdline_flow.c:12535:
+ printf("cannot create indirect action list configuration %u
",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#505: FILE: app/test-pmd/cmdline_flow.c:12535:
+ printf("cannot create indirect action list configuration %u
",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#506: FILE: app/test-pmd/cmdline_flow.c:12536:
+ in->args.vc.attr.group);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#506: FILE: app/test-pmd/cmdline_flow.c:12536:
+ in->args.vc.attr.group);$
total: 10 errors, 8 warnings, 411 lines checked
parent reply other threads:[~2023-07-03 9:22 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230702045758.23244-2-igozlan@nvidia.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703092229.197B2120922@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=igozlan@nvidia.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).