From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0212942DA8
	for <public@inbox.dpdk.org>; Mon,  3 Jul 2023 11:22:30 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id F135040156;
	Mon,  3 Jul 2023 11:22:29 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 1D25240156
 for <test-report@dpdk.org>; Mon,  3 Jul 2023 11:22:29 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 197B2120922; Mon,  3 Jul 2023 11:22:29 +0200 (CEST)
Subject: |WARNING| pw129196 [v2 2/5] app/testpmd: support indirect actions
 list syntax
In-Reply-To: <20230702045758.23244-2-igozlan@nvidia.com>
References: <20230702045758.23244-2-igozlan@nvidia.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Itamar Gozlan <igozlan@nvidia.com>
Message-Id: <20230703092229.197B2120922@dpdk.org>
Date: Mon,  3 Jul 2023 11:22:29 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/129196

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#321: FILE: app/test-pmd/cmdline_flow.c:7330:
+^I^I^I^I           rte_flow_action_indirect_list)),$

ERROR:C99_COMMENTS: do not use C99 // comments
#341: FILE: app/test-pmd/cmdline_flow.c:7350:
+//		.comp = comp_none,

ERROR:C99_COMMENTS: do not use C99 // comments
#347: FILE: app/test-pmd/cmdline_flow.c:7356:
+//		.comp = comp_none,

ERROR:CODE_INDENT: code indent should use tabs where possible
#369: FILE: app/test-pmd/cmdline_flow.c:7893:
+        case INDIRECT_ACTION_FLOW_CONF:$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#369: FILE: app/test-pmd/cmdline_flow.c:7893:
+        case INDIRECT_ACTION_FLOW_CONF:$

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#382: FILE: app/test-pmd/cmdline_flow.c:11405:
+		    void __rte_unused *buf, unsigned int __rte_unused size)
 		                      ^

ERROR:CODE_INDENT: code indent should use tabs where possible
#403: FILE: app/test-pmd/cmdline_flow.c:11426:
+        action_conf->handle = (typeof(action_conf->handle))$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#403: FILE: app/test-pmd/cmdline_flow.c:11426:
+        action_conf->handle = (typeof(action_conf->handle))$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#501: FILE: app/test-pmd/cmdline_flow.c:12531:
+	if (indlst_conf)
+        printf("created indirect action list configuration %u
",

ERROR:CODE_INDENT: code indent should use tabs where possible
#502: FILE: app/test-pmd/cmdline_flow.c:12532:
+        printf("created indirect action list configuration %u
",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#502: FILE: app/test-pmd/cmdline_flow.c:12532:
+        printf("created indirect action list configuration %u
",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#503: FILE: app/test-pmd/cmdline_flow.c:12533:
+               in->args.vc.attr.group);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#503: FILE: app/test-pmd/cmdline_flow.c:12533:
+               in->args.vc.attr.group);$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#504: FILE: app/test-pmd/cmdline_flow.c:12534:
+	else
+        printf("cannot create indirect action list configuration %u
",

ERROR:CODE_INDENT: code indent should use tabs where possible
#505: FILE: app/test-pmd/cmdline_flow.c:12535:
+        printf("cannot create indirect action list configuration %u
",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#505: FILE: app/test-pmd/cmdline_flow.c:12535:
+        printf("cannot create indirect action list configuration %u
",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#506: FILE: app/test-pmd/cmdline_flow.c:12536:
+               in->args.vc.attr.group);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#506: FILE: app/test-pmd/cmdline_flow.c:12536:
+               in->args.vc.attr.group);$

total: 10 errors, 8 warnings, 411 lines checked