|WARNING| pw129674 [PATCH v3] tap: fix build of TAP BPF program

[checkpatch@dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/129674

_coding style issues_


WARNING:CONSTANT_CONVERSION: __constant_htons should be htons
#220: FILE: drivers/net/tap/bpf/bpf_api.h:44:
+# define htons(X)		__constant_htons((X))

WARNING:CONSTANT_CONVERSION: __constant_ntohs should be ntohs
#224: FILE: drivers/net/tap/bpf/bpf_api.h:48:
+# define ntohs(X)		__constant_ntohs((X))

WARNING:INLINE: plain inline is preferred over __inline__
#235: FILE: drivers/net/tap/bpf/bpf_api.h:59:
+#ifndef __inline__

WARNING:INLINE: plain inline is preferred over __inline__
#236: FILE: drivers/net/tap/bpf/bpf_api.h:60:
+# define __inline__		__attribute__((always_inline))

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#297: FILE: drivers/net/tap/bpf/bpf_api.h:121:
+# define __BPF_FUNC(NAME, ...)						\
+	(* NAME)(__VA_ARGS__) __maybe_unused

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'NAME' may be better as '(NAME)' to avoid precedence issues
#297: FILE: drivers/net/tap/bpf/bpf_api.h:121:
+# define __BPF_FUNC(NAME, ...)						\
+	(* NAME)(__VA_ARGS__) __maybe_unused

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#302: FILE: drivers/net/tap/bpf/bpf_api.h:126:
+# define BPF_FUNC(NAME, ...)						\
+	__BPF_FUNC(NAME, __VA_ARGS__) = (void *) BPF_FUNC_##NAME

CHECK:SPACING: No space is necessary after a cast
#303: FILE: drivers/net/tap/bpf/bpf_api.h:127:
+	__BPF_FUNC(NAME, __VA_ARGS__) = (void *) BPF_FUNC_##NAME

WARNING:TRACE_PRINTK: Do not use trace_printk() in production code (this can be ignored if built only with a debug config option)
#328: FILE: drivers/net/tap/bpf/bpf_api.h:152:
+		trace_printk(____fmt, sizeof(____fmt), ##__VA_ARGS__);	\

CHECK:SPACING: No space is necessary after a cast
#381: FILE: drivers/net/tap/bpf/bpf_api.h:205:
+		      (void *) BPF_FUNC_perf_event_output;

CHECK:SPACING: No space is necessary after a cast
#403: FILE: drivers/net/tap/bpf/bpf_api.h:227:
+# define lock_xadd(ptr, val)	((void) __sync_fetch_and_add(ptr, val))

WARNING:TYPO_SPELLING: 'useable' may be misspelled - perhaps 'usable'?
#418: FILE: drivers/net/tap/bpf/bpf_api.h:242:
+/* FIXME: __builtin_memcmp() is not yet fully useable unless llvm bug

WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#422: FILE: drivers/net/tap/bpf/bpf_api.h:246:
+#if 0

total: 2 errors, 7 warnings, 4 checks, 457 lines checked
Warning in drivers/net/tap/bpf/bpf_api.h:
Using compiler attribute directly
Warning in drivers/net/tap/bpf/bpf_api.h:
Using __sync_xxx builtins