From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 940AF42ED2 for ; Fri, 21 Jul 2023 01:26:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F414410E9; Fri, 21 Jul 2023 01:26:36 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 235EB410E9 for ; Fri, 21 Jul 2023 01:26:35 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 0F33412092E; Fri, 21 Jul 2023 01:26:35 +0200 (CEST) Subject: |WARNING| pw129674 [PATCH v3] tap: fix build of TAP BPF program In-Reply-To: <20230720232549.63619-1-stephen@networkplumber.org> References: <20230720232549.63619-1-stephen@networkplumber.org> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Stephen Hemminger Message-Id: <20230720232635.0F33412092E@dpdk.org> Date: Fri, 21 Jul 2023 01:26:35 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/129674 _coding style issues_ WARNING:CONSTANT_CONVERSION: __constant_htons should be htons #220: FILE: drivers/net/tap/bpf/bpf_api.h:44: +# define htons(X) __constant_htons((X)) WARNING:CONSTANT_CONVERSION: __constant_ntohs should be ntohs #224: FILE: drivers/net/tap/bpf/bpf_api.h:48: +# define ntohs(X) __constant_ntohs((X)) WARNING:INLINE: plain inline is preferred over __inline__ #235: FILE: drivers/net/tap/bpf/bpf_api.h:59: +#ifndef __inline__ WARNING:INLINE: plain inline is preferred over __inline__ #236: FILE: drivers/net/tap/bpf/bpf_api.h:60: +# define __inline__ __attribute__((always_inline)) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #297: FILE: drivers/net/tap/bpf/bpf_api.h:121: +# define __BPF_FUNC(NAME, ...) \ + (* NAME)(__VA_ARGS__) __maybe_unused CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'NAME' may be better as '(NAME)' to avoid precedence issues #297: FILE: drivers/net/tap/bpf/bpf_api.h:121: +# define __BPF_FUNC(NAME, ...) \ + (* NAME)(__VA_ARGS__) __maybe_unused ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #302: FILE: drivers/net/tap/bpf/bpf_api.h:126: +# define BPF_FUNC(NAME, ...) \ + __BPF_FUNC(NAME, __VA_ARGS__) = (void *) BPF_FUNC_##NAME CHECK:SPACING: No space is necessary after a cast #303: FILE: drivers/net/tap/bpf/bpf_api.h:127: + __BPF_FUNC(NAME, __VA_ARGS__) = (void *) BPF_FUNC_##NAME WARNING:TRACE_PRINTK: Do not use trace_printk() in production code (this can be ignored if built only with a debug config option) #328: FILE: drivers/net/tap/bpf/bpf_api.h:152: + trace_printk(____fmt, sizeof(____fmt), ##__VA_ARGS__); \ CHECK:SPACING: No space is necessary after a cast #381: FILE: drivers/net/tap/bpf/bpf_api.h:205: + (void *) BPF_FUNC_perf_event_output; CHECK:SPACING: No space is necessary after a cast #403: FILE: drivers/net/tap/bpf/bpf_api.h:227: +# define lock_xadd(ptr, val) ((void) __sync_fetch_and_add(ptr, val)) WARNING:TYPO_SPELLING: 'useable' may be misspelled - perhaps 'usable'? #418: FILE: drivers/net/tap/bpf/bpf_api.h:242: +/* FIXME: __builtin_memcmp() is not yet fully useable unless llvm bug WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif #422: FILE: drivers/net/tap/bpf/bpf_api.h:246: +#if 0 total: 2 errors, 7 warnings, 4 checks, 457 lines checked Warning in drivers/net/tap/bpf/bpf_api.h: Using compiler attribute directly Warning in drivers/net/tap/bpf/bpf_api.h: Using __sync_xxx builtins